From patchwork Tue Jul 19 09:40:17 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dominik Vogt X-Patchwork-Id: 650152 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3rtzQD6VTTz9s36 for ; Tue, 19 Jul 2016 22:10:28 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=Kd+Xi6Cn; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:reply-to:mime-version:content-type :message-id; q=dns; s=default; b=eesSyFs3pJHnyyJMBtjUrcseI7RQHDy Epez1U1QXh098FXsZLWwy0Xr0kHQooyfFk2XfolSbgZKB/EqDYbw0jyNFse8R/mr tTw2B+Nr7NYWKpa1PBxWmhTFt0Tz+XhIRJ9UIEWwqkX0a22u7gwkFgYoj5Z3wZKP X5t41FG8tBDI= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:reply-to:mime-version:content-type :message-id; s=default; bh=ViGORVe3SmOWbGrtln7f2JxBN6E=; b=Kd+Xi 6CnfqdXqOkGq7fkv5RefSJysahvgeHsy0Va3OdyR+0zovlK6N9QEAeaPGMJMhhvc G1ISYMiKVLK3Xd4kGH1K5VkEvKsMUFK+GJsYDhEH8QCO0CH3rvyWfabhMvCp8SEL PyF7VOgEPgHkZEu4IaGNvUlbMvZ0EY+HPiE3HM= Received: (qmail 85891 invoked by alias); 19 Jul 2016 12:10:15 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 85779 invoked by uid 89); 19 Jul 2016 12:10:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL, BAYES_00, KAM_LAZY_DOMAIN_SECURITY, RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy=prefers, ciao, Hx-languages-length:2351, Vogt X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 19 Jul 2016 12:10:13 +0000 Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u6JC97ob069679 for ; Tue, 19 Jul 2016 08:10:11 -0400 Received: from e06smtp05.uk.ibm.com (e06smtp05.uk.ibm.com [195.75.94.101]) by mx0a-001b2d01.pphosted.com with ESMTP id 2495r918dh-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 19 Jul 2016 08:10:11 -0400 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 19 Jul 2016 13:10:08 +0100 Received: from d06dlp02.portsmouth.uk.ibm.com (9.149.20.14) by e06smtp05.uk.ibm.com (192.168.101.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 19 Jul 2016 13:09:56 +0100 X-IBM-Helo: d06dlp02.portsmouth.uk.ibm.com X-IBM-MailFrom: vogt@linux.vnet.ibm.com X-IBM-RcptTo: gcc-patches@gcc.gnu.org Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 6F5E62190061 for ; Tue, 19 Jul 2016 13:09:23 +0100 (BST) Received: from d06av01.portsmouth.uk.ibm.com (d06av01.portsmouth.uk.ibm.com [9.149.37.212]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u6JC9tbf262564 for ; Tue, 19 Jul 2016 12:09:55 GMT Received: from d06av01.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av01.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u6JC9tIv015403 for ; Tue, 19 Jul 2016 06:09:55 -0600 Received: from oc5510024614.ibm.com (dyn-9-152-212-82.boeblingen.de.ibm.com [9.152.212.82]) by d06av01.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id u6JC9ttO015396 for ; Tue, 19 Jul 2016 06:09:55 -0600 Received: by oc5510024614.ibm.com (Postfix, from userid 500) id DFB6F17E42; Tue, 19 Jul 2016 11:40:17 +0200 (CEST) Date: Tue, 19 Jul 2016 10:40:17 +0100 From: Dominik Vogt To: gcc-patches@gcc.gnu.org Cc: Andreas Krebbel Subject: [PATCH] S/390: Xfail some tests in insv-[12].c. Reply-To: vogt@linux.vnet.ibm.com Mail-Followup-To: vogt@linux.vnet.ibm.com, gcc-patches@gcc.gnu.org, Andreas Krebbel MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.20 (2009-12-10) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16071912-0020-0000-0000-000001D5D77F X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16071912-0021-0000-0000-00001CC4B79E Message-Id: <20160719094017.GA22306@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2016-07-19_09:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=1 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1607190131 The attached patch XFAILs some of the "insv" testcases as discussed internally. Tested on s390x biarch and s390. Ciao Dominik ^_^ ^_^ diff --git a/gcc/testsuite/gcc.target/s390/insv-1.c b/gcc/testsuite/gcc.target/s390/insv-1.c index e6c1b8b..8d464f5 100644 --- a/gcc/testsuite/gcc.target/s390/insv-1.c +++ b/gcc/testsuite/gcc.target/s390/insv-1.c @@ -108,4 +108,11 @@ foo4c (unsigned long a, unsigned long b) #endif } -/* { dg-final { scan-assembler-times "risbg" 6 } } */ +/* The functions foo3, foo4, foo3b, foo4b no longer use risbg but rosbg instead. + + On s390x, four risbg go away and four new ones appear in other functions ... + { dg-final { scan-assembler-times "risbg" 6 { target { s390x-*-* } } } } + + but not on s390. + { dg-final { scan-assembler-times "risbg" 2 { target { s390-*-* } } } } +*/ diff --git a/gcc/testsuite/gcc.target/s390/insv-2.c b/gcc/testsuite/gcc.target/s390/insv-2.c index 2ba6d6c..70af123 100644 --- a/gcc/testsuite/gcc.target/s390/insv-2.c +++ b/gcc/testsuite/gcc.target/s390/insv-2.c @@ -108,4 +108,17 @@ foo4c (unsigned long a, unsigned long b) #endif } -/* { dg-final { scan-assembler-times "risbgn" 6 } } */ +/* The functions foo3, foo4, foo3b, foo4b no longer use risbgn but rosbg instead + which is slightly worse. Combine prefers to use the simpler two insn + combinations possible with rosbg instead of the more complicated three insn + combinations that result in risbgn. This problem has been introduced with + the commit + + S/390: Add patterns for rsbg instructions. + + (3rd of May, 2016). This should be fixed some time in the future, but for + now just adapt the expected result: + + { dg-final { scan-assembler-times "risbgn" 6 { xfail { *-*-* } } } } + { dg-final { scan-assembler-times "risbgn" 2 } } +*/