diff mbox

[hsa,merge,00/10] Merge of HSA branch

Message ID 20160127142025.GD29688@virgil.suse.cz
State New
Headers show

Commit Message

Martin Jambor Jan. 27, 2016, 2:20 p.m. UTC
Hi,

sorry for getting so late to this:

On Thu, Jan 21, 2016 at 05:10:17PM -0600, Gerald Pfeifer wrote:
> On Tue, 19 Jan 2016, Richard Biener wrote:
> > I think the merge warrants a NEWS entry on gcc.gnu.org/
> 
> ...and gcc-6/changes.html. :-)
> 
> Martin, happy to help.  Want to propose some text (or even patch)?
> 

So what would you think about the following?  Perhaps it is too
verbose but I wanted to mention the few areas users should know have
changed, if they happen to try HSA out.  I can certainly cut it down a
bit.


Any comments welcome.

Thanks,

Martin

Comments

Gerald Pfeifer Jan. 28, 2016, 3:18 p.m. UTC | #1
Hi Martin,

On Wed, 27 Jan 2016, Martin Jambor wrote:
> So what would you think about the following?  Perhaps it is too
> verbose but I wanted to mention the few areas users should know 
> have changed, if they happen to try HSA out.  I can certainly 
> cut it down a bit.

I like this.  In fact, in one or two spots we even may want to
be a little bit longer on the changes.html page.  (Definitely a
good idea to split this into the shorter announcement and the
longer one for the release notes.)

> Index: changes.html
> ===================================================================
> +     <li><p>GCC can now generate HSAIL for simple OpenMP device constructs
> +       if configured with <code>--enable-offload-targets=hsa</code>.  A new
> +       libgomp plugin then run these HSAIL kernels implementing these
> +       constructs on HSA capable GPUs via standard HSA run-time.</p>

"run" -> "runs"

"via a standard HSA"

"run-time" -> "run time" (since it's a noun)

Will everyone know what HSAIL is?  Should we expand the acronym
at first or note (in parenthesis what it is)?

> +       <p>If the HSA compilation back-end determines it cannot output HSAIL
> +       for a particular input, it gives a warning by default.  These
> +       warnings can be suppressed with <code>-Wno-hsa</code>.  To give a
> +       few examples, the HSA back-end does not implement compilation of

"back end"

> +       code using function pointers and variable-sized variables and

"variable-sized variables" is a bit confusing. ;-)  Is there a
better term?  "variable-sized arrays" I know, for example.

> +       <p>When compilation for HSA is enabled, the compiler attempts to
> +       compile composite OpenMP constructs
> +	 <blockquote><pre>
> +#pragma omp target teams distribute parallel for</pre></blockquote>
> +	 into parallel HSA GPU kernels.</p>

Above we had "HSAIL kernels", here "HSA GPU kernels".  Should we
converge on one?

> Index: index.html
> ===================================================================
> +<dt><span> Heterogeneous Systems Architecture support in GCC</span>

Here I would omit the "in GCC" since this is our main page.

> +     <span class="date">[2016-01-27]</span></dt>
> +     <dd><a href="http://www.hsafoundation.com/"> Heterogeneous Systems
> +     Architecture 1.0</a> <a href="https://gcc.gnu.org/gcc-6/changes.html#hsa">
> +     support was added to GCC.</a>  Contributed by Martin Jambor, Martin Liška
> +     and Michael Matz from SUSE.</dd>

How about "to GCC</a>, contributed by..."?

Not too long for the main page I'd say.


This is okay with the changes/considering the questions above.

Gerald
diff mbox

Patch

Index: changes.html
===================================================================
RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-6/changes.html,v
retrieving revision 1.52
diff -u -r1.52 changes.html
--- changes.html	25 Jan 2016 15:09:55 -0000	1.52
+++ changes.html	27 Jan 2016 14:15:49 -0000
@@ -272,6 +272,30 @@ 
    </ul>
 <!-- <h3 id="avr">AVR</h3> -->
 
+<h3 id="hsa">Heterogeneous Systems Architecture</h3>
+   <ul>
+     <li><p>GCC can now generate HSAIL for simple OpenMP device constructs
+       if configured with <code>--enable-offload-targets=hsa</code>.  A new
+       libgomp plugin then run these HSAIL kernels implementing these
+       constructs on HSA capable GPUs via standard HSA run-time.</p>
+       
+       <p>If the HSA compilation back-end determines it cannot output HSAIL
+       for a particular input, it gives a warning by default.  These
+       warnings can be suppressed with <code>-Wno-hsa</code>.  To give a
+       few examples, the HSA back-end does not implement compilation of
+       code using function pointers and variable-sized variables and
+       parameters, functions with variadic arguments as well as a number of
+       other less common programming constructs.</p>
+
+       <p>When compilation for HSA is enabled, the compiler attempts to
+       compile composite OpenMP constructs
+	 <blockquote><pre>
+#pragma omp target teams distribute parallel for</pre></blockquote>
+	 into parallel HSA GPU kernels.</p>
+     </li>
+   </ul>
+
+
 <h3 id="x86">IA-32/x86-64</h3>
    <ul>
      <li>GCC now supports the Intel CPU named Skylake with AVX-512 extensions

The change to the news on the main page might then be:

Index: index.html
===================================================================
RCS file: /cvs/gcc/wwwdocs/htdocs/index.html,v
retrieving revision 1.992
diff -u -r1.992 index.html
--- index.html	24 Jan 2016 23:54:36 -0000	1.992
+++ index.html	27 Jan 2016 14:16:25 -0000
@@ -52,6 +52,13 @@ 
 
 <dl class="news">
 
+<dt><span> Heterogeneous Systems Architecture support in GCC</span>
+     <span class="date">[2016-01-27]</span></dt>
+     <dd><a href="http://www.hsafoundation.com/"> Heterogeneous Systems
+     Architecture 1.0</a> <a href="https://gcc.gnu.org/gcc-6/changes.html#hsa">
+     support was added to GCC.</a>  Contributed by Martin Jambor, Martin Liška
+     and Michael Matz from SUSE.</dd>
+
 <dt><span><a href="gcc-5/">GCC 5.3</a> released</span>
     <span class="date">[2015-12-04]</span></dt>
     <dd></dd>