From patchwork Thu Nov 12 09:57:28 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ilya Enkovich X-Patchwork-Id: 543290 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 1CBD81413F1 for ; Thu, 12 Nov 2015 20:58:19 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=Qy19gM2c; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:subject:message-id:mime-version:content-type; q=dns; s= default; b=qKKnptY3ea0AL2o/KBrtuaeyNIfoiPAOFlPClR94W6h23d72kEqO3 v9KY0fynaqcfKdNu6BPaNiXqMP45PjKA+moXWrEXgnO5FNYgTz/lRVLXv0yQ82L6 JBejkyAYztHximLbG0gDPbwA4osSIQUZVNEberNSeyvubE1t4Jd+II= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:subject:message-id:mime-version:content-type; s= default; bh=w3x6OuOyZiCjLkxnoOY9ZWGQRaY=; b=Qy19gM2cv+oEeLT9PrQv CK+MokoiLOeV7P/ZaviaMKOHNCkyZLVssfMWU73EIx366G6A8RVLeSC81UmrY+XB oALN9eGkagIqsxc7jBseQj2dXn0V8DhxpG0fyYxw+jeyxEY7jkLa9MArOPdQKsRW HplePNKM300xZMJ91WNArZM= Received: (qmail 61639 invoked by alias); 12 Nov 2015 09:58:12 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 61627 invoked by uid 89); 12 Nov 2015 09:58:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-wm0-f54.google.com Received: from mail-wm0-f54.google.com (HELO mail-wm0-f54.google.com) (74.125.82.54) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 12 Nov 2015 09:58:10 +0000 Received: by wmdw130 with SMTP id w130so146756138wmd.0 for ; Thu, 12 Nov 2015 01:58:07 -0800 (PST) X-Received: by 10.194.205.137 with SMTP id lg9mr12056158wjc.156.1447322287909; Thu, 12 Nov 2015 01:58:07 -0800 (PST) Received: from msticlxl57.ims.intel.com (jfdmzpr03-ext.jf.intel.com. [134.134.139.72]) by smtp.gmail.com with ESMTPSA id s2sm29827731wmd.13.2015.11.12.01.58.05 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 Nov 2015 01:58:07 -0800 (PST) Date: Thu, 12 Nov 2015 12:57:28 +0300 From: Ilya Enkovich To: gcc-patches@gcc.gnu.org Subject: [PATCH, PR68286] Fix vector comparison expand Message-ID: <20151112095728.GA51435@msticlxl57.ims.intel.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes Hi, My vector comparison patches broken expand of vector comparison on targets which don't have new comparison patterns but support VEC_COND_EXPR. This happens because it's not checked vector comparison may be expanded as a comparison. This patch fixes it. Bootstrapped and regtested on powerpc64le-unknown-linux-gnu. OK for trunk? Thanks, Ilya --- gcc/ 2015-11-12 Ilya Enkovich * expr.c (do_store_flag): Expand vector comparison as VEC_COND_EXPR if vector comparison is not supported by target. gcc/testsuite/ 2015-11-12 Ilya Enkovich * gcc.dg/pr68286.c: New test. diff --git a/gcc/expr.c b/gcc/expr.c index 03936ee..bd43dc4 100644 --- a/gcc/expr.c +++ b/gcc/expr.c @@ -11128,7 +11128,8 @@ do_store_flag (sepops ops, rtx target, machine_mode mode) if (TREE_CODE (ops->type) == VECTOR_TYPE) { tree ifexp = build2 (ops->code, ops->type, arg0, arg1); - if (VECTOR_BOOLEAN_TYPE_P (ops->type)) + if (VECTOR_BOOLEAN_TYPE_P (ops->type) + && expand_vec_cmp_expr_p (TREE_TYPE (arg0), ops->type)) return expand_vec_cmp_expr (ops->type, ifexp, target); else { diff --git a/gcc/testsuite/gcc.dg/pr68286.c b/gcc/testsuite/gcc.dg/pr68286.c new file mode 100644 index 0000000..d0392e8 --- /dev/null +++ b/gcc/testsuite/gcc.dg/pr68286.c @@ -0,0 +1,17 @@ +/* PR target/68286 */ +/* { dg-do compile } */ +/* { dg-options "-O3" } */ + +int a, b, c; +int fn1 () +{ + int d[] = {0}; + for (; c; c++) + { + float e = c; + if (e) + d[0]++; + } + b = d[0]; + return a; +}