Message ID | 20151012095840.63E773CDC@oc7340732750.ibm.com |
---|---|
State | New |
Headers | show |
On 10/12/2015 11:58 AM, Ulrich Weigand wrote: > > Index: gcc/configure.ac > =================================================================== > --- gcc/configure.ac (revision 228530) > +++ gcc/configure.ac (working copy) > @@ -1993,7 +1993,7 @@ elif test "x$TARGET_SYSTEM_ROOT" != x; t > fi > > if test x$host != x$target || test "x$TARGET_SYSTEM_ROOT" != x; then > - if test "x$with_headers" != x; then > + if test "x$with_headers" != x && test "x$with_headers" != xyes; then > target_header_dir=$with_headers > elif test "x$with_sysroot" = x; then > target_header_dir="${test_exec_prefix}/${target_noncanonical}/sys-include" I'm missing the beginning of this conversation, but this looks like a reasonable change (avoiding target_header_dir=yes for --with-headers). So, approved. Bernd
On 23/10/15 12:31, Bernd Schmidt wrote: > On 10/12/2015 11:58 AM, Ulrich Weigand wrote: >> >> Index: gcc/configure.ac >> =================================================================== >> --- gcc/configure.ac (revision 228530) >> +++ gcc/configure.ac (working copy) >> @@ -1993,7 +1993,7 @@ elif test "x$TARGET_SYSTEM_ROOT" != x; t >> fi >> >> if test x$host != x$target || test "x$TARGET_SYSTEM_ROOT" != x; then >> - if test "x$with_headers" != x; then >> + if test "x$with_headers" != x && test "x$with_headers" != xyes; then >> target_header_dir=$with_headers >> elif test "x$with_sysroot" = x; then >> >> target_header_dir="${test_exec_prefix}/${target_noncanonical}/sys-include" >> > > I'm missing the beginning of this conversation, but this looks like a > reasonable change (avoiding target_header_dir=yes for --with-headers). > So, approved. > > > Bernd > Hi there, I was wondering why this never made it to trunk. I am currently running into an issue that this patch would fix. Cheers, Andre
On 17/03/16 16:33, Andre Vieira (lists) wrote: > On 23/10/15 12:31, Bernd Schmidt wrote: >> On 10/12/2015 11:58 AM, Ulrich Weigand wrote: >>> >>> Index: gcc/configure.ac >>> =================================================================== >>> --- gcc/configure.ac (revision 228530) >>> +++ gcc/configure.ac (working copy) >>> @@ -1993,7 +1993,7 @@ elif test "x$TARGET_SYSTEM_ROOT" != x; t >>> fi >>> >>> if test x$host != x$target || test "x$TARGET_SYSTEM_ROOT" != x; then >>> - if test "x$with_headers" != x; then >>> + if test "x$with_headers" != x && test "x$with_headers" != xyes; then >>> target_header_dir=$with_headers >>> elif test "x$with_sysroot" = x; then >>> >>> target_header_dir="${test_exec_prefix}/${target_noncanonical}/sys-include" >>> >> >> I'm missing the beginning of this conversation, but this looks like a >> reasonable change (avoiding target_header_dir=yes for --with-headers). >> So, approved. >> >> >> Bernd >> > Hi there, > > I was wondering why this never made it to trunk. I am currently running > into an issue that this patch would fix. > > Cheers, > Andre > We decided to apply this to the embedded-5-branch at revision r234576. Cheers, Andre
On 17/03/16 16:33, Andre Vieira (lists) wrote: > On 23/10/15 12:31, Bernd Schmidt wrote: >> On 10/12/2015 11:58 AM, Ulrich Weigand wrote: >>> >>> Index: gcc/configure.ac >>> =================================================================== >>> --- gcc/configure.ac (revision 228530) >>> +++ gcc/configure.ac (working copy) >>> @@ -1993,7 +1993,7 @@ elif test "x$TARGET_SYSTEM_ROOT" != x; t >>> fi >>> >>> if test x$host != x$target || test "x$TARGET_SYSTEM_ROOT" != x; then >>> - if test "x$with_headers" != x; then >>> + if test "x$with_headers" != x && test "x$with_headers" != xyes; then >>> target_header_dir=$with_headers >>> elif test "x$with_sysroot" = x; then >>> >>> target_header_dir="${test_exec_prefix}/${target_noncanonical}/sys-include" >>> >> >> I'm missing the beginning of this conversation, but this looks like a >> reasonable change (avoiding target_header_dir=yes for --with-headers). >> So, approved. >> >> >> Bernd >> > Hi there, > > I was wondering why this never made it to trunk. I am currently running > into an issue that this patch would fix. > > Cheers, > Andre > Ping.
On 07/04/16 10:30, Andre Vieira (lists) wrote: > On 17/03/16 16:33, Andre Vieira (lists) wrote: >> On 23/10/15 12:31, Bernd Schmidt wrote: >>> On 10/12/2015 11:58 AM, Ulrich Weigand wrote: >>>> >>>> Index: gcc/configure.ac >>>> =================================================================== >>>> --- gcc/configure.ac (revision 228530) >>>> +++ gcc/configure.ac (working copy) >>>> @@ -1993,7 +1993,7 @@ elif test "x$TARGET_SYSTEM_ROOT" != x; t >>>> fi >>>> >>>> if test x$host != x$target || test "x$TARGET_SYSTEM_ROOT" != x; then >>>> - if test "x$with_headers" != x; then >>>> + if test "x$with_headers" != x && test "x$with_headers" != xyes; then >>>> target_header_dir=$with_headers >>>> elif test "x$with_sysroot" = x; then >>>> >>>> target_header_dir="${test_exec_prefix}/${target_noncanonical}/sys-include" >>>> >>> >>> I'm missing the beginning of this conversation, but this looks like a >>> reasonable change (avoiding target_header_dir=yes for --with-headers). >>> So, approved. >>> >>> >>> Bernd >>> >> Hi there, >> >> I was wondering why this never made it to trunk. I am currently running >> into an issue that this patch would fix. >> >> Cheers, >> Andre >> > Ping. > Ping.
Index: gcc/configure.ac =================================================================== --- gcc/configure.ac (revision 228530) +++ gcc/configure.ac (working copy) @@ -1993,7 +1993,7 @@ elif test "x$TARGET_SYSTEM_ROOT" != x; t fi if test x$host != x$target || test "x$TARGET_SYSTEM_ROOT" != x; then - if test "x$with_headers" != x; then + if test "x$with_headers" != x && test "x$with_headers" != xyes; then target_header_dir=$with_headers elif test "x$with_sysroot" = x; then target_header_dir="${test_exec_prefix}/${target_noncanonical}/sys-include"