From patchwork Wed Jul 15 00:09:48 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Meissner X-Patchwork-Id: 495352 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4703B14077B for ; Wed, 15 Jul 2015 10:10:03 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=YdGsmZJc; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:subject:message-id:mime-version:content-type; q=dns; s= default; b=KnaayurzllXiShQy7yPrzIgbRxdM3Gyl02TvJOuBBTHteGdMSrq5n hiucTVFq/TIMYwpwVuyYFp0uovWTVjWYzH79Hkrn89n4FX24h8R6RIXMXMuzXyGd eOt47l2sxvy5fPpwYEd2z/R9Wnk+nWn1TZKRp/eUhdL4iYXOa2ddcw= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:subject:message-id:mime-version:content-type; s= default; bh=p6MvFxsaIUsjl807/FNEKWlQLU4=; b=YdGsmZJcAuBFdPQFUu6d 2VXeGUbtr0/QEn5xHb02NkPOnUlQCLLCzS0+PvZiCEtG8rMh+mwFEb3qH09xVlk7 d45oh0Flv6tkejOErLJ0kMv60CnDw5UIC7PB6VYYnixa1H0o25+QLeidsOI2I2wy IP7157lEPpxghLnURaO9mtU= Received: (qmail 59150 invoked by alias); 15 Jul 2015 00:09:55 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 59136 invoked by uid 89); 15 Jul 2015 00:09:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL, BAYES_00, KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 X-HELO: e33.co.us.ibm.com Received: from e33.co.us.ibm.com (HELO e33.co.us.ibm.com) (32.97.110.151) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Wed, 15 Jul 2015 00:09:52 +0000 Received: from /spool/local by e33.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 14 Jul 2015 18:09:51 -0600 Received: from d03dlp01.boulder.ibm.com (9.17.202.177) by e33.co.us.ibm.com (192.168.1.133) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 14 Jul 2015 18:09:49 -0600 X-MailFrom: meissner@ibm-tiger.the-meissners.org X-RcptTo: gcc-patches@gcc.gnu.org Received: from b03cxnp08027.gho.boulder.ibm.com (b03cxnp08027.gho.boulder.ibm.com [9.17.130.19]) by d03dlp01.boulder.ibm.com (Postfix) with ESMTP id 7E9F01FF002E for ; Tue, 14 Jul 2015 18:00:59 -0600 (MDT) Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by b03cxnp08027.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t6F09nxY42991672 for ; Tue, 14 Jul 2015 17:09:49 -0700 Received: from d03av02.boulder.ibm.com (localhost [127.0.0.1]) by d03av02.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t6F09mQq016207 for ; Tue, 14 Jul 2015 18:09:48 -0600 Received: from ibm-tiger.the-meissners.org (dhcp-9-32-77-111.usma.ibm.com [9.32.77.111]) by d03av02.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id t6F09mnY016193; Tue, 14 Jul 2015 18:09:48 -0600 Received: by ibm-tiger.the-meissners.org (Postfix, from userid 500) id 4BCB445D8B; Tue, 14 Jul 2015 20:09:48 -0400 (EDT) Date: Tue, 14 Jul 2015 20:09:48 -0400 From: Michael Meissner To: gcc-patches@gcc.gnu.org, dje.gcc@gmail.com Subject: [PR 66854 powerpc regression] Fix RTEMS powerpc build issue Message-ID: <20150715000947.GA4221@ibm-tiger.the-meissners.org> Mail-Followup-To: Michael Meissner , gcc-patches@gcc.gnu.org, dje.gcc@gmail.com MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.20 (2009-12-10) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15071500-0009-0000-0000-00000C77F926 X-IsSubscribed: yes My IEEE 128-bit floating point infrastructure patches resulted in a segmentation violation on RTEMS when building libgcc. I had put a test using a type tree variable before the test whether it was NULL or not. This patch bootstraps on 64-bit Linux, and it also fixes the problem in question when building a RTEMS compiler. Can this patch be installed if it causes no further regressions for RTEMS? 2015-07-14 Michael Meissner PR target/66854 * config/rs6000/rs6000.c (rs6000_pass_by_reference): Move test for null before IEEE 128-bit floating point support patch. Index: gcc/config/rs6000/rs6000.c =================================================================== --- gcc/config/rs6000/rs6000.c (revision 225780) +++ gcc/config/rs6000/rs6000.c (working copy) @@ -10832,6 +10832,9 @@ machine_mode mode, const_tree type, bool named ATTRIBUTE_UNUSED) { + if (!type) + return 0; + if (DEFAULT_ABI == ABI_V4 && TARGET_IEEEQUAD && FLOAT128_IEEE_P (TYPE_MODE (type))) { @@ -10840,9 +10843,6 @@ return 1; } - if (!type) - return 0; - if (DEFAULT_ABI == ABI_V4 && AGGREGATE_TYPE_P (type)) { if (TARGET_DEBUG_ARG)