diff mbox

[RS6000,1/7] Hide insns not needing to be public

Message ID 20150624005012.GV1723@bubble.grove.modra.org
State New
Headers show

Commit Message

Alan Modra June 24, 2015, 12:50 a.m. UTC 
* config/rs6000/rs6000.md (addsi3_high, bswaphi2_internal,
	ashldi3_internal5, ashldi3_internal8): Prefix with '*'.

Comments

David Edelsohn June 25, 2015, 12:29 a.m. UTC | #1 
On Tue, Jun 23, 2015 at 8:50 PM, Alan Modra <amodra@gmail.com> wrote:
>         * config/rs6000/rs6000.md (addsi3_high, bswaphi2_internal,
>         ashldi3_internal5, ashldi3_internal8): Prefix with '*'.

This patch is okay.

The rotate changes need to be discussed and coordinated with Segher.

The cost changes are okay in theory, but really should be applied in
conjunction with the rtx_cost improvements that you are discussing
with Jeff.

Thanks, David
diff mbox

Patch

diff --git a/gcc/config/rs6000/rs6000.md b/gcc/config/rs6000/rs6000.md
index 6a14ee8..243a151 100644
--- a/gcc/config/rs6000/rs6000.md
+++ b/gcc/config/rs6000/rs6000.md
@@ -1515,7 +1515,7 @@ 
    addis %0,%1,%v2"
   [(set_attr "type" "add")])
 
-(define_insn "addsi3_high"
+(define_insn "*addsi3_high"
   [(set (match_operand:SI 0 "gpc_reg_operand" "=b")
         (plus:SI (match_operand:SI 1 "gpc_reg_operand" "b")
                  (high:SI (match_operand 2 "" ""))))]
@@ -2173,7 +2173,7 @@ 
     operands[1] = force_reg (HImode, operands[1]);
 })
 
-(define_insn "bswaphi2_internal"
+(define_insn "*bswaphi2_internal"
   [(set (match_operand:HI 0 "reg_or_mem_operand" "=r,Z,&r")
 	(bswap:HI
 	 (match_operand:HI 1 "reg_or_mem_operand" "Z,r,r")))
@@ -5873,7 +5873,7 @@ 
   "rldic %0,%1,%H2,%W3"
   [(set_attr "type" "shift")])
 
-(define_insn "ashldi3_internal5"
+(define_insn "*ashldi3_internal5"
   [(set (match_operand:CC 0 "cc_reg_operand" "=x,?y")
 	(compare:CC
 	 (and:DI (ashift:DI (match_operand:DI 1 "gpc_reg_operand" "r,r")
@@ -5952,7 +5952,7 @@ 
   "rldicr %0,%1,%H2,%S3"
   [(set_attr "type" "shift")])
 
-(define_insn "ashldi3_internal8"
+(define_insn "*ashldi3_internal8"
   [(set (match_operand:CC 0 "cc_reg_operand" "=x,?y")
 	(compare:CC
 	 (and:DI (ashift:DI (match_operand:DI 1 "gpc_reg_operand" "r,r")