From patchwork Mon Jun 15 09:03:33 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Alan Modra X-Patchwork-Id: 484182 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 80A0E1401AF for ; Mon, 15 Jun 2015 19:03:50 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=LBcizmIH; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:references:mime-version :content-type:content-transfer-encoding:in-reply-to; q=dns; s= default; b=e6YBx0bT7tpZ2HhU2sfmkh2ZS01K+V2i/Lucx4iEwhJdV3ba/Z4YV LLNgNWSociCivaCzzEoM7z11oyLztpAcsqpLkWbSjDo9FZEhCu3WJTKpbVNVXJDl HfUdDBfjS8kEAy9JV0+owKqwk9xhQibNvfpBQUJbJXh/GUZJtFNfKs= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:references:mime-version :content-type:content-transfer-encoding:in-reply-to; s=default; bh=PGBm53J2erp+tk7C8eYJZptai1I=; b=LBcizmIHZGFp237e68V57Mxl1Qpi WZ348MgWEoi85Zet090fIvxISQBMSVjlwShOsFuhq9B22Kpyqzgd75s3lOt8CmZF vtWohnJ/eZXjEYynAJSrjk1jRS9MWhzfPKnFdjeuPDhYVWDWI12sUhE2ilxqSkZq es7BrWdugV7pzL8= Received: (qmail 49174 invoked by alias); 15 Jun 2015 09:03:43 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 49154 invoked by uid 89); 15 Jun 2015 09:03:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.6 required=5.0 tests=AWL, BAYES_50, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f54.google.com Received: from mail-pa0-f54.google.com (HELO mail-pa0-f54.google.com) (209.85.220.54) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 15 Jun 2015 09:03:41 +0000 Received: by pacgb13 with SMTP id gb13so31590742pac.1 for ; Mon, 15 Jun 2015 02:03:39 -0700 (PDT) X-Received: by 10.70.131.33 with SMTP id oj1mr46283361pdb.3.1434359019348; Mon, 15 Jun 2015 02:03:39 -0700 (PDT) Received: from bubble.grove.modra.org (CPE-58-160-155-134.oycza5.sa.bigpond.net.au. [58.160.155.134]) by mx.google.com with ESMTPSA id or7sm7281817pdb.9.2015.06.15.02.03.37 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 15 Jun 2015 02:03:38 -0700 (PDT) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 34F35EA006C; Mon, 15 Jun 2015 18:33:33 +0930 (ACST) Date: Mon, 15 Jun 2015 18:33:33 +0930 From: Alan Modra To: Andreas Schwab Cc: gcc-patches@gcc.gnu.org, David Edelsohn Subject: Re: [Patch 0/4] PowerPC64 Linux split stack support Message-ID: <20150615090333.GF1723@bubble.grove.modra.org> Mail-Followup-To: Andreas Schwab , gcc-patches@gcc.gnu.org, David Edelsohn References: <20150518025234.GT6140@bubble.grove.modra.org> <87h9qbophh.fsf@igel.home> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87h9qbophh.fsf@igel.home> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes On Sat, Jun 13, 2015 at 12:46:18PM +0200, Andreas Schwab wrote: > /usr/bin/mkdir -p .; files=`echo ../../../../libgo/go/errors/errors.go | sed -e 's/[^ ]*\.gox//g'`; /bin/sh ./libtool --tag GO --mode=compile /daten/gcc/gcc-20150613/Build/./gcc/gccgo -B/daten/gcc/gcc-20150613/Build/./gcc/ -B/usr/powerpc64-linux/bin/ -B/usr/powerpc64-linux/lib/ -isystem /usr/powerpc64-linux/include -isystem /usr/powerpc64-linux/sys-include -m32 -O2 -g -I . -c -fgo-pkgpath=`echo errors.lo | sed -e 's/.lo$//' -e 's/-go$//'` -o errors.lo $files > libtool: compile: /daten/gcc/gcc-20150613/Build/./gcc/gccgo -B/daten/gcc/gcc-20150613/Build/./gcc/ -B/usr/powerpc64-linux/bin/ -B/usr/powerpc64-linux/lib/ -isystem /usr/powerpc64-linux/include -isystem /usr/powerpc64-linux/sys-include -m32 -O2 -g -I . -c -fgo-pkgpath=errors ../../../../libgo/go/errors/errors.go > go1: error: ‘-fsplit-stack’ currently only supported on PowerPC64 GNU/Linux with glibc-2.18 or later > go1: error: ‘-fsplit-stack’ is not supported by this compiler configuration > make[2]: *** [errors.lo] Error 1 > make[2]: Leaving directory `/daten/gcc/gcc-20150613/Build/powerpc64-linux/32/libgo' > make[1]: *** [all-recursive] Error 1 This untested patch ought to fix the problem, I think. My BE test environment had gold installed but not a sufficietly recent glibc. The LE test environment of course didn't build any 32-bit multilibs. Oops. * configure.ac (libgo_cv_c_split_stack_supported): Unset for powerpc. * configure: Regenerate. diff --git a/libgo/configure.ac b/libgo/configure.ac index 7c403a5..2ddcdfd 100644 --- a/libgo/configure.ac +++ b/libgo/configure.ac @@ -366,6 +366,13 @@ esac AC_SUBST(OSCFLAGS) dnl Use -fsplit-stack when compiling C code if available. +case "$target" in + powerpc*-*-*) + # Don't use cached value. Support is available only for 64-bit, + # so the result from a 64-bit multilib is not valid for 32-bit. + unset libgo_cv_c_split_stack_supported + ;; +esac AC_CACHE_CHECK([whether -fsplit-stack is supported], [libgo_cv_c_split_stack_supported], [CFLAGS_hold=$CFLAGS