Message ID | 20150615090333.GF1723@bubble.grove.modra.org |
---|---|
State | New |
Headers | show |
Alan Modra <amodra@gmail.com> writes: > diff --git a/libgo/configure.ac b/libgo/configure.ac > index 7c403a5..2ddcdfd 100644 > --- a/libgo/configure.ac > +++ b/libgo/configure.ac > @@ -366,6 +366,13 @@ esac > AC_SUBST(OSCFLAGS) > > dnl Use -fsplit-stack when compiling C code if available. > +case "$target" in > + powerpc*-*-*) > + # Don't use cached value. Support is available only for 64-bit, > + # so the result from a 64-bit multilib is not valid for 32-bit. > + unset libgo_cv_c_split_stack_supported Where does this cached value come from? There shouldn't be any sharing between multilib builds. Andreas.
Alan Modra <amodra@gmail.com> writes:
> This untested patch ought to fix the problem, I think.
There is no -fsplit-stack in the Makefile, and the configure script
has already determined the correct settings.
$ grep -e -fsplit-stack libgo/Makefile 32/libgo/Makefile
libgo/Makefile:SPLIT_STACK = -fsplit-stack
$ grep split_stack libgo/config.log 32/libgo/config.log
libgo/config.log:libgo_cv_c_linker_supports_split_stack=no
libgo/config.log:libgo_cv_c_split_stack_supported=yes
32/libgo/config.log:libgo_cv_c_linker_supports_split_stack=no
32/libgo/config.log:libgo_cv_c_split_stack_supported=no
Andreas.
The bug is of course that like DEFAULT_ABI, rs6000_isa_flags hasn't been determined yet. Andreas.
diff --git a/libgo/configure.ac b/libgo/configure.ac index 7c403a5..2ddcdfd 100644 --- a/libgo/configure.ac +++ b/libgo/configure.ac @@ -366,6 +366,13 @@ esac AC_SUBST(OSCFLAGS) dnl Use -fsplit-stack when compiling C code if available. +case "$target" in + powerpc*-*-*) + # Don't use cached value. Support is available only for 64-bit, + # so the result from a 64-bit multilib is not valid for 32-bit. + unset libgo_cv_c_split_stack_supported + ;; +esac AC_CACHE_CHECK([whether -fsplit-stack is supported], [libgo_cv_c_split_stack_supported], [CFLAGS_hold=$CFLAGS