From patchwork Fri May 22 07:52:35 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Krebbel X-Patchwork-Id: 475312 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id EECE61402D7 for ; Fri, 22 May 2015 17:53:12 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=LBO9qyeT; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:subject:message-id:references:mime-version:content-type :in-reply-to; q=dns; s=default; b=Urgvi+u/3KTxrsd2I4rgMJrifz8Nxb MqFOGWQ6sYddnCNrVkesIvBSVCVma+4d00DzZgGCh16ASGMs0sdBnaQbHRdPfsMS i+LLcjTx6pBTvoV1bF6aXS0It4ULle6dgpv7YIGRHd+QZa8/q+dvuB1ShFSJ4gU3 vyRNdZ3mQi6A0= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:subject:message-id:references:mime-version:content-type :in-reply-to; s=default; bh=VkNUig/ONg+wHRR9flw2C1X77/0=; b=LBO9 qyeTh4bi4XsMCf8DzpDqYmEzDpO5n5Q+fUsv0NubGOPq4zW3vTWJWE0J/lTj0peM qZMFN5MwPvqN3GySlsUPYqWmfqjWbH+ed9vEife7plQCW/xmmYceumYwttmFerZ4 YvQ031GkPfZxn5jf4fl+fyBCtzs9YWYTVIEOB4A= Received: (qmail 122920 invoked by alias); 22 May 2015 07:52:44 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 122867 invoked by uid 89); 22 May 2015 07:52:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL, BAYES_00, KAM_LAZY_DOMAIN_SECURITY, T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: e06smtp12.uk.ibm.com Received: from e06smtp12.uk.ibm.com (HELO e06smtp12.uk.ibm.com) (195.75.94.108) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Fri, 22 May 2015 07:52:42 +0000 Received: from /spool/local by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 22 May 2015 08:52:38 +0100 Received: from d06dlp01.portsmouth.uk.ibm.com (9.149.20.13) by e06smtp12.uk.ibm.com (192.168.101.142) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Fri, 22 May 2015 08:52:37 +0100 Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id A941417D805A for ; Fri, 22 May 2015 08:53:29 +0100 (BST) Received: from d06av09.portsmouth.uk.ibm.com (d06av09.portsmouth.uk.ibm.com [9.149.37.250]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t4M7qasY15532166 for ; Fri, 22 May 2015 07:52:36 GMT Received: from d06av09.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av09.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t4M7qa41006207 for ; Fri, 22 May 2015 01:52:36 -0600 Received: from bart (icon-9-164-171-240.megacenter.de.ibm.com [9.164.171.240]) by d06av09.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with SMTP id t4M7qZWo006132 for ; Fri, 22 May 2015 01:52:35 -0600 Received: by bart (sSMTP sendmail emulation); Fri, 22 May 2015 09:52:35 +0200 Date: Fri, 22 May 2015 09:52:35 +0200 From: Andreas Krebbel To: gcc-patches@gcc.gnu.org Subject: Re: [PATCH 02/13] optabs: Fix vec_perm -> V16QI middle end lowering. Message-ID: <20150522075235.GA17009@maggie> References: <1431350621-21405-1-git-send-email-krebbel@linux.vnet.ibm.com> <1431350621-21405-3-git-send-email-krebbel@linux.vnet.ibm.com> <555A22E8.20307@redhat.com> <555AF724.5000901@linux.vnet.ibm.com> <555B4D3D.2070001@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <555B4D3D.2070001@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15052207-0009-0000-0000-0000043AE6F4 X-IsSubscribed: yes On Tue, May 19, 2015 at 07:48:29AM -0700, Richard Henderson wrote: > > Ok to apply with that change? > > Yes, thanks. I've applied the following. Bye, -Andreas- gcc/ * optabs.c (expand_vec_perm): Don't re-use SEL as target operand. --- gcc/optabs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gcc/optabs.c b/gcc/optabs.c index bd03fc1..bc19029 100644 --- a/gcc/optabs.c +++ b/gcc/optabs.c @@ -6796,11 +6796,11 @@ expand_vec_perm (machine_mode mode, rtx v0, rtx v1, rtx sel, rtx target) machine_mode selmode = GET_MODE (sel); if (u == 2) sel = expand_simple_binop (selmode, PLUS, sel, sel, - sel, 0, OPTAB_DIRECT); + NULL, 0, OPTAB_DIRECT); else sel = expand_simple_binop (selmode, ASHIFT, sel, GEN_INT (exact_log2 (u)), - sel, 0, OPTAB_DIRECT); + NULL, 0, OPTAB_DIRECT); gcc_assert (sel != NULL); /* Broadcast the low byte each element into each of its bytes. */