From patchwork Tue Apr 28 12:36:20 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Wakely X-Patchwork-Id: 465541 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 1E9851400B7 for ; Tue, 28 Apr 2015 22:36:32 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass reason="1024-bit key; unprotected key" header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=ruAIeIAc; dkim-adsp=none (unprotected policy); dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:subject:message-id:mime-version:content-type; q=dns; s= default; b=hAOgZ9AGeFOY/wTGact5bPm1Uu8H/I4AVMoCwveAYiDHpD6uSpUFv CUUdplBYAlfvC2xZ++LUnnRk3AYvcmzSFekiZTP52CIRtbOCC0K7CiLAgRoLfbd+ Y0K2A14ORs31B79VgKA6MpyWKjr9I+Ur5BuHADmmc77pg60hK+bERw= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:subject:message-id:mime-version:content-type; s= default; bh=M/N/BwNHuDez16F34qzLhtQB/Vk=; b=ruAIeIAcjCn9veENK4Jf iOmDv4JOBCPEM7i9k53Q6/a1vpoUfdX9L2Q+/h7rFNDMKL/mQ63bkj/PyV6hWZVw XPHJGdqusvWjnw/qq5eUOOlcvcQAUbmBT7Eqw/Cm/yuoJpa3oyMi2i5nSoiRpnK9 WvXuv8Fc0p0FPefcAoEdfWM= Received: (qmail 2366 invoked by alias); 28 Apr 2015 12:36:24 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 2346 invoked by uid 89); 28 Apr 2015 12:36:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL, BAYES_00, SPF_HELO_PASS, SPF_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 28 Apr 2015 12:36:22 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 6AE65A0E69; Tue, 28 Apr 2015 12:36:21 +0000 (UTC) Received: from localhost (ovpn-116-62.ams2.redhat.com [10.36.116.62]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t3SCaK1C008749; Tue, 28 Apr 2015 08:36:21 -0400 Date: Tue, 28 Apr 2015 13:36:20 +0100 From: Jonathan Wakely To: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: [patch] libstdc++/65631 make std::seed_seq noncopyable Message-ID: <20150428123620.GW3618@redhat.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) Tested ppc64le-linux, committed to trunk. commit 8009da43b7be1a10335240b7b2f4e27250d5376f Author: Jonathan Wakely Date: Mon Mar 30 19:22:52 2015 +0100 PR libstdc++/65631 * include/bits/random.h (seed_seq) Define copy constructor and copy assignment as deleted. * testsuite/26_numerics/random/seed_seq/cons/65631.cc: New. diff --git a/libstdc++-v3/include/bits/random.h b/libstdc++-v3/include/bits/random.h index 8caade5..501243d 100644 --- a/libstdc++-v3/include/bits/random.h +++ b/libstdc++-v3/include/bits/random.h @@ -6053,6 +6053,10 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION param(OutputIterator __dest) const { std::copy(_M_v.begin(), _M_v.end(), __dest); } + // no copy functions + seed_seq(const seed_seq&) = delete; + seed_seq& operator=(const seed_seq&) = delete; + private: /// std::vector _M_v; diff --git a/libstdc++-v3/testsuite/26_numerics/random/seed_seq/cons/65631.cc b/libstdc++-v3/testsuite/26_numerics/random/seed_seq/cons/65631.cc new file mode 100644 index 0000000..cdc4e57 --- /dev/null +++ b/libstdc++-v3/testsuite/26_numerics/random/seed_seq/cons/65631.cc @@ -0,0 +1,28 @@ +// Copyright (C) 2015 Free Software Foundation, Inc. +// +// This file is part of the GNU ISO C++ Library. This library is free +// software; you can redistribute it and/or modify it under the +// terms of the GNU General Public License as published by the +// Free Software Foundation; either version 3, or (at your option) +// any later version. + +// This library is distributed in the hope that it will be useful, +// but WITHOUT ANY WARRANTY; without even the implied warranty of +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +// GNU General Public License for more details. + +// You should have received a copy of the GNU General Public License along +// with this library; see the file COPYING3. If not see +// . + +// { dg-options "-std=gnu++11" } +// { dg-do compile } + +#include +#include + +static_assert( !std::is_copy_constructible::value, + "seed_seq is not copy constructible" ); + +static_assert( !std::is_copy_assignable::value, + "seed_seq is not copy assignable" );