From patchwork Thu Mar 12 08:58:21 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ilya Enkovich X-Patchwork-Id: 449417 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id C22291400F1 for ; Thu, 12 Mar 2015 23:17:46 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass reason="1024-bit key; unprotected key" header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=SjJhBkNc; dkim-adsp=none (unprotected policy); dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; q=dns; s=default; b=tzNHOqBgpXQcaogza 2qyzkl3tBv+f4s5iej84OU2d4CCcuzcQ6nCmA4uqzSQKJ4A6ON9h0QYRa+WY98q5 R7OqzINL7fdAqkyPIfS47+ng1aUQUGJRAi9yY6D0/b5xHySdntRDTbK5GW0nZPJz c7CYBdzTPi2H8LI773KG7JMgEg= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=default; bh=xecLTS2cLnrrcd820VDUACv KyPw=; b=SjJhBkNcVmO5xj9lBhAPJnpBgjAMxaoCGNPi0RCG/AeVAxH8V1XYwfD nhc+eXuvBsYd9FPmlLiQP6MoIY9JwKrNw8L0maW/H5s0QLnf2AlgvmffXV6M1VTF rnwNUpvDLo2T535ZY77NjdcY1i+pAkQj6xmjIC/z6rM//VzCc8DE= Received: (qmail 7297 invoked by alias); 12 Mar 2015 12:17:14 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 7215 invoked by uid 89); 12 Mar 2015 12:17:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: Yes, score=5.4 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, KAM_FROM_URIBL_PCCC, SPF_PASS, T_RP_MATCHES_RCVD, URIBL_BLACK autolearn=no version=3.3.2 X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 12 Mar 2015 12:17:10 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YVywt-000482-GQ for gcc-patches@gcc.gnu.org; Thu, 12 Mar 2015 04:58:36 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:52508) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVywt-00047y-E1 for gcc-patches@gcc.gnu.org; Thu, 12 Mar 2015 04:58:35 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36717) by fencepost.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1YVywt-0002l5-6W for gcc-patches@gnu.org; Thu, 12 Mar 2015 04:58:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YVywq-00047I-65 for gcc-patches@gnu.org; Thu, 12 Mar 2015 04:58:35 -0400 Received: from mail-ie0-x230.google.com ([2607:f8b0:4001:c03::230]:33505) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVywp-000478-Va for gcc-patches@gnu.org; Thu, 12 Mar 2015 04:58:32 -0400 Received: by iecvj10 with SMTP id vj10so26256997iec.0 for ; Thu, 12 Mar 2015 01:58:30 -0700 (PDT) X-Received: by 10.107.137.135 with SMTP id t7mr34622532ioi.3.1426150709511; Thu, 12 Mar 2015 01:58:29 -0700 (PDT) Received: from msticlxl57.ims.intel.com (fmdmzpr02-ext.fm.intel.com. [192.55.55.37]) by mx.google.com with ESMTPSA id k9sm4099370ige.6.2015.03.12.01.58.27 (version=TLSv1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 12 Mar 2015 01:58:29 -0700 (PDT) Date: Thu, 12 Mar 2015 11:58:21 +0300 From: Ilya Enkovich To: "H.J. Lu" Cc: Matthias Klose , "gcc-patches@gnu.org" Subject: Re: [patch] disable libmpx x32 multilib builds Message-ID: <20150312085821.GI27860@msticlxl57.ims.intel.com> References: <55005344.3000500@ubuntu.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes On 11 Mar 19:11, Ilya Enkovich wrote: > 2015-03-11 18:59 GMT+03:00 H.J. Lu : > > On Wed, Mar 11, 2015 at 7:37 AM, Matthias Klose wrote: > >> current trunk fails to build on x86*-linux, when configured for x32 multilibs > >> because libmpx doesn't support these. Disable them. > >> > >> ok for the trunk? > >> > >> * Disable libmpx x32 multilib builds. > >> > >> --- a/config-ml.in > >> +++ b/config-ml.in > >> @@ -102,6 +102,7 @@ > >> Makefile=${ac_file-Makefile} > >> ml_config_shell=${CONFIG_SHELL-/bin/sh} > >> ml_realsrcdir=${srcdir} > >> +ml_srcbase=`basename $ml_realsrcdir` > >> > >> # Scan all the arguments and set all the ones we need. > >> > >> @@ -220,6 +221,10 @@ > >> if [ "${dir}" = "." ]; then > >> true > >> else > >> + # libmpx is not supported on x32 > >> + if [ "${ml_srcbase}-${dir}" = libmpx-x32 ]; then > >> + continue > >> + fi > >> if [ -z "${multidirs}" ]; then > >> multidirs="${dir}" > >> else > > > > This is incorrect. Ilya and I are working on a proper fix. > > > > -- > > H.J. > > Current libmpx configure has a check for x32 but it doesn't work due > to square brackets removed from the test by autoconf. Will test this > patch: > > diff --git a/libmpx/configure.ac b/libmpx/configure.ac > index 4669525..fe0d3f2 100644 > --- a/libmpx/configure.ac > +++ b/libmpx/configure.ac > @@ -28,7 +28,7 @@ GCC_LIBSTDCXX_RAW_CXX_FLAGS > # See if supported. > unset LIBMPX_SUPPORTED > AC_MSG_CHECKING([for target support for Intel MPX runtime library]) > -echo "int i[sizeof (void *) == 4 ? 1 : -1] = { __x86_64__ };" > conftest.c > +echo "int i[[sizeof (void *) == 4 ? 1 : -1]] = { __x86_64__ };" > conftest.c > if AC_TRY_COMMAND([${CC} ${CFLAGS} -c -o conftest.o conftest.c > 1>&AS_MESSAGE_LOG_FD]) > then > LIBMPX_SUPPORTED=no > > > Thanks, > Ilya Successfully bootstrapped on on x86_64-unknown-linux-gnu with '--enable-libmpx --with-multilib-list=m32,m64,mx32'. Applied to trunk. Thanks, Ilya --- 2015-03-12 Ilya Enkovich PR other/65384 * configure.ac: Fix x32 test. * configure: Regenerate. diff --git a/libmpx/configure.ac b/libmpx/configure.ac index 4669525..fe0d3f2 100644 --- a/libmpx/configure.ac +++ b/libmpx/configure.ac @@ -28,7 +28,7 @@ GCC_LIBSTDCXX_RAW_CXX_FLAGS # See if supported. unset LIBMPX_SUPPORTED AC_MSG_CHECKING([for target support for Intel MPX runtime library]) -echo "int i[sizeof (void *) == 4 ? 1 : -1] = { __x86_64__ };" > conftest.c +echo "int i[[sizeof (void *) == 4 ? 1 : -1]] = { __x86_64__ };" > conftest.c if AC_TRY_COMMAND([${CC} ${CFLAGS} -c -o conftest.o conftest.c 1>&AS_MESSAGE_LOG_FD]) then LIBMPX_SUPPORTED=no