From patchwork Wed Feb 25 19:18:43 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian Pop X-Patchwork-Id: 443621 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 45B261400B6 for ; Thu, 26 Feb 2015 06:19:11 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass reason="1024-bit key; unprotected key" header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=AbktuxJ1; dkim-adsp=none (unprotected policy); dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; q=dns; s=default; b=YVFK0ZJ4Wlhz2dUpX ggtHbynZewosH+vGYW241cPEN8agKz1IQE4uri5tq8NZhjWf7M3u0BgdByN9w39Q RBkcuKSFZQcvnzM9SmW9vewt/ZTZtcXdsqMe2B7xo2LoE/lgo1CcYq7vT/e6zvpp nUaa/jUV4NDrzebdnL7bHPaVu4= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=default; bh=zC4D6ZSk9m8Utgw/CzQZzN2 47iw=; b=AbktuxJ1n9avG2SGxdyKFWxbELw+bIR2KjZb9AIU+E6To9ru73WfUqa ska9mpiAGmfGYpqeg+MkKbIga/4ecTI0ydAgT8AvBwmjxpKJiMFMJ9HiYwY+7J8D m8h25kpxlOogKux6J6GOwZQrjHEXR0jH8mrZ8v76lN26tsy3fPJo= Received: (qmail 107192 invoked by alias); 25 Feb 2015 19:18:49 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 107124 invoked by uid 89); 25 Feb 2015 19:18:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.1 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, KAM_FROM_URIBL_PCCC, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=no version=3.3.2 X-HELO: mail-ie0-f173.google.com Received: from mail-ie0-f173.google.com (HELO mail-ie0-f173.google.com) (209.85.223.173) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 25 Feb 2015 19:18:48 +0000 Received: by iecvy18 with SMTP id vy18so7757623iec.6 for ; Wed, 25 Feb 2015 11:18:45 -0800 (PST) X-Received: by 10.50.66.243 with SMTP id i19mr29602551igt.7.1424891925590; Wed, 25 Feb 2015 11:18:45 -0800 (PST) Received: from f1.c.bardezibar.internal (81.37.148.146.bc.googleusercontent.com. [146.148.37.81]) by mx.google.com with ESMTPSA id qs3sm10240364igb.8.2015.02.25.11.18.44 (version=SSLv3 cipher=RC4-SHA bits=128/128); Wed, 25 Feb 2015 11:18:44 -0800 (PST) Date: Wed, 25 Feb 2015 19:18:43 +0000 From: Sebastian Pop To: Jeff Law Cc: "Brian M. Rzycki" , gcc-patches@gcc.gnu.org Subject: Re: [patch] fix PR65048: check that jump-thread paths are still valid Message-ID: <20150225191843.GA13649@f1.c.bardezibar.internal> References: <20150213235033.GA20179@f1.c.bardezibar.internal> <54E2E67D.7030109@redhat.com> <20150218222723.GA24606@f1.c.bardezibar.internal> <54EBB147.2080400@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <54EBB147.2080400@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Jeff Law wrote: > On 02/18/15 15:27, Sebastian Pop wrote: > >>The dumps for the FSM threads are a bit sparse -- they don't show > >>the entire path. That makes it much harder to see what's going on. > > > >Would a patch improving the FSM dumps ok to commit separately to trunk? > Most definitely. I realize we're in stage4, but I'd approve such a change. Attached: * tree-ssa-threadupdate.c (dump_jump_thread_path): Print all edges of an EDGE_FSM_THREAD. I'm regstrapping on x86_64-linux. Ok for trunk if it passes? Thanks, Sebastian From df583e5d511db2ed87c14cd5290f382c139636d9 Mon Sep 17 00:00:00 2001 From: Sebastian Pop Date: Wed, 25 Feb 2015 20:12:33 +0100 Subject: [PATCH] improve FSM jump thread dump --- gcc/tree-ssa-threadupdate.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/gcc/tree-ssa-threadupdate.c b/gcc/tree-ssa-threadupdate.c index 7a41ab2..7a159bb 100644 --- a/gcc/tree-ssa-threadupdate.c +++ b/gcc/tree-ssa-threadupdate.c @@ -197,6 +197,9 @@ dump_jump_thread_path (FILE *dump_file, vec path, if (path[i]->type == EDGE_NO_COPY_SRC_BLOCK) fprintf (dump_file, " (%d, %d) nocopy;", path[i]->e->src->index, path[i]->e->dest->index); + if (path[0]->type == EDGE_FSM_THREAD) + fprintf (dump_file, " (%d, %d) ", + path[i]->e->src->index, path[i]->e->dest->index); } fputc ('\n', dump_file); } -- 1.7.2.5