From patchwork Wed Feb 25 13:35:53 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ilya Enkovich X-Patchwork-Id: 443385 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 0DA90140082 for ; Thu, 26 Feb 2015 00:36:15 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass reason="1024-bit key; unprotected key" header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=lwoK5pqU; dkim-adsp=none (unprotected policy); dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:subject:message-id:mime-version:content-type; q=dns; s= default; b=k0vjfXItYiSGJMI1l46p40kpDk225vX/kP7ZNTB/TsPLeypu1J4r1 OrQ8cseAX4x0wIZTHMoIT3a6au+tA3xydaa9X6TVAUdeFByuxjICqETbfC580lCx p/UfQYZmzYJObVX7WK0sA3fiokO62+mmVeHgomkbmnXn12VnPhHLfI= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:subject:message-id:mime-version:content-type; s= default; bh=xUD6xLCuESUI6gMJ15cWm1HTmUc=; b=lwoK5pqU+r8Y0r9r1CPB 8C/n0vd5VDl0UPxiCWsxMdmnY9msoVVwKElkzUpMkRJENejbpOezyVTaPMkmVNfQ J3rN9f9FDqV5nMaPhMBsu5354Ifn3OXwOjIsGlg+AktgKVm3/A/abmxOV3yRVEl2 qhELUz/LySDxa2q5Q5FLZeo= Received: (qmail 124441 invoked by alias); 25 Feb 2015 13:36:08 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 124425 invoked by uid 89); 25 Feb 2015 13:36:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.6 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, KAM_FROM_URIBL_PCCC, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=no version=3.3.2 X-HELO: mail-wi0-f180.google.com Received: from mail-wi0-f180.google.com (HELO mail-wi0-f180.google.com) (209.85.212.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 25 Feb 2015 13:36:06 +0000 Received: by mail-wi0-f180.google.com with SMTP id h11so5085844wiw.1 for ; Wed, 25 Feb 2015 05:36:03 -0800 (PST) X-Received: by 10.180.108.13 with SMTP id hg13mr6412972wib.7.1424871363595; Wed, 25 Feb 2015 05:36:03 -0800 (PST) Received: from msticlxl57.ims.intel.com ([192.55.55.41]) by mx.google.com with ESMTPSA id dj5sm64883094wjb.28.2015.02.25.05.36.01 for (version=TLSv1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 25 Feb 2015 05:36:02 -0800 (PST) Date: Wed, 25 Feb 2015 16:35:53 +0300 From: Ilya Enkovich To: gcc-patches@gcc.gnu.org Subject: [PATCH, CHKP, i386, PR target/65167] Avoid motion of bounds args during scheduling Message-ID: <20150225133553.GB65329@msticlxl57.ims.intel.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Hi, This patch adds support for bounds registers into args recognition mechanism used by scheduler. Bootstrapped and tested on x86_64-unknown-linux-gnu. OK for trunk? Thanks, Ilya --- gcc/ 2015-02-25 Ilya Enkovich PR target/65167 * gcc/config/i386/i386.c (ix86_function_arg_regno_p): Support bounds registers. (avoid_func_arg_motion): Add dependencies for BNDSTX insns. gcc/testsuite/ 2015-02-25 Ilya Enkovich PR target/65167 * gcc.target/i386/pr65167.c: New. diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c index 71a5b22..acbe25f 100644 --- a/gcc/config/i386/i386.c +++ b/gcc/config/i386/i386.c @@ -6068,6 +6068,9 @@ ix86_function_arg_regno_p (int regno) int i; const int *parm_regs; + if (TARGET_MPX && BND_REGNO_P (regno)) + return true; + if (!TARGET_64BIT) { if (TARGET_MACHO) @@ -26846,6 +26849,16 @@ avoid_func_arg_motion (rtx_insn *first_arg, rtx_insn *insn) rtx set; rtx tmp; + /* Add anti dependencies for bounds stores. */ + if (INSN_P (insn) + && GET_CODE (PATTERN (insn)) == PARALLEL + && GET_CODE (XVECEXP (PATTERN (insn), 0, 0)) == UNSPEC + && XINT (XVECEXP (PATTERN (insn), 0, 0), 1) == UNSPEC_BNDSTX) + { + add_dependence (first_arg, insn, REG_DEP_ANTI); + return; + } + set = single_set (insn); if (!set) return; diff --git a/gcc/testsuite/gcc.target/i386/pr65167.c b/gcc/testsuite/gcc.target/i386/pr65167.c new file mode 100644 index 0000000..35f3d6b --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/pr65167.c @@ -0,0 +1,11 @@ +/* { dg-do compile } */ +/* { dg-require-effective-target mpx } */ +/* { dg-options "-O -fschedule-insns -fcheck-pointer-bounds -mmpx" } */ + +void bar(int *a, int *b, int *c, int *d, int *e, int *f); + +int foo (int *a, int *b, int *c, int *d, int *e, int *f) +{ + bar (a, b, c, d, e, f); + return *f; +}