From patchwork Tue Jan 27 15:42:52 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Krebbel X-Patchwork-Id: 433558 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id DBD6214019D for ; Wed, 28 Jan 2015 02:43:21 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:subject:message-id:mime-version:content-type; q=dns; s= default; b=Ok65jK309ZCGdkV+oq51nM9RPZxjno8HcUz/z2kPvwyzz78bSXZgE 0NxCiRJTxceVh8ze0j6tRFukHj4421aYBIBWcC72K189T3zhjx6x/jQwU4d2WWgi xrvuW/nUTqf6zPp7BqlwzWhQQe3NpZQFIKKdcGj6NwjyhBeQP1TUvM= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:subject:message-id:mime-version:content-type; s= default; bh=MetqEC2OAo8zdpYKk3/unKFx/zs=; b=X9OHWllUjyRXJl85fIqS GpDG77hptA2iotwAThgEvDJOyXmXFwub//uiztg5w2+GDvRZ+n4jHiXzI5I9IQ43 GNkFhxf+eePMBhIQyD5h7hg8KbsMS4voBvLe3kMSNCbwJwLekYe+0uE+xBms1lE4 E3tvJpLRVc2Ny0j+lsvREqo= Received: (qmail 3984 invoked by alias); 27 Jan 2015 15:43:06 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 3923 invoked by uid 89); 27 Jan 2015 15:43:03 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: e06smtp10.uk.ibm.com Received: from e06smtp10.uk.ibm.com (HELO e06smtp10.uk.ibm.com) (195.75.94.106) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 27 Jan 2015 15:43:02 +0000 Received: from /spool/local by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 27 Jan 2015 15:42:58 -0000 Received: from d06dlp01.portsmouth.uk.ibm.com (9.149.20.13) by e06smtp10.uk.ibm.com (192.168.101.140) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 27 Jan 2015 15:42:55 -0000 Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id EA5A017D805A for ; Tue, 27 Jan 2015 15:42:59 +0000 (GMT) Received: from d06av09.portsmouth.uk.ibm.com (d06av09.portsmouth.uk.ibm.com [9.149.37.250]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t0RFgtwC3473862 for ; Tue, 27 Jan 2015 15:42:55 GMT Received: from d06av09.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av09.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t0RFgsj2025341 for ; Tue, 27 Jan 2015 08:42:54 -0700 Received: from bart (dyn-9-152-212-92.boeblingen.de.ibm.com [9.152.212.92]) by d06av09.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with SMTP id t0RFgreK025293 for ; Tue, 27 Jan 2015 08:42:53 -0700 Received: by bart (sSMTP sendmail emulation); Tue, 27 Jan 2015 16:42:52 +0100 Date: Tue, 27 Jan 2015 16:42:52 +0100 From: Andreas Krebbel To: gcc-patches@gcc.gnu.org Subject: [Committed] S/390: Increase register move costs for FPR->GPR moves Message-ID: <20150127154252.GA21000@maggie> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15012715-0041-0000-0000-0000030B1ACA X-IsSubscribed: yes Hi, I've committed the attached patch which fixes a 4.8 vs 4.9/5.0 performance regression introduced with the aggressive use of FPRs as spill slots. Committed to mainline and 4.9 branch. Bye, -Andreas- 2015-01-27 Andreas Krebbel * config/s390/s390.c (s390_register_move_cost): Increase costs for FPR->GPR moves. diff --git a/gcc/config/s390/s390.c b/gcc/config/s390/s390.c index 36b547d..fcde638 100644 --- a/gcc/config/s390/s390.c +++ b/gcc/config/s390/s390.c @@ -2393,16 +2393,29 @@ s390_float_const_zero_p (rtx value) /* Implement TARGET_REGISTER_MOVE_COST. */ static int -s390_register_move_cost (machine_mode mode ATTRIBUTE_UNUSED, +s390_register_move_cost (machine_mode mode, reg_class_t from, reg_class_t to) { - /* On s390, copy between fprs and gprs is expensive as long as no - ldgr/lgdr can be used. */ - if ((!TARGET_Z10 || GET_MODE_SIZE (mode) != 8) - && ((reg_classes_intersect_p (from, GENERAL_REGS) - && reg_classes_intersect_p (to, FP_REGS)) - || (reg_classes_intersect_p (from, FP_REGS) - && reg_classes_intersect_p (to, GENERAL_REGS)))) + /* On s390, copy between fprs and gprs is expensive. */ + + /* It becomes somewhat faster having ldgr/lgdr. */ + if (TARGET_Z10 && GET_MODE_SIZE (mode) == 8) + { + /* ldgr is single cycle. */ + if (reg_classes_intersect_p (from, GENERAL_REGS) + && reg_classes_intersect_p (to, FP_REGS)) + return 1; + /* lgdr needs 3 cycles. */ + if (reg_classes_intersect_p (to, GENERAL_REGS) + && reg_classes_intersect_p (from, FP_REGS)) + return 3; + } + + /* Otherwise copying is done via memory. */ + if ((reg_classes_intersect_p (from, GENERAL_REGS) + && reg_classes_intersect_p (to, FP_REGS)) + || (reg_classes_intersect_p (from, FP_REGS) + && reg_classes_intersect_p (to, GENERAL_REGS))) return 10; return 1;