From patchwork Tue Jan 13 21:27:58 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 428708 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id B289014021A for ; Wed, 14 Jan 2015 08:28:09 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:reply-to:mime-version :content-type; q=dns; s=default; b=RFUcJbR+12Fjp7Nmz9VPfx7wWVFEJ E80p0ffcacWVdLNr5NUiC7dBWazL6Sn1bUTxuZijXyv8p/k6NRPswnciC14KQxCJ AqU7xchLDe7qPUsi4LXh0PYQlqISqzU7MP0Q0jPGH+QyI0uCoEAmkrgUBpC80BJc BiEQN6TFHU5Qc0= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:reply-to:mime-version :content-type; s=default; bh=dWTsJYoTREAV5DRPZSb+Jz+fy5M=; b=NLd VtFYvWIFKwmcHAKCDghXAksIKc25u7FbkXO8hUsVGb8NUvSawwNgmibQKT3QlLKR KMwrdlXWGK/05p+IU3nhK+hVeUWk5oXT7/u9S0cuF5Wxdjvevqx5NYTUw1eDskjv 43DIsc9+GcbS25B8FogcI3enSxhbF4lPj56dYPFk= Received: (qmail 22250 invoked by alias); 13 Jan 2015 21:28:02 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 21685 invoked by uid 89); 13 Jan 2015 21:28:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL, BAYES_00, NO_DNS_FOR_FROM, T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mga11.intel.com Received: from mga11.intel.com (HELO mga11.intel.com) (192.55.52.93) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 13 Jan 2015 21:28:00 +0000 Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP; 13 Jan 2015 13:27:59 -0800 X-ExtLoop1: 1 Received: from gnu-mic-2.sc.intel.com ([172.25.70.156]) by FMSMGA003.fm.intel.com with ESMTP; 13 Jan 2015 13:15:08 -0800 Received: by gnu-mic-2.sc.intel.com (Postfix, from userid 1000) id EB91F2401B3; Tue, 13 Jan 2015 13:27:58 -0800 (PST) Date: Tue, 13 Jan 2015 13:27:58 -0800 From: "H.J. Lu" To: gcc-patches@gcc.gnu.org, Andi Kleen Cc: Uros Bizjak Subject: [PATCH] Correct target selector in -mfentry tests Message-ID: <20150113212758.GA20469@intel.com> Reply-To: "H.J. Lu" MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) -fprofile -mfentry works with PIE if gcrt1.o is compiled with -fPIC. A glibc has been filed, PR 17836, and a glibc patch has been submitted. OK for trunk? Thanks. H.J. --- * gcc.target/i386/fentry-override.c: Properly place {} in target selector. Remove nonpic. * gcc.target/i386/fentry.c: Likewise. --- gcc/testsuite/gcc.target/i386/fentry-override.c | 2 +- gcc/testsuite/gcc.target/i386/fentry.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/gcc/testsuite/gcc.target/i386/fentry-override.c b/gcc/testsuite/gcc.target/i386/fentry-override.c index 0464454..4dd87a8 100644 --- a/gcc/testsuite/gcc.target/i386/fentry-override.c +++ b/gcc/testsuite/gcc.target/i386/fentry-override.c @@ -1,5 +1,5 @@ /* Test -mfentry override */ -/* { dg-do compile { target { *-*-linux* } && { nonpic || ! { ia32 } } } } */ +/* { dg-do compile { target { { *-*-linux* } && { ! { ia32 } } } } } */ /* { dg-options "-mfentry" } */ /* { dg-final { scan-assembler-not "__fentry__" } } */ /* Origin: Andi Kleen */ diff --git a/gcc/testsuite/gcc.target/i386/fentry.c b/gcc/testsuite/gcc.target/i386/fentry.c index d0d70c6..3548dd7 100644 --- a/gcc/testsuite/gcc.target/i386/fentry.c +++ b/gcc/testsuite/gcc.target/i386/fentry.c @@ -1,5 +1,5 @@ /* Test -mfentry */ -/* { dg-do compile { target { *-*-linux* } && { nonpic || ! { ia32 } } } } */ +/* { dg-do compile { target { { *-*-linux* } && { ! { ia32 } } } } } */ /* { dg-options "-fprofile -mfentry" } */ /* { dg-final { scan-assembler "__fentry__" } } */ /* Origin: Andi Kleen */