From patchwork Mon Nov 17 16:17:34 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ilya Enkovich X-Patchwork-Id: 411713 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id D51741401F1 for ; Tue, 18 Nov 2014 03:17:57 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; q=dns; s=default; b=EuGqqarry2tsvTi/3 rVtmRcOPRDLd/yP3OCxV5dsyal+iFS4i+nPwHn5WcYCG1N4VpFgXeUqjsfzgkWvB KqdqM59SORV+egVqA5Tlx1aa/GRrnOAN/WL3iU7wyvspM2Ir35SFUg0kEG2uX9Em YLXdicz6ATAqq1q58Wg3DbI4l4= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=default; bh=bmp7ONE8RjRCtfsa1tSQw6g oCZE=; b=RVt8zgh7srwDo90yEeIs8F6nctVm2ZjSl4+cPw8X/ngXgfgshmI2w/P q0t0/WBcBnWRuTxZOsO02oIxKpLdCYfJo/64Tgiq29dEl79e8Irynnm8AGMkQy2j RcxD+jML+0V/ztlVjFiETm5TBAemk/lGxkuSc3gWg/rn4c8F1yZI= Received: (qmail 28977 invoked by alias); 17 Nov 2014 16:17:49 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 28965 invoked by uid 89); 17 Nov 2014 16:17:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f43.google.com Received: from mail-pa0-f43.google.com (HELO mail-pa0-f43.google.com) (209.85.220.43) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 17 Nov 2014 16:17:43 +0000 Received: by mail-pa0-f43.google.com with SMTP id kx10so2296177pab.2 for ; Mon, 17 Nov 2014 08:17:42 -0800 (PST) X-Received: by 10.66.66.2 with SMTP id b2mr30990667pat.49.1416241061928; Mon, 17 Nov 2014 08:17:41 -0800 (PST) Received: from msticlxl57.ims.intel.com (fmdmzpr02-ext.fm.intel.com. [192.55.55.37]) by mx.google.com with ESMTPSA id w8sm6512854pbt.71.2014.11.17.08.17.39 for (version=TLSv1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 17 Nov 2014 08:17:41 -0800 (PST) Date: Mon, 17 Nov 2014 19:17:34 +0300 From: Ilya Enkovich To: Jan-Benedict Glaw Cc: Markus Trippelsdorf , gcc-patches@gcc.gnu.org Subject: Re: [BUILDROBOT] Build breakage in builtin.c (was: [PATCH, Pointer Bounds Checker, Builtins instrumentation 3/5] Expand instrumented builtin calls) Message-ID: <20141117161734.GD5422@msticlxl57.ims.intel.com> References: <20141106122459.GB44122@msticlxl57.ims.intel.com> <20141117145242.GW8445@lug-owl.de> <20141117145941.GD344@x4> <20141117151219.GX8445@lug-owl.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20141117151219.GX8445@lug-owl.de> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes On 17 Nov 16:12, Jan-Benedict Glaw wrote: > On Mon, 2014-11-17 15:59:41 +0100, Markus Trippelsdorf wrote: > > On 2014.11.17 at 15:52 +0100, Jan-Benedict Glaw wrote: > > > On Thu, 2014-11-06 15:24:59 +0300, Ilya Enkovich wrote: > [...] > > > It seems this part of the patch series causes some build breakage > > > right now, see eg. build > > > http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=376804 : > > > > > > g++ -c -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -fno-common -DHAVE_CONFIG_H -I. -I. -I/home/jbglaw/repos/gcc/gcc -I/home/jbglaw/repos/gcc/gcc/. -I/home/jbglaw/repos/gcc/gcc/../include -I/home/jbglaw/repos/gcc/gcc/../libcpp/include -I/home/jbglaw/repos/gcc/gcc/../libdecnumber -I/home/jbglaw/repos/gcc/gcc/../libdecnumber/dpd -I../libdecnumber -I/home/jbglaw/repos/gcc/gcc/../libbacktrace -o builtins.o -MT builtins.o -MMD -MP -MF ./.deps/builtins.TPo /home/jbglaw/repos/gcc/gcc/builtins.c > > > /home/jbglaw/repos/gcc/gcc/builtins.c: In function ???rtx_def* expand_builtin_memcpy_with_bounds(tree, rtx)???: > > > /home/jbglaw/repos/gcc/gcc/builtins.c:3300:25: error: ???BNDmode??? was not declared in this scope > > > rtx bnd = force_reg (BNDmode, > > > ^ > > > /home/jbglaw/repos/gcc/gcc/builtins.c: In function ???rtx_def* expand_builtin_mempcpy_with_bounds(tree, rtx, machine_mode)???: > > > /home/jbglaw/repos/gcc/gcc/builtins.c:3357:25: error: ???BNDmode??? was not declared in this scope > > > rtx bnd = force_reg (BNDmode, > > > ^ > > > /home/jbglaw/repos/gcc/gcc/builtins.c: In function ???rtx_def* expand_builtin_memset_with_bounds(tree, rtx, machine_mode)???: > > > /home/jbglaw/repos/gcc/gcc/builtins.c:3763:25: error: ???BNDmode??? was not declared in this scope > > > rtx bnd = force_reg (BNDmode, > > > ^ > > > make[1]: *** [builtins.o] Error 1 > > > make[1]: Leaving directory `/home/jbglaw/build/mips-linux/build-gcc/gcc' > > > > Also happens on ppc64 and probably on all the other non x86 > > architectures. > > I just took that single build as an example. If you look at the > timeline view (http://toolchain.lug-owl.de/buildbot/timeline.php), > you'll see that every build started after ~ 14:49 CET (= 13:49 UTC) > except a x86_64-linux build failed. (Ignore builds of gcc20, it got > some HDD issues.) > > MfG, JBG > > -- > Jan-Benedict Glaw jbglaw@lug-owl.de +49-172-7608481 > Signature of: What we do for ourselves dies with us. What we do for > the second : others and the world remains and is immortal. (Albert Pine) i386 target mode is used instead of a hook. Here is a fix. Checked it fixes ARM cross build. Committed as obvious fix. Thanks, Ilya --- 2014-11-17 Ilya Enkovich * builtins.c (expand_builtin_memcpy_with_bounds): Use target hook instead of BNDmode. (expand_builtin_mempcpy_with_bounds): Likewise. (expand_builtin_memset_with_bounds): Likewise. diff --git a/gcc/builtins.c b/gcc/builtins.c index 7ec2d5f..f48745e 100644 --- a/gcc/builtins.c +++ b/gcc/builtins.c @@ -3297,7 +3297,7 @@ expand_builtin_memcpy_with_bounds (tree exp, rtx target) /* Return src bounds with the result. */ if (res) { - rtx bnd = force_reg (BNDmode, + rtx bnd = force_reg (targetm.chkp_bound_mode (), expand_normal (CALL_EXPR_ARG (exp, 1))); res = chkp_join_splitted_slot (res, bnd); } @@ -3354,7 +3354,7 @@ expand_builtin_mempcpy_with_bounds (tree exp, rtx target, machine_mode mode) /* Return src bounds with the result. */ if (res) { - rtx bnd = force_reg (BNDmode, + rtx bnd = force_reg (targetm.chkp_bound_mode (), expand_normal (CALL_EXPR_ARG (exp, 1))); res = chkp_join_splitted_slot (res, bnd); } @@ -3760,7 +3760,7 @@ expand_builtin_memset_with_bounds (tree exp, rtx target, machine_mode mode) /* Return src bounds with the result. */ if (res) { - rtx bnd = force_reg (BNDmode, + rtx bnd = force_reg (targetm.chkp_bound_mode (), expand_normal (CALL_EXPR_ARG (exp, 1))); res = chkp_join_splitted_slot (res, bnd); }