From patchwork Fri Nov 14 16:51:38 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Wakely X-Patchwork-Id: 410911 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id B6C5C140082 for ; Sat, 15 Nov 2014 03:51:59 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; q=dns; s=default; b=s6fBUph2v2w7bqfrC Vz4IY9M0HTbCMmHC8DD8Rfi3VvhqW2RuDzCcci1sZ5J64WE2f17d97ywmG0iqFS4 gStsmLxS6hu8e87qmESb69+EDeN/acjsPiSWqstJohCxXvG06H5UAPSyiuFFiP0L jmJzYzbd7yslkeD9+MRqul7+uM= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=default; bh=sXfIo0ihVX6Mgne2HWU2hRy z/dI=; b=G3erX9cCQju3B1mWUSjI28zgaNux/TDIl1rFJwbNY2vRHaUSg83xF3p mX7jz5y+95RS5bvsEkp8pDJ2CZG+yAcNYEJVrqP5DbOIhPbu2acnaqLMm+MgR0s5 sXtYD9D/dXcc05HNCG+lW3MjAH3yA2tGgaNS6Tss70YMC7Xmzqm8= Received: (qmail 19560 invoked by alias); 14 Nov 2014 16:51:48 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 19446 invoked by uid 89); 14 Nov 2014 16:51:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL, BAYES_00, SPF_HELO_PASS, SPF_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 14 Nov 2014 16:51:45 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sAEGpdpg021804 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 14 Nov 2014 11:51:40 -0500 Received: from localhost (ovpn-116-136.ams2.redhat.com [10.36.116.136]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id sAEGpc2k032389; Fri, 14 Nov 2014 11:51:39 -0500 Date: Fri, 14 Nov 2014 16:51:38 +0000 From: Jonathan Wakely To: Christopher Jefferson Cc: libstdc++ , gcc-patches Subject: Re: [patch] New std::string implementation Message-ID: <20141114165138.GK5191@redhat.com> References: <20141114154330.GH5191@redhat.com> <20141114164214.GJ5191@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20141114164214.GJ5191@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) On 14/11/14 16:42 +0000, Jonathan Wakely wrote: >On 14/11/14 16:32 +0000, Christopher Jefferson wrote: >>I tried bootstrapping on Mac OS X 10.10, and got lots of linking >>issues, the relevant part is:: > >I might be missing some of the new instantiations, I'll look into >that. I am missing some instantiations, but that linker error is fixed by this change: Thie missing ones are due to the fact that insert/erase/replace etc. take iterator arguments in C++03 and const_iterator in C++11, so the explicit instantiations in src/c++11/string-inst.cc only generate the const_iterator form. I'm not sure whether to add explicit instantiations for the other forms, or just say the arguments are always const_iterator even in C++03 mode. --- a/libstdc++-v3/src/c++11/cow-string-inst.cc +++ b/libstdc++-v3/src/c++11/cow-string-inst.cc @@ -29,8 +29,6 @@ #define _GLIBCXX_USE_CXX11_ABI 0 #include "string-inst.cc" -#include "sstream-inst.cc" - #include #include "../c++98/istream-string.cc"