From patchwork Fri Nov 14 14:48:22 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 410861 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 7EBFE140082 for ; Sat, 15 Nov 2014 01:48:36 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; q=dns; s=default; b=Gu5XJq9HGdN7N8Czy aLly42xtTyREx9IB2gCbGUOjWW5ISwFX87VQZYDXdq515N0+oOU0ms6vbo/ixMeD LPOFYQZU/GmAk2EO/Tj48ug+V2KZGCO9gI4xxe4Xhbgvzey4NchxOSQxZwmaew3y qQEs+qMFr1Ulhw0yRty1Ln1DZ0= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=default; bh=km+aIxQcEfo4MtULBeXwAd8 88ZY=; b=tO6exPq5LoVNqj7CIG/onCGaskk7tdK8PrBqM/F3s8/+dvuWxXwIZfG ujIHLF57HSPHi+APOycQ2iny9PCKNejP/t3PJ8JULr//lRfAba6o4vo9bG046EYx GiL1mrURvKYkKr55brHWMNa7qQCe6zScZqY5TNsW9M2h0hA7+/3Y= Received: (qmail 23017 invoked by alias); 14 Nov 2014 14:48:30 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 23006 invoked by uid 89); 14 Nov 2014 14:48:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 X-HELO: mail-wi0-f171.google.com Received: from mail-wi0-f171.google.com (HELO mail-wi0-f171.google.com) (209.85.212.171) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 14 Nov 2014 14:48:28 +0000 Received: by mail-wi0-f171.google.com with SMTP id r20so2882936wiv.16 for ; Fri, 14 Nov 2014 06:48:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=g1mhm4tC4suenDQDJT0VoXdnOLmU42p3y7Od1zX4uHk=; b=TnV8ttbjdiaC+upL9YT74rknQUNFqyOBAW4YSXGM4QD5zSDrfmzaCW0jXJVNGBybNC L9TagpFo5CHDsTc4TzoRQfb4F52SH58My45/VAVbhBXeT6S3tmjSxtDFjC6Hxz6SLkxw AJY9OavGM83S0F/NqBLpMnJA3wGZFJ/Y5FCBoDSrHfEKULnlhZ2TiGck7oKepKG0W0LC NsBQfAyNoeG2jBvmvPQVzyV2aE3JPEwE8g0vDwQyDKyu1JwUPOsGbt7NF1okZNwFXHjt 2yn1pU6I66PQwRKfxK22+UF0t5TMX8dDZVail7ogzOn7+FsryNWIlJIIgxq7FC4ds8i0 zn4g== X-Gm-Message-State: ALoCoQkyfVbMocsGUK7QNPKkmfZOM2Z9N2yT3uBhyZJ0dYHUmIcz9XmxXY50y7GRobU7PI2oBvUR X-Received: by 10.194.237.162 with SMTP id vd2mr14711816wjc.52.1415976504920; Fri, 14 Nov 2014 06:48:24 -0800 (PST) Received: from localhost ([62.116.9.99]) by mx.google.com with ESMTPSA id ec2sm1820174wib.23.2014.11.14.06.48.23 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 14 Nov 2014 06:48:24 -0800 (PST) Date: Fri, 14 Nov 2014 15:48:22 +0100 From: Andrew Burgess To: Jakub Jelinek Cc: binutils@sourceware.dot.org, gcc-patches@gcc.gnu.org, Shinichiro Hamaji , Nick Clifton Subject: Re: [PATCH] DW_AT_APPLE_* DWARF extensions. Message-ID: <20141114144822.GN3565@embecosm.com> References: <20141113093527.GI3565@embecosm.com> <20141113095534.GE5026@tucnak.redhat.com> <20141113122121.GK3565@embecosm.com> <20141113131342.GP5026@tucnak.redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20141113131342.GP5026@tucnak.redhat.com> X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes * Jakub Jelinek [2014-11-13 14:13:42 +0100]: > On Thu, Nov 13, 2014 at 01:21:21PM +0100, Andrew Burgess wrote: > > I had a look around and couldn't find anything helpful. The best I > > can offer would be the current path within the llvm source code where > > these are defined. Would that be sufficient? > > That is not useful. The point is not to suggest where those constants come > from but what they mean, see e.g. the > http://www.dwarfstd.org/ShowIssue.php?issue=100909.2&type=open > http://gcc.gnu.org/wiki/TemplateParmsDwarf > etc. links that describe what the extensions do. > If LLVM doesn't have any documentation of their extensions, then just > /* Apple extensions. */ > is good enough. I agree, hence my comment about not finding anything useful :) I've look again, and still can't find anything suitable, so could we go with just "/* Apple extensions. */" then? Patch & Changelog below. Thanks, Andrew 2014-11-14 Shinichiro Hamaji * dwarf2.def (DW_AT_APPLE_optimized, DW_AT_APPLE_flags) (DW_AT_APPLE_isa, DW_AT_APPLE_block) (DW_AT_APPLE_major_runtime_vers, DW_AT_APPLE_runtime_class) (DW_AT_APPLE_omit_frame_ptr, DW_AT_APPLE_property_name) (DW_AT_APPLE_property_getter, DW_AT_APPLE_property_setter) (DW_AT_APPLE_property_attribute, DW_AT_APPLE_objc_complete_type) (DW_AT_APPLE_property): New macros. diff --git a/include/dwarf2.def b/include/dwarf2.def index 71a37b3..878c5c6 100644 --- a/include/dwarf2.def +++ b/include/dwarf2.def @@ -406,6 +406,20 @@ DW_AT (DW_AT_upc_threads_scaled, 0x3210) DW_AT (DW_AT_PGI_lbase, 0x3a00) DW_AT (DW_AT_PGI_soffset, 0x3a01) DW_AT (DW_AT_PGI_lstride, 0x3a02) +/* Apple extensions. */ +DW_AT (DW_AT_APPLE_optimized, 0x3fe1) +DW_AT (DW_AT_APPLE_flags, 0x3fe2) +DW_AT (DW_AT_APPLE_isa, 0x3fe3) +DW_AT (DW_AT_APPLE_block, 0x3fe4) +DW_AT (DW_AT_APPLE_major_runtime_vers, 0x3fe5) +DW_AT (DW_AT_APPLE_runtime_class, 0x3fe6) +DW_AT (DW_AT_APPLE_omit_frame_ptr, 0x3fe7) +DW_AT (DW_AT_APPLE_property_name, 0x3fe8) +DW_AT (DW_AT_APPLE_property_getter, 0x3fe9) +DW_AT (DW_AT_APPLE_property_setter, 0x3fea) +DW_AT (DW_AT_APPLE_property_attribute, 0x3feb) +DW_AT (DW_AT_APPLE_objc_complete_type, 0x3fec) +DW_AT (DW_AT_APPLE_property, 0x3fed) DW_END_AT DW_FIRST_OP (DW_OP_addr, 0x03)