From patchwork Thu Nov 13 12:21:21 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 410394 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id B64611400D2 for ; Thu, 13 Nov 2014 23:21:35 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; q=dns; s=default; b=v+8aaRFDmW/5URmhi 47raJiT7/OV0Ebhz3ZdLwJBDSIcH26k+NfDO8TkssEy6iECCrthqcQrQZxldcyVb sjyoREB6QeMIUwq93HGitE0CvCuTYo0pJ++EVud0FtLdC1ZE62ZiM68e71n3wJAU Ary0Xpkhu48yTrKriBtO5qRLkc= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=default; bh=lFSHx1I2nBpNK6+g9ZXmmvI +xTg=; b=rCJ5wo95zsgXpZYfWGKZHLgm1mK3Dfr80GlSpJdJBcCMA+e2SpWtofE G4uhZqT8MJIBzQlSM0yjXmdK4vWqRa4e9D+m+JdqsRjjty0QluVcW3LmqmMysxdQ ZyojHw+Ok2FbMbRjJEy4FBe1rC57IuN7lAHSaljkjZVBDBIIOGGo= Received: (qmail 11923 invoked by alias); 13 Nov 2014 12:21:28 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 11913 invoked by uid 89); 13 Nov 2014 12:21:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 X-HELO: mail-wg0-f46.google.com Received: from mail-wg0-f46.google.com (HELO mail-wg0-f46.google.com) (74.125.82.46) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 13 Nov 2014 12:21:27 +0000 Received: by mail-wg0-f46.google.com with SMTP id x13so16923989wgg.5 for ; Thu, 13 Nov 2014 04:21:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=BjMdwSisV9tWVviEPInaZkgor5lCdGiuoXpY4qIK3qw=; b=GEnL/Ow8OA5dOO9bS12O7xQP31/0TfhosVvsZJ4PrGC2WDg8W1M7r2G3Iasfk1+BDb mBg6PDtseP9np/XHLeigJg7A5cB2kFZ4+3GSCV6u4fOt7kMLCYyVk6rU4WBY3ExBWx+m 7l4aCjCH07HiobsRlAseiuxpX8MaFsfZINQc2P3weikLFHV7MBMQMMujjUVcDCO6Ck+4 UhOf4URkTQ2xU5Fx1DldmcRZVbOdtcwLOSrnMJkRtvOF2ZzkdPdPdQk+Kqz2OsZ2wojc /UQ4mVyJY4+kgC9bIMx20fcQQKuJSqLpJEKT7EigoAhxtOz9F7dMKvD2XfdSZg1zywF8 2SAw== X-Gm-Message-State: ALoCoQnTxPIbdlFuTowaq3zP5L89fo1QFNTCoLwQnMocwgbNWRgZOMfMvQOFhiUf5vMWGNQsialR X-Received: by 10.180.221.72 with SMTP id qc8mr3338501wic.19.1415881284052; Thu, 13 Nov 2014 04:21:24 -0800 (PST) Received: from localhost (TK158115.telekabel.at. [195.34.158.115]) by mx.google.com with ESMTPSA id s2sm25531549wia.3.2014.11.13.04.21.22 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Nov 2014 04:21:23 -0800 (PST) Date: Thu, 13 Nov 2014 13:21:21 +0100 From: Andrew Burgess To: Jakub Jelinek Cc: binutils@sourceware.dot.org, gcc-patches@gcc.gnu.org, Shinichiro Hamaji , Nick Clifton Subject: Re: [PATCH] DW_AT_APPLE_* DWARF extensions. Message-ID: <20141113122121.GK3565@embecosm.com> References: <20141113093527.GI3565@embecosm.com> <20141113095534.GE5026@tucnak.redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20141113095534.GE5026@tucnak.redhat.com> X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes * Jakub Jelinek [2014-11-13 10:55:34 +0100]: > On Thu, Nov 13, 2014 at 10:35:28AM +0100, Andrew Burgess wrote: > > Am I correct to think that the include/* files are owned by GCC, and > > so the mistake here was not propagating the change to the GCC > > repository? > > Yes. > > > 2014-11-13 Shinichiro Hamaji > > > > * dwarf2.h (DW_AT_APPLE_optimized, DW_AT_APPLE_flags) > > (DW_AT_APPLE_isa, DW_AT_APPLE_block) > > (DW_AT_APPLE_major_runtime_vers, DW_AT_APPLE_runtime_class) > > (DW_AT_APPLE_omit_frame_ptr, DW_AT_APPLE_property_name) > > (DW_AT_APPLE_property_getter, DW_AT_APPLE_property_setter) > > (DW_AT_APPLE_property_attribute, DW_AT_APPLE_objc_complete_type) > > (DW_AT_APPLE_property, DW_OP_GNU_entry_value): New macros. > > You aren't adding DW_OP_GNU_entry_value, that is already there. That will teach me for just using the previous commit message, without checking it. > Perhaps a comment with a link to documentation of those would > be helpful here. I had a look around and couldn't find anything helpful. The best I can offer would be the current path within the llvm source code where these are defined. Would that be sufficient? Updated patch below. If this is acceptable could someone commit to GCC please. Thanks, Andrew --- 2014-11-13 Shinichiro Hamaji * dwarf2.def (DW_AT_APPLE_optimized, DW_AT_APPLE_flags) (DW_AT_APPLE_isa, DW_AT_APPLE_block) (DW_AT_APPLE_major_runtime_vers, DW_AT_APPLE_runtime_class) (DW_AT_APPLE_omit_frame_ptr, DW_AT_APPLE_property_name) (DW_AT_APPLE_property_getter, DW_AT_APPLE_property_setter) (DW_AT_APPLE_property_attribute, DW_AT_APPLE_objc_complete_type) (DW_AT_APPLE_property): New macros. diff --git a/include/dwarf2.def b/include/dwarf2.def index 71a37b3..35d01b8 100644 --- a/include/dwarf2.def +++ b/include/dwarf2.def @@ -406,6 +406,21 @@ DW_AT (DW_AT_upc_threads_scaled, 0x3210) DW_AT (DW_AT_PGI_lbase, 0x3a00) DW_AT (DW_AT_PGI_soffset, 0x3a01) DW_AT (DW_AT_PGI_lstride, 0x3a02) +/* Apple extensions. These are defined within the LLVM source code in the + file llvm/include/llvm/Support/Dwarf.h. */ +DW_AT (DW_AT_APPLE_optimized, 0x3fe1) +DW_AT (DW_AT_APPLE_flags, 0x3fe2) +DW_AT (DW_AT_APPLE_isa, 0x3fe3) +DW_AT (DW_AT_APPLE_block, 0x3fe4) +DW_AT (DW_AT_APPLE_major_runtime_vers, 0x3fe5) +DW_AT (DW_AT_APPLE_runtime_class, 0x3fe6) +DW_AT (DW_AT_APPLE_omit_frame_ptr, 0x3fe7) +DW_AT (DW_AT_APPLE_property_name, 0x3fe8) +DW_AT (DW_AT_APPLE_property_getter, 0x3fe9) +DW_AT (DW_AT_APPLE_property_setter, 0x3fea) +DW_AT (DW_AT_APPLE_property_attribute, 0x3feb) +DW_AT (DW_AT_APPLE_objc_complete_type, 0x3fec) +DW_AT (DW_AT_APPLE_property, 0x3fed) DW_END_AT DW_FIRST_OP (DW_OP_addr, 0x03)