From patchwork Thu Nov 13 09:35:28 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 410328 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id E0A9D14003E for ; Thu, 13 Nov 2014 20:35:43 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:mime-version:content-type; q=dns; s=default; b=ZqPye9vRyWZSajapKsYYs8fGps0LGOVA5/OEJYHeGNWo/M2tBA AHZ0hDrbe4oCHNwJu/gwLZuw+ieNeMkYxJO8nQ+5D4Zh1zFrphCi57VXrMC32TvW xH+y6wASZXALlc/K36Dj7lt7gg/N4lLpWdB1wj77i1yHb7Z6++bqXC4Ls= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:mime-version:content-type; s= default; bh=qv0sWLS48FIOBca+HJ82s3keW/U=; b=jIsCaZx0jYy6VFvDIB+H 9WNyNybZYcpw4r2uG+kZ+vjFjYZD49BlnfrOjc3L7b/TTbEAPUC66+DAZXeJD4xi 3El67IP5pxPJBvgzd/cUk/kmj7WDt7naLOVxlHgUAcCNB9JbsHKnV6hu59VScG3a udzhN5CoY++GbFS+xfwCipA= Received: (qmail 11660 invoked by alias); 13 Nov 2014 09:35:35 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 11650 invoked by uid 89); 13 Nov 2014 09:35:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 X-HELO: mail-wg0-f44.google.com Received: from mail-wg0-f44.google.com (HELO mail-wg0-f44.google.com) (74.125.82.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 13 Nov 2014 09:35:33 +0000 Received: by mail-wg0-f44.google.com with SMTP id x12so16360497wgg.17 for ; Thu, 13 Nov 2014 01:35:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-type:content-disposition:user-agent; bh=vjOQ0+suVcOmyCcoF8KLpHmDD/OgAawkEGeguDoKP+s=; b=ZiyWSHxQMFr7zXgw8QA/uN/raXqIZOSu/Kq33eiGMdZtcj3vLVPPPjXCuvkEGjhua9 AFoiDelTJkd99I0oez6FNwoHfN5tCbnf+dSHzq7Sw6G6y2m/IaY2rti0u4P1NsoEzAg5 VLYETZkHvfVA1B9WEIp34YXopJItbHyqA5wgNlGjc+Hvy+cHfPIXAjmmdZV29erGhb04 AQYMtocc5QR+jiweYd9JPy6WTH4vndOV0DpsTfC55kdrdKKBPAeK5BMHhQPKI6XXpR+7 Td1PpDv5/lMDS79oYRnop8AkBYLEoGmdeurbuQIVZJvRvf/mRxqEDILKEpT7toPmj/X7 T+aw== X-Gm-Message-State: ALoCoQkcLwymd5mjhCPVCddabniY1KhTz4zJ8/gc5QX+5s4ZfglnNL6Y74bQ2DVs2s9Uld3z+DE1 X-Received: by 10.180.103.33 with SMTP id ft1mr1899744wib.71.1415871330449; Thu, 13 Nov 2014 01:35:30 -0800 (PST) Received: from localhost (TK158115.telekabel.at. [195.34.158.115]) by mx.google.com with ESMTPSA id bj7sm34767804wjc.33.2014.11.13.01.35.29 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Nov 2014 01:35:29 -0800 (PST) Date: Thu, 13 Nov 2014 10:35:28 +0100 From: Andrew Burgess To: binutils@sourceware.dot.org, gcc-patches@gcc.gnu.org Cc: Shinichiro Hamaji , Nick Clifton Subject: [PATCH] DW_AT_APPLE_* DWARF extensions. Message-ID: <20141113093527.GI3565@embecosm.com> MIME-Version: 1.0 Content-Disposition: inline X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes Some time ago there was an attempt to add the DWARF DW_AT_APPLE_* extensions to the file include/dwarf2.def. The original patch email is here: https://sourceware.org/ml/binutils/2012-09/msg00282.html the "patch committed" mail is here: https://sourceware.org/ml/binutils/2012-10/msg00424.html which corresponds to binutils commit: 10fca301c7ea8362c086647ee8b4b6aa64ad3e67 However, the patch was reverted in binutils commit: 1f3de044c6f615326d31ba878dfcd7fdeee7765f which was an auto-merge from GCC to binutils. Am I correct to think that the include/* files are owned by GCC, and so the mistake here was not propagating the change to the GCC repository? I had a look on the mailing lists and couldn't find any mail suggesting this code was deliberately removed, please correct me if I'm wrong. I'd like to propose that we try again with this patch, unless there's any objection. If I'm right about the ownership then we first need the patch applied to GCC, after that I can apply it to binutils-gdb. I've included the patch I'm proposing we apply below. Any objections? Thanks, Andrew --- include/ChangeLog: 2014-11-13 Shinichiro Hamaji * dwarf2.h (DW_AT_APPLE_optimized, DW_AT_APPLE_flags) (DW_AT_APPLE_isa, DW_AT_APPLE_block) (DW_AT_APPLE_major_runtime_vers, DW_AT_APPLE_runtime_class) (DW_AT_APPLE_omit_frame_ptr, DW_AT_APPLE_property_name) (DW_AT_APPLE_property_getter, DW_AT_APPLE_property_setter) (DW_AT_APPLE_property_attribute, DW_AT_APPLE_objc_complete_type) (DW_AT_APPLE_property, DW_OP_GNU_entry_value): New macros. diff --git a/include/dwarf2.def b/include/dwarf2.def index 7fe2df1..fd2d080 100644 --- a/include/dwarf2.def +++ b/include/dwarf2.def @@ -403,6 +403,20 @@ DW_AT (DW_AT_upc_threads_scaled, 0x3210) DW_AT (DW_AT_PGI_lbase, 0x3a00) DW_AT (DW_AT_PGI_soffset, 0x3a01) DW_AT (DW_AT_PGI_lstride, 0x3a02) +/* Apple extensions. */ +DW_AT (DW_AT_APPLE_optimized, 0x3fe1) +DW_AT (DW_AT_APPLE_flags, 0x3fe2) +DW_AT (DW_AT_APPLE_isa, 0x3fe3) +DW_AT (DW_AT_APPLE_block, 0x3fe4) +DW_AT (DW_AT_APPLE_major_runtime_vers, 0x3fe5) +DW_AT (DW_AT_APPLE_runtime_class, 0x3fe6) +DW_AT (DW_AT_APPLE_omit_frame_ptr, 0x3fe7) +DW_AT (DW_AT_APPLE_property_name, 0x3fe8) +DW_AT (DW_AT_APPLE_property_getter, 0x3fe9) +DW_AT (DW_AT_APPLE_property_setter, 0x3fea) +DW_AT (DW_AT_APPLE_property_attribute, 0x3feb) +DW_AT (DW_AT_APPLE_objc_complete_type, 0x3fec) +DW_AT (DW_AT_APPLE_property, 0x3fed) DW_END_AT DW_FIRST_OP (DW_OP_addr, 0x03)