From patchwork Tue Nov 4 03:36:54 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Wakely X-Patchwork-Id: 406424 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 65E811400EA for ; Tue, 4 Nov 2014 15:49:47 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; q=dns; s=default; b=vDg6ph6eXEiA18k0N UFkVss36OEnnrpHqe0MaAWDDI5fU0gUe2tMbuy9P5p2+54hIPz0Ph01SRvXIqFry AdS1qqGCKKsLQiSJi7NVRp4TaZX8xqp2zUvqGjaSumwN+sCTnHEup8JIYuQnfA8V uodxlbSxfK5X1l+0FwJkuBOPV0= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=default; bh=h5HIjZxt798Bxr7XW7jIW0G cyIA=; b=HEnIAUIUPTRxZOF/+ArC+bka0TwTA17ktkrFvvJww/iybiYnObAYUiv 8Ovi77CbkoxEohqtNjii1IsB8Bl6s2cRCsSm36B3iU41g161N+BHQFCQtBoxssGH OMBFwiBV29p5EvWm7lWWqY6lhrPeFXRD27rbStkvb1o+5wQIReMI= Received: (qmail 17320 invoked by alias); 4 Nov 2014 03:37:07 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 17292 invoked by uid 89); 4 Nov 2014 03:37:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD, SPF_HELO_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 3 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 04 Nov 2014 03:37:04 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sA43avcp022003 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 3 Nov 2014 22:36:58 -0500 Received: from localhost (ovpn-116-19.ams2.redhat.com [10.36.116.19]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id sA43at4A005711; Mon, 3 Nov 2014 22:36:56 -0500 Date: Tue, 4 Nov 2014 03:36:54 +0000 From: Jonathan Wakely To: Paolo Carlini Cc: Rainer Emrich , gcc@gcc.gnu.org, libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: Re: libstdc++ testsuite make targets check-parallel and check-performance don't work anymore Message-ID: <20141104033654.GF3961@redhat.com> References: <54579773.60601@emrich-ebersheim.de> <5457AAF8.5060403@oracle.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5457AAF8.5060403@oracle.com> User-Agent: Mutt/1.5.23 (2014-03-12) On 03/11/14 17:19 +0100, Paolo Carlini wrote: >Hi, > >On 11/03/2014 03:55 PM, Rainer Emrich wrote: >>Since the recent changes to the testsuites the folowing make targets in the >>libstdc++ testsuite directory don't work anymore: >> >>check-parallel >>check-performance >>check-performance-parallel >> >>Any comments? >All I can see so far is a non-conforming use of default arguments (ie, >repeated in the function template definitions) in >include/parallel/algo.h, which the front-end didn't catch until quite >recently (not in 4.9.x). See below what I mean to apply to fix that. >Not sure if you meant something else (too) in your terse message, >tough. has the same problem, fixed with this patch. commit 356183f393d2fce9beb5b2d4772b9f8ab83280cd Author: Jonathan Wakely Date: Tue Nov 4 03:33:07 2014 +0000 * include/parallel/numeric.h: Do not use default arguments in function template redeclarations (definitions). diff --git a/libstdc++-v3/include/parallel/numeric b/libstdc++-v3/include/parallel/numeric index 8254635..e89f27e 100644 --- a/libstdc++-v3/include/parallel/numeric +++ b/libstdc++-v3/include/parallel/numeric @@ -85,8 +85,7 @@ namespace __parallel __accumulate_switch(__RAIter __begin, __RAIter __end, _Tp __init, _BinaryOperation __binary_op, random_access_iterator_tag, - __gnu_parallel::_Parallelism __parallelism_tag - = __gnu_parallel::parallel_unbalanced) + __gnu_parallel::_Parallelism __parallelism_tag) { if (_GLIBCXX_PARALLEL_CONDITION( static_cast<__gnu_parallel::_SequenceIndex>(__end - __begin) @@ -193,8 +192,7 @@ namespace __parallel _BinaryFunction2 __binary_op2, random_access_iterator_tag, random_access_iterator_tag, - __gnu_parallel::_Parallelism __parallelism_tag - = __gnu_parallel::parallel_unbalanced) + __gnu_parallel::_Parallelism __parallelism_tag) { if (_GLIBCXX_PARALLEL_CONDITION((__last1 - __first1) >= __gnu_parallel::_Settings::get(). @@ -419,8 +417,7 @@ namespace __parallel random_access_iterator_tag, random_access_iterator_tag, __gnu_parallel::_Parallelism - __parallelism_tag - = __gnu_parallel::parallel_balanced) + __parallelism_tag) { if (_GLIBCXX_PARALLEL_CONDITION( static_cast<__gnu_parallel::_SequenceIndex>(__end - __begin)