diff mbox

libstdc++ testsuite make targets check-parallel and check-performance don't work anymore

Message ID 20141104033654.GF3961@redhat.com
State New
Headers show

Commit Message

Jonathan Wakely Nov. 4, 2014, 3:36 a.m. UTC 
On 03/11/14 17:19 +0100, Paolo Carlini wrote:
>Hi,
>
>On 11/03/2014 03:55 PM, Rainer Emrich wrote:
>>Since the recent changes to the testsuites the folowing make targets in the
>>libstdc++ testsuite directory don't work anymore:
>>
>>check-parallel
>>check-performance
>>check-performance-parallel
>>
>>Any comments?
>All I can see so far is a non-conforming use of default arguments (ie, 
>repeated in the function template definitions) in 
>include/parallel/algo.h, which the front-end didn't catch until quite 
>recently (not in 4.9.x). See below what I mean to apply to fix that. 
>Not sure if you meant something else (too) in your terse message, 
>tough.

<parallel/numeric> has the same problem, fixed with this patch.

Comments

Paolo Carlini Nov. 4, 2014, 9:55 a.m. UTC | #1 
.. thanks a lot Jon! (after all this parallel mode is still useful for 
something ;)

Paolo.
Rainer Emrich Nov. 4, 2014, 1:31 p.m. UTC | #2 
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 11/04/2014 10:55 AM, schrieb Paolo Carlini:
> .. thanks a lot Jon! (after all this parallel mode is still useful
> for something ;)
> 
> Paolo.
Sorry for the terse message. I'm under heavy workload at the moment.
But AFAIS now everything looks good again.
Thanks a lot, Paolo and Jon!

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBAgAGBQJUWNVLAAoJEB3HOsWs+KJb24YIAJ9WUYMXxfVfQetYQjh60rKv
VGJaJ30imyhx5i+G06XI9vPpds0zICnAm/CPNp4bQKAR8XkO0CzI7qbP63KYTPOA
nRBDG1sbhxOpXYWbx7CJ52MM860bYF4MuvVSX1aXVmE2at1MqiYxSscARYGJx5b8
e7+7C12TuyocdU9l3edv3j1eA2eW0R4A9Ae1XECsUQg8llgnhiT5p+Jd1fffwUSH
g+v8TDXwqcvmdt/aTfyP1C/Gl3YWh/uZARqcbiShq+dlb2je7n2s1l/ZpXc26vXN
Z10BIt7x3FRM61qQuUuiRHlRgEcEeaFpy4uPoYKLfbsAToPYcPKbY8YE7qQGNKo=
=SdTc
-----END PGP SIGNATURE-----
diff mbox

Patch

commit 356183f393d2fce9beb5b2d4772b9f8ab83280cd
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Tue Nov 4 03:33:07 2014 +0000

    	* include/parallel/numeric.h: Do not use default arguments in function
    	template redeclarations (definitions).

diff --git a/libstdc++-v3/include/parallel/numeric b/libstdc++-v3/include/parallel/numeric
index 8254635..e89f27e 100644
--- a/libstdc++-v3/include/parallel/numeric
+++ b/libstdc++-v3/include/parallel/numeric
@@ -85,8 +85,7 @@  namespace __parallel
     __accumulate_switch(__RAIter __begin, __RAIter __end, 
                       _Tp __init, _BinaryOperation __binary_op, 
                       random_access_iterator_tag, 
-                      __gnu_parallel::_Parallelism __parallelism_tag  
-                      = __gnu_parallel::parallel_unbalanced)
+                      __gnu_parallel::_Parallelism __parallelism_tag)
     {
       if (_GLIBCXX_PARALLEL_CONDITION(
             static_cast<__gnu_parallel::_SequenceIndex>(__end - __begin)
@@ -193,8 +192,7 @@  namespace __parallel
 			   _BinaryFunction2 __binary_op2,
 			   random_access_iterator_tag,
 			   random_access_iterator_tag,
-			   __gnu_parallel::_Parallelism __parallelism_tag
-			   = __gnu_parallel::parallel_unbalanced)
+			   __gnu_parallel::_Parallelism __parallelism_tag)
     {
       if (_GLIBCXX_PARALLEL_CONDITION((__last1 - __first1)
                                       >= __gnu_parallel::_Settings::get().
@@ -419,8 +417,7 @@  namespace __parallel
 				 random_access_iterator_tag,
 				 random_access_iterator_tag,
 				 __gnu_parallel::_Parallelism
-				 __parallelism_tag
-				 = __gnu_parallel::parallel_balanced)
+				 __parallelism_tag)
     {
       if (_GLIBCXX_PARALLEL_CONDITION(
             static_cast<__gnu_parallel::_SequenceIndex>(__end - __begin)