From patchwork Thu Oct 23 19:59:38 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Wakely X-Patchwork-Id: 402641 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 0BBA814003E for ; Fri, 24 Oct 2014 06:59:50 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:mime-version:content-type; q=dns; s=default; b=UUZDgdlYuyCRA9L95esNgcwBpArKVEl1YpeqLzf+bMaNoXeGh9 BqxdsVEuG2uCYQnODG/YzletFCrj+YBXMad4Yo27qnAtrmLyPMjUxTF1UJyzBvd5 C6rydCZ/r837UgT3l1bjfIoYo0sfZ0CX7MzkLHftO5bLJRhlMdy9jNEFs= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:mime-version:content-type; s= default; bh=ZKku6fOL6dWlzuY/jXfZ0Su5vgM=; b=CyHaEZZ5vxSugeI8cYeT RiH3flJHOxxwcxwaJEbrABXFjGdnR3vJPsTJDbEeeQMvXbJdSfTn6fjt3VoRmJUM WeAiihcEcWj6eYkR27bkTAyRrYvo/9OA7MAD71gy7F+Yxt5qpUaexO98YjG5qbli rLjD5soq2ybjOOmFzIkMCYw= Received: (qmail 16712 invoked by alias); 23 Oct 2014 19:59:42 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 16695 invoked by uid 89); 23 Oct 2014 19:59:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD, SPF_HELO_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 23 Oct 2014 19:59:41 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s9NJxeYQ026738 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 23 Oct 2014 15:59:40 -0400 Received: from localhost (ovpn-116-123.ams2.redhat.com [10.36.116.123]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s9NJxdSW008135; Thu, 23 Oct 2014 15:59:39 -0400 Date: Thu, 23 Oct 2014 20:59:38 +0100 From: Jonathan Wakely To: gcc-patches@gcc.gnu.org Cc: jason@gcc.gnu.org Subject: [patch] c++/63619 Use -Wdelete-incomplete for "deleting 'void' is undefined" warning Message-ID: <20141023195938.GB3033@redhat.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) Tested x86_64-linux. OK for trunk? commit c3ce106375d17223bacaaccbf36bd15fcef3f560 Author: Jonathan Wakely Date: Thu Oct 23 18:11:22 2014 +0100 gcc/cp: PR c++/63619 * decl2.c (delete_sanity): Use OPT_Wdelete_incomplete in warning. gcc/testsuite: PR c++/63619 * g++.dg/warn/Wdelete-incomplete-3.C: New. diff --git a/gcc/cp/decl2.c b/gcc/cp/decl2.c index 4be4847..60c8a63 100644 --- a/gcc/cp/decl2.c +++ b/gcc/cp/decl2.c @@ -478,7 +478,7 @@ delete_sanity (tree exp, tree size, bool doing_vec, int use_global_delete, /* Deleting ptr to void is undefined behavior [expr.delete/3]. */ if (VOID_TYPE_P (TREE_TYPE (type))) { - warning (0, "deleting %qT is undefined", type); + warning (OPT_Wdelete_incomplete, "deleting %qT is undefined", type); doing_vec = 0; } diff --git a/gcc/testsuite/g++.dg/warn/Wdelete-incomplete-3.C b/gcc/testsuite/g++.dg/warn/Wdelete-incomplete-3.C new file mode 100644 index 0000000..2202d60 --- /dev/null +++ b/gcc/testsuite/g++.dg/warn/Wdelete-incomplete-3.C @@ -0,0 +1,6 @@ +// PR c++/63619 + +int main() { + void* p; + delete p; // { dg-warning "undefined" } +}