From patchwork Thu Sep 25 10:50:36 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Wakely X-Patchwork-Id: 393313 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 6B0DD140171 for ; Thu, 25 Sep 2014 20:50:56 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:subject:message-id:references:mime-version:content-type :in-reply-to; q=dns; s=default; b=piiaagQeNeVFgEYP6SEhXqWea9lyNK y3CQaIB4fWGYjhmyh7X+bI6pVqy5XrQV9P0LdyKu0PJvhOdspMcqW+KXn08T69cS 6ipxbnp9K2gRqru9RaXcpYzqIJXKn9csk3TQXetyJ/nJ4zIHCas0eD3Jxt8FUoSB dhU9s47KaslWo= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:subject:message-id:references:mime-version:content-type :in-reply-to; s=default; bh=QZw3ifXPsH2S7Fn4WYUwjOXiHQQ=; b=Y+v4 mZ0I4jb0GOEq8cwYMYFI6CEBEGMNWiK2qXMbBtr9ieU26fVvHDMav2fGgDKb2d3h PszRmVGXgXDCa45yZv+JNltDBdeGSXfmW6uEm6MYXY83akMmFnkuaQq1n+ON/bmD 7izOl2uED+X1sV6M60WDF7jKbzGA69yJYXB4t6o= Received: (qmail 27075 invoked by alias); 25 Sep 2014 10:50:41 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 27057 invoked by uid 89); 25 Sep 2014 10:50:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 25 Sep 2014 10:50:39 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8PAoch8004063 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 25 Sep 2014 06:50:38 -0400 Received: from localhost (ovpn-116-40.ams2.redhat.com [10.36.116.40]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s8PAoahv005794; Thu, 25 Sep 2014 06:50:37 -0400 Date: Thu, 25 Sep 2014 11:50:36 +0100 From: Jonathan Wakely To: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: Re: [patch] libstdc++/56193 re-add basic_ios::operator bool() Message-ID: <20140925105036.GC2669@redhat.com> References: <20140924221814.GZ2669@redhat.com> <20140925102416.GB2669@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20140925102416.GB2669@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) On 25/09/14 11:24 +0100, Jonathan Wakely wrote: >On 24/09/14 23:18 +0100, Jonathan Wakely wrote: >>This changes operator void*() to operator bool(), and ensures we >>export both from the library. >> >>I have a new test for this, but will commit that tomorrow. > >Here are the tests. Argh, I took the { dg-do compile } out then forgot to put it back. Here it is, tested x86_64-linux and committed to trunk. I hope I'm done with iostreams for now, at least until next week when I want to apply the hexfloat patch from earlier this year. commit 9d4bf29883f25ea2dca1cf270c480c68ece7a736 Author: Jonathan Wakely Date: Thu Sep 25 11:29:24 2014 +0100 * testsuite/27_io/basic_ios/conv/bool_neg.cc: Add dg-do compile. diff --git a/libstdc++-v3/testsuite/27_io/basic_ios/conv/bool_neg.cc b/libstdc++-v3/testsuite/27_io/basic_ios/conv/bool_neg.cc index 816f851..d4b8cac 100644 --- a/libstdc++-v3/testsuite/27_io/basic_ios/conv/bool_neg.cc +++ b/libstdc++-v3/testsuite/27_io/basic_ios/conv/bool_neg.cc @@ -16,6 +16,7 @@ // . // { dg-options "-std=gnu++11" } +// { dg-do compile } #include