diff mbox

PATCH: PR target/60151: HAVE_AS_GOTOFF_IN_DATA is mis-detected on x86-64

Message ID 20140211192802.GA26305@intel.com
State New
Headers show

Commit Message

H.J. Lu Feb. 11, 2014, 7:28 p.m. UTC 
Hi,

HAVE_AS_GOTOFF_IN_DATA defines a 32-bit assembler feature, we need to
pass --32 to assembler. Otherwise, we get the wrong result on x86-64.
We already pass --32 to assembler on x86.  It should be OK to do it
in configure.  OK for trunk?

Thanks.

H.J.
---
2014-02-11  H.J. Lu  <hongjiu.lu@intel.com>

	PR target/60151
	* configure.ac (HAVE_AS_GOTOFF_IN_DATA): Pass --32 to assembler.
	* configure: Regenerated.

Comments

Rainer Orth Feb. 11, 2014, 7:40 p.m. UTC | #1 
Hi H.J.,

> HAVE_AS_GOTOFF_IN_DATA defines a 32-bit assembler feature, we need to
> pass --32 to assembler. Otherwise, we get the wrong result on x86-64.
> We already pass --32 to assembler on x86.  It should be OK to do it
> in configure.  OK for trunk?

This would break Solaris/x86 with as configurations, where this test
currently passes, but would fail since as doesn't understand --32.

	Rainer
Uros Bizjak Feb. 11, 2014, 7:41 p.m. UTC | #2 
On Tue, Feb 11, 2014 at 8:28 PM, H.J. Lu <hongjiu.lu@intel.com> wrote:

> HAVE_AS_GOTOFF_IN_DATA defines a 32-bit assembler feature, we need to
> pass --32 to assembler. Otherwise, we get the wrong result on x86-64.
> We already pass --32 to assembler on x86.  It should be OK to do it
> in configure.  OK for trunk?

Unfortunately, .code32 didn't work as expected...

So, OK.

Thanks,
Uros.
diff mbox

Patch

diff --git a/gcc/configure.ac b/gcc/configure.ac
index ac3d842..0aafbc9 100644
--- a/gcc/configure.ac
+++ b/gcc/configure.ac
@@ -3868,7 +3868,7 @@  foo:	nop
     # These two are used unconditionally by i386.[ch]; it is to be defined
     # to 1 if the feature is present, 0 otherwise.
     gcc_GAS_CHECK_FEATURE([GOTOFF in data],
-        gcc_cv_as_ix86_gotoff_in_data, [2,11,0],,
+        gcc_cv_as_ix86_gotoff_in_data, [2,11,0], --32,
 [	.text
 .L0:
 	nop