From patchwork Fri Jan 10 19:26:55 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans-Peter Nilsson X-Patchwork-Id: 309372 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 695932C0098 for ; Sat, 11 Jan 2014 06:27:11 +1100 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :message-id:from:to:subject:mime-version:content-type :content-transfer-encoding; q=dns; s=default; b=d/tjKVqEOxxYHunN 6CjvWxQooFeugMgZ90BOU+hwbA7lw7k95Ye+w3nujpxiAJzNj9jEVabfuJxwFlT8 lurWnwcDfspiW38kq80F6U6sr/tzV6r5ZK7E8okt11v9WtaEtrBCkvYD/3vty5QP j2QGv6OO0t3732paAKRlLvgaSNk= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :message-id:from:to:subject:mime-version:content-type :content-transfer-encoding; s=default; bh=I6yzPCXoaC7Eh0XFIv4I4W ykKVE=; b=P/1yL/hugOopMngRL+D9bEaWl3hCbbAm7cQzkpM18DRwcZ8YYrXXmx h2jTyQJT8DvOy6/UPCjCG0u3jOq7zKhX5L24UVg91ILtIEf7HX97DRE7GSRFjSkX 1p9U5hBhKtdjWbgNvXcMvRbHrU/ui9WUzJZg3tLxqPP3NwcWUJidw= Received: (qmail 29523 invoked by alias); 10 Jan 2014 19:27:04 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 29511 invoked by uid 89); 10 Jan 2014 19:27:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 X-HELO: anubis.se.axis.com Received: from anubis.se.axis.com (HELO anubis.se.axis.com) (195.60.68.12) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 10 Jan 2014 19:27:01 +0000 Received: from localhost (localhost [127.0.0.1]) by anubis.se.axis.com (Postfix) with ESMTP id C6D1B19FBB for ; Fri, 10 Jan 2014 20:26:57 +0100 (CET) Received: from anubis.se.axis.com ([127.0.0.1]) by localhost (anubis.se.axis.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id wTSSpQdcPbj1 for ; Fri, 10 Jan 2014 20:26:56 +0100 (CET) Received: from boulder.se.axis.com (boulder.se.axis.com [10.0.2.104]) by anubis.se.axis.com (Postfix) with ESMTP id 4C03A19EB5 for ; Fri, 10 Jan 2014 20:26:56 +0100 (CET) Received: from boulder.se.axis.com (localhost [127.0.0.1]) by postfix.imss71 (Postfix) with ESMTP id 10BB3BD9 for ; Fri, 10 Jan 2014 20:26:56 +0100 (CET) Received: from thoth.se.axis.com (thoth.se.axis.com [10.0.2.173]) by boulder.se.axis.com (Postfix) with ESMTP id 05817965 for ; Fri, 10 Jan 2014 20:26:56 +0100 (CET) Received: from ignucius.se.axis.com (ignucius.se.axis.com [10.88.21.50]) by thoth.se.axis.com (Postfix) with ESMTP id 037253404E; Fri, 10 Jan 2014 20:26:56 +0100 (CET) Received: from ignucius.se.axis.com (localhost [127.0.0.1]) by ignucius.se.axis.com (8.12.8p1/8.12.8/Debian-2woody1) with ESMTP id s0AJQth9013632; Fri, 10 Jan 2014 20:26:55 +0100 Received: (from hp@localhost) by ignucius.se.axis.com (8.12.8p1/8.12.8/Debian-2woody1) id s0AJQtBw013628; Fri, 10 Jan 2014 20:26:55 +0100 Date: Fri, 10 Jan 2014 20:26:55 +0100 Message-Id: <201401101926.s0AJQtBw013628@ignucius.se.axis.com> From: Hans-Peter Nilsson To: gcc-patches@gcc.gnu.org Subject: Committed: skip gcc.dg/pr46309.c for CRIS MIME-Version: 1.0 This patch "fixes" a regression on trunk and the 4.8 branch: Running /tmp/hpautotest-gcc48/gcc/gcc/testsuite/gcc.dg/dg.exp ... ... FAIL: gcc.dg/pr46309.c scan-tree-dump-times reassoc2 "Optimizing range tests [^\r\n]*_[0-9]* -.0, 31. and -.128, 159.[\n\r]* into" 1 The comment in the test seen in the context indicates that it depends on BRANCH_COST > 1. As all cris*-*-* have BRANCH_COST 1 (with no option that set it higher), the only reasonable option seems to skip the test. A FAIL for this test seems only also noticed for MIPS, AVR and s390; the test sets options to change branch-cost to 2 for those targets (IMHO unconventional to have an option exactly for this purpose) in the lines below the patch context. That the test has ever PASSed thus seemed weird so I looked in my logs. The test hasn't always passed for CRIS: it started passing on trunk at (193019:193029] (before the 4.8 branch; 2012-10-31) which includes a commit with a follow-up for PR46309 with more test-coverage (without BRANCH_COST notes). The test-case gcc.dg/pr46309.c was not touched at that time and any PASS effect for targets with BRANCH_COST=1 seems only incidental. It started failing for trunk at (206454:206460] and on 4.8-branch at (206507:206513] whose intersection has: +2014-01-09 Richard Biener + + PR tree-optimization/59715 + * tree-cfg.h (split_critical_edges): Declare. + * tree-cfg.c (split_critical_edges): Export. + * tree-ssa-sink.c (execute_sink_code): Split critical edges. + and the effect of the test failing seems as incidental as when it started to pass. BTW, I verified that setting BRANCH_COST to 2 indeed makes the test pass for cris-elf, which of course by itself is not an acceptable fix. I know there's a redundant {} level there, but it won't be redundant if adding targets to that list, still if there are more tests like this maybe it's worthwhile to consider adding an effective-target branch_cost_gt_1 or something. gcc/testsuite: * gcc.dg/pr46309.c: Disable for cris*-*-*. Anyway, enough with the commentary, committed to trunk and 4.8-branch. brgds, H-P Index: gcc/testsuite/gcc.dg/pr46309.c =================================================================== --- gcc/testsuite/gcc.dg/pr46309.c (revision 206534) +++ gcc/testsuite/gcc.dg/pr46309.c (working copy) @@ -1,5 +1,5 @@ /* PR tree-optimization/46309 */ -/* { dg-do compile } */ +/* { dg-do compile { target { ! { cris*-*-* } } } } */ /* { dg-options "-O2 -fdump-tree-reassoc-details" } */ /* The transformation depends on BRANCH_COST being greater than 1 (see the notes in the PR), so try to force that. */