From patchwork Mon Dec 23 23:13:51 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans-Peter Nilsson X-Patchwork-Id: 304856 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44ECB2C009F for ; Tue, 24 Dec 2013 10:14:03 +1100 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :message-id:from:to:subject:mime-version:content-type :content-transfer-encoding; q=dns; s=default; b=UJOW3Z2J+CcaiE3R UuTSGrtYjHXPsmgnPJRcuCOwYSKICM4j4INLb8RPXHFCiYH3qeDUFpzujK3zVaQK UBrDB6pe3gTzlqSt/xDBbotOz8nYOkkOpNWcjoQQY7Soy2jeqiYxWgiH67C7Kel6 i3vQ1sMeLoKLmFHOjoSvru2yzg4= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :message-id:from:to:subject:mime-version:content-type :content-transfer-encoding; s=default; bh=wrftnQhBbX4dCvjvjDhL0j mQrsg=; b=aq9rpZrHyuY9RQsu0hYiihWLX3R7KsFuQ7lyJybb5d6RVaZB1XeCe7 a4U7jktrf0vjuPXiseOARhhlcuNFTgHhsqgBXYz0SZVzzF/KidzXqcnfSSdsMj55 q9qkktYvyTQsA/IWX56Z0vWT0z85ulqm2TfSAQX9S+WISJOEzL2l0= Received: (qmail 22089 invoked by alias); 23 Dec 2013 23:13:56 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 22077 invoked by uid 89); 23 Dec 2013 23:13:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=AWL, BAYES_00, KAM_HOODIA, RP_MATCHES_RCVD, SPF_PASS autolearn=no version=3.3.2 X-HELO: anubis.se.axis.com Received: from anubis.se.axis.com (HELO anubis.se.axis.com) (195.60.68.12) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 23 Dec 2013 23:13:55 +0000 Received: from localhost (localhost [127.0.0.1]) by anubis.se.axis.com (Postfix) with ESMTP id 1581A19E36 for ; Tue, 24 Dec 2013 00:13:53 +0100 (CET) Received: from anubis.se.axis.com ([127.0.0.1]) by localhost (anubis.se.axis.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 2ASJCWOwyQiC for ; Tue, 24 Dec 2013 00:13:52 +0100 (CET) Received: from boulder.se.axis.com (boulder.se.axis.com [10.0.2.104]) by anubis.se.axis.com (Postfix) with ESMTP id 8A5B219E2F for ; Tue, 24 Dec 2013 00:13:52 +0100 (CET) Received: from boulder.se.axis.com (localhost [127.0.0.1]) by postfix.imss71 (Postfix) with ESMTP id 74845AB4 for ; Tue, 24 Dec 2013 00:13:52 +0100 (CET) Received: from thoth.se.axis.com (thoth.se.axis.com [10.0.2.173]) by boulder.se.axis.com (Postfix) with ESMTP id 695D9618 for ; Tue, 24 Dec 2013 00:13:52 +0100 (CET) Received: from ignucius.se.axis.com (ignucius.se.axis.com [10.88.21.50]) by thoth.se.axis.com (Postfix) with ESMTP id 6744D34070; Tue, 24 Dec 2013 00:13:52 +0100 (CET) Received: from ignucius.se.axis.com (localhost [127.0.0.1]) by ignucius.se.axis.com (8.12.8p1/8.12.8/Debian-2woody1) with ESMTP id rBNNDqh9019221; Tue, 24 Dec 2013 00:13:52 +0100 Received: (from hp@localhost) by ignucius.se.axis.com (8.12.8p1/8.12.8/Debian-2woody1) id rBNNDpa2019217; Tue, 24 Dec 2013 00:13:51 +0100 Date: Tue, 24 Dec 2013 00:13:51 +0100 Message-Id: <201312232313.rBNNDpa2019217@ignucius.se.axis.com> From: Hans-Peter Nilsson To: gcc-patches@gcc.gnu.org Subject: Committed: fix PR target/59203, typo in cris.c MIME-Version: 1.0 Spotted by David Binderman and cppcheck, thanks. The interesting cases wouldn't be exposed by a cris-elf build, but I made a regtest-run nonetheless: the fix has actually been in our local tree for quite some time together with TLS for CRIS v32 so I'm not worried about fallout. (Upstreaming that? Hm... one excuse I use is that I've been waiting for TLS for CRIS v10 to materialize for the Linux kernel, along the v32 lines but using $IRP, but that never happened.) PR target/59203 * config/cris/cris.c (cris_pic_symbol_type_of): Fix typo, checking t1 twice instead of t1 and t2 respectively. brgds, H-P Index: gcc/config/cris/cris.c =================================================================== --- gcc/config/cris/cris.c (revision 206176) +++ gcc/config/cris/cris.c (working copy) @@ -2493,7 +2493,7 @@ cris_pic_symbol_type_of (const_rtx x) gcc_assert (t1 == cris_no_symbol || t2 == cris_no_symbol); - if (t1 == cris_got_symbol || t1 == cris_got_symbol) + if (t1 == cris_got_symbol || t2 == cris_got_symbol) return cris_got_symbol_needing_fixup; return t1 != cris_no_symbol ? t1 : t2;