| Message ID | 20131022082233.GM19160@lug-owl.de |
|---|---|
| State | New |
| Headers | show |
On Tue, Oct 22, 2013 at 4:22 AM, Jan-Benedict Glaw <jbglaw@lug-owl.de> wrote: > On Mon, 2013-10-21 15:36:49 -0400, Diego Novillo <dnovillo@google.com> wrote: >> Can anyone think of some way that we can use to automatically block >> inclusions of tree.h from header files? Code review is the only way >> that comes to mind. > > Grep once, then install a commit hook. Hm, that may work. Thanks. > I get some fallout for tilepro-linux, see > http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=21851 . Sorry about that. I missed it in my testing because tilepro-linux-gnu fails early in libcpp with: ../../../gcc/libcpp/macro.c:2965:58: error: format not a string literal and no format arguments [-Werror=format-security] ../../../gcc/libcpp/macro.c:2978:58: error: format not a string literal and no format arguments [-Werror=format-security] > This fixes it: > > 2013-10-22 Jan-Benedict Glaw <jbglaw@lug-owl.de> > > * config/tilepro/tilepro.c: Include "tree.h". Sure. It qualifies as obvious. Thanks. Diego.
diff --git a/gcc/config/tilepro/tilepro.c b/gcc/config/tilepro/tilepro.c index 99ce5a0..12adda3 100644 --- a/gcc/config/tilepro/tilepro.c +++ b/gcc/config/tilepro/tilepro.c @@ -40,6 +40,7 @@ #include "function.h" #include "dwarf2.h" #include "timevar.h" +#include "tree.h" #include "gimple.h" #include "cfgloop.h" #include "tilepro-builtins.h"