diff mbox

Silence an unused variable warning

Message ID 20130920185137.GE536@lug-owl.de
State New
Headers show

Commit Message

Jan-Benedict Glaw Sept. 20, 2013, 6:51 p.m. UTC 
Hi!

With the VAX target, I see this warning:

g++ -c   -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE  -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -fno-common  -DHAVE_CONFIG_H -I. -I. -I../../../../gcc/gcc -I../../../../gcc/gcc/. -I../../../../gcc/gcc/../include -I../../../../gcc/gcc/../libcpp/include  -I../../../../gcc/gcc/../libdecnumber -I../../../../gcc/gcc/../libdecnumber/dpd -I../libdecnumber -I../../../../gcc/gcc/../libbacktrace    ../../../../gcc/gcc/lra-eliminations.c -o lra-eliminations.o
../../../../gcc/gcc/lra-eliminations.c: In function ‘void init_elim_table()’:
../../../../gcc/gcc/lra-eliminations.c:1162:8: warning: unused variable ‘value_p’ [-Wunused-variable]
   bool value_p;
        ^

This is because we don't eliminate any registers (beyond GCC's
internal default). Fixed by moving this variable into the #ifdef block
to which it belongs.


2013-09-20  Jan-Benedict Glaw  <jbglaw@lug-owl.de>

gcc/
	* lra-eliminations.c (update_reg_eliminate): Guard value_p.


MfG, JBG

Comments

Jan-Benedict Glaw Sept. 27, 2013, 12:24 a.m. UTC | #1 
On Fri, 2013-09-20 20:51:37 +0200, Jan-Benedict Glaw <jbglaw@lug-owl.de> wrote:
> Hi!
> 
> With the VAX target, I see this warning:
> 
> g++ -c   -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE  -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -fno-common  -DHAVE_CONFIG_H -I. -I. -I../../../../gcc/gcc -I../../../../gcc/gcc/. -I../../../../gcc/gcc/../include -I../../../../gcc/gcc/../libcpp/include  -I../../../../gcc/gcc/../libdecnumber -I../../../../gcc/gcc/../libdecnumber/dpd -I../libdecnumber -I../../../../gcc/gcc/../libbacktrace    ../../../../gcc/gcc/lra-eliminations.c -o lra-eliminations.o
> ../../../../gcc/gcc/lra-eliminations.c: In function ‘void init_elim_table()’:
> ../../../../gcc/gcc/lra-eliminations.c:1162:8: warning: unused variable ‘value_p’ [-Wunused-variable]
>    bool value_p;
>         ^
[...]

Ping:

http://gcc.gnu.org/ml/gcc-patches/2013-09/msg01568.html
`--> http://gcc.gnu.org/ml/gcc-patches/2013-09/txtnrNwaGiD3x.txt

MfG, JBG
Dodji Seketeli Sept. 27, 2013, 8:55 a.m. UTC | #2 
Let's CC Vladimir on this easy one.

Cheers.

Jan-Benedict Glaw <jbglaw@lug-owl.de> a écrit:

> On Fri, 2013-09-20 20:51:37 +0200, Jan-Benedict Glaw <jbglaw@lug-owl.de> wrote:
>> Hi!
>> 
>> With the VAX target, I see this warning:
>> 
>> g++ -c   -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE  -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -fno-common  -DHAVE_CONFIG_H -I. -I. -I../../../../gcc/gcc -I../../../../gcc/gcc/. -I../../../../gcc/gcc/../include -I../../../../gcc/gcc/../libcpp/include  -I../../../../gcc/gcc/../libdecnumber -I../../../../gcc/gcc/../libdecnumber/dpd -I../libdecnumber -I../../../../gcc/gcc/../libbacktrace    ../../../../gcc/gcc/lra-eliminations.c -o lra-eliminations.o
>> ../../../../gcc/gcc/lra-eliminations.c: In function ‘void init_elim_table()’:
>> ../../../../gcc/gcc/lra-eliminations.c:1162:8: warning: unused variable ‘value_p’ [-Wunused-variable]
>>    bool value_p;
>>         ^
> [...]
>
> Ping:
>
> http://gcc.gnu.org/ml/gcc-patches/2013-09/msg01568.html
> `--> http://gcc.gnu.org/ml/gcc-patches/2013-09/txtnrNwaGiD3x.txt
>
> MfG, JBG
Vladimir Makarov Sept. 27, 2013, 3:07 p.m. UTC | #3 
On 13-09-27 4:55 AM, Dodji Seketeli wrote:
> Let's CC Vladimir on this easy one.
>
> Cheers.
All targets I know have ELIMINABLE_REGS defined.  Therefore it was not 
caught before.
.
The patch is ok for me.  Thanks.


> Jan-Benedict Glaw <jbglaw@lug-owl.de> a écrit:
>
>> On Fri, 2013-09-20 20:51:37 +0200, Jan-Benedict Glaw <jbglaw@lug-owl.de> wrote:
>>> Hi!
>>>
>>> With the VAX target, I see this warning:
>>>
>>> g++ -c   -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE  -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -fno-common  -DHAVE_CONFIG_H -I. -I. -I../../../../gcc/gcc -I../../../../gcc/gcc/. -I../../../../gcc/gcc/../include -I../../../../gcc/gcc/../libcpp/include  -I../../../../gcc/gcc/../libdecnumber -I../../../../gcc/gcc/../libdecnumber/dpd -I../libdecnumber -I../../../../gcc/gcc/../libbacktrace    ../../../../gcc/gcc/lra-eliminations.c -o lra-eliminations.o
>>> ../../../../gcc/gcc/lra-eliminations.c: In function ‘void init_elim_table()’:
>>> ../../../../gcc/gcc/lra-eliminations.c:1162:8: warning: unused variable ‘value_p’ [-Wunused-variable]
>>>     bool value_p;
>>>          ^
>> [...]
>>
diff mbox

Patch

diff --git a/gcc/lra-eliminations.c b/gcc/lra-eliminations.c
index f2a5751..c332575 100644
--- a/gcc/lra-eliminations.c
+++ b/gcc/lra-eliminations.c
@@ -1159,9 +1159,9 @@  update_reg_eliminate (bitmap insns_with_changed_offsets)
 static void
 init_elim_table (void)
 {
-  bool value_p;
   struct elim_table *ep;
 #ifdef ELIMINABLE_REGS
+  bool value_p;
   const struct elim_table_1 *ep1;
 #endif