From patchwork Tue Nov 20 13:31:45 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Jambor X-Patchwork-Id: 200333 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 068782C009A for ; Wed, 21 Nov 2012 00:32:04 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1354023126; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Date: From:To:Cc:Subject:Message-ID:Mail-Followup-To:References: MIME-Version:Content-Type:Content-Disposition:In-Reply-To: User-Agent:Mailing-List:Precedence:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:Sender:Delivered-To; bh=n4+SjfR c48pJX3he3UqHNL7DW/k=; b=bXjgvohM7fJ36zPHXoHF1XRn1eyAD7wSjMyBvVR 6L7iQ9fmVz7tVsqGNmqQPPNWwEcMPruk6C4EyPepN5be7PgLGMRqBxVfc0kzLglR EUhV0jb3CDezMYHpOdRXx0r3TjxpEATn4aVhCaw1c7KpCcA/WBJPxpY5IVyEzXYk 0uvU= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Date:From:To:Cc:Subject:Message-ID:Mail-Followup-To:References:MIME-Version:Content-Type:Content-Disposition:In-Reply-To:User-Agent:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=mYaz9f26ISVkrfVXqQaU9tGiXCF6cXFRW1njIkGwjvpLP3W68tx1w1+XnWhCgR 3hoOz9d5S4+iG3OAui430VXaP0wZYNsmm/9DWv8tj/Jv5LjyDiTTFUe7PJHNhaxi OtaYaJrr51ehZ/AxNk7QP3oSKRDCI89x5BB14nw8HS18Y=; Received: (qmail 16213 invoked by alias); 20 Nov 2012 13:31:52 -0000 Received: (qmail 16194 invoked by uid 22791); 20 Nov 2012 13:31:51 -0000 X-SWARE-Spam-Status: No, hits=-5.4 required=5.0 tests=AWL, BAYES_00, KHOP_RCVD_UNTRUST, RCVD_IN_DNSWL_HI, TW_GZ X-Spam-Check-By: sourceware.org Received: from cantor2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 20 Nov 2012 13:31:46 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id A58A8A2111; Tue, 20 Nov 2012 14:31:45 +0100 (CET) Date: Tue, 20 Nov 2012 14:31:45 +0100 From: Martin Jambor To: David Edelsohn Cc: Jan Hubicka , GCC Patches Subject: Re: [PR 55238] More careful pass-through handling in find_aggregate_values_for_callers_subset Message-ID: <20121120133144.GB14889@virgil.arch.suse.de> Mail-Followup-To: David Edelsohn , Jan Hubicka , GCC Patches References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Hi, On Fri, Nov 16, 2012 at 08:42:46AM -0500, David Edelsohn wrote: > * testsuite/gcc.dg/torture/pr55238.c: New test. > > Does this PR rely on hidden visibility? The new testcase uses > attribute visibility hidden, but does not check DejaGNU > dg-require-visibility and fails on AIX. No, at least on my i686 desktop it does not rely on it. I will apply the following patch in a few hours (after I add it to some testing run on x86_64), unless someone objects. Thanks, Martin 2012-11-20 Martin Jambor * gcc.dg/torture/pr55238.c: Remove hidden attribute. Index: src/gcc/testsuite/gcc.dg/torture/pr55238.c =================================================================== --- src.orig/gcc/testsuite/gcc.dg/torture/pr55238.c +++ src/gcc/testsuite/gcc.dg/torture/pr55238.c @@ -31,7 +31,7 @@ gzbuffer (void *file, int size) gz_reset (state); } -void __attribute__ ((visibility ("hidden"))) gz_error (gz_state *state, int err, char *msg) +void gz_error (gz_state *state, int err, char *msg) { if (state->msg != 0) {