From patchwork Tue Nov 13 06:16:52 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans-Peter Nilsson X-Patchwork-Id: 198548 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 947D12C00C1 for ; Tue, 13 Nov 2012 17:17:19 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1353392240; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Received:Received:Received:Received:Date:Message-Id:From:To: Subject:MIME-Version:Content-Type:Content-Transfer-Encoding: Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:Sender:Delivered-To; bh=8Lq76rc+xo4hwfGZA3rJ K1y9n34=; b=pxTE8V208pHFOpsL9mrXmnYM/Ep5JOZ/28LoP+sJG3AI38+ue985 Tk9Aq5Q0ghjhlaWcfs9PB4V+MwdoQDGM8edQKT59Gah28PWbxVfhUhjHW0KMp9BI YNy38T/0JoL4YDgRbIiRqmN5De+Ft5gpKVZAfE7bcowZYOdN4bDc7cU= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:Received:Received:Received:Received:Date:Message-Id:From:To:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=RTW0RyQpJVO+CgSjenmnunFx2v5ZB6ejuOpdqTf7NAk6N0vMMJsCW4kRtX4zwc PnppIKl6x3B5DTZFg0XU9lFP4kaWzOxN3cBtF5d8MuY4yHKr5Sizzw3ctQLOx99W 4PQq7hceifOmpopJ5Q4hdy4PP0nMaN8cjgzJ8wwFy3a3M=; Received: (qmail 8286 invoked by alias); 13 Nov 2012 06:17:13 -0000 Received: (qmail 8273 invoked by uid 22791); 13 Nov 2012 06:17:11 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL, BAYES_00, RCVD_IN_HOSTKARMA_NO, RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from anubis.se.axis.com (HELO anubis.se.axis.com) (195.60.68.12) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 13 Nov 2012 06:17:04 +0000 Received: from localhost (localhost [127.0.0.1]) by anubis.se.axis.com (Postfix) with ESMTP id 7C7CD19DE9 for ; Tue, 13 Nov 2012 07:16:54 +0100 (CET) Received: from anubis.se.axis.com ([127.0.0.1]) by localhost (anubis.se.axis.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id qM-5HOXwKYom for ; Tue, 13 Nov 2012 07:16:53 +0100 (CET) Received: from seth.se.axis.com (seth.se.axis.com [10.0.2.172]) by anubis.se.axis.com (Postfix) with ESMTP id 580F519DE5 for ; Tue, 13 Nov 2012 07:16:53 +0100 (CET) Received: from ignucius.se.axis.com (ignucius.se.axis.com [10.88.21.50]) by seth.se.axis.com (Postfix) with ESMTP id 560D83E288; Tue, 13 Nov 2012 07:16:53 +0100 (CET) Received: from ignucius.se.axis.com (localhost [127.0.0.1]) by ignucius.se.axis.com (8.12.8p1/8.12.8/Debian-2woody1) with ESMTP id qAD6Gr3q018504; Tue, 13 Nov 2012 07:16:53 +0100 Received: (from hp@localhost) by ignucius.se.axis.com (8.12.8p1/8.12.8/Debian-2woody1) id qAD6GqXf018500; Tue, 13 Nov 2012 07:16:52 +0100 Date: Tue, 13 Nov 2012 07:16:52 +0100 Message-Id: <201211130616.qAD6GqXf018500@ignucius.se.axis.com> From: Hans-Peter Nilsson To: gcc-patches@gcc.gnu.org Subject: Committed: Fix PR55257: g++.dg/debug/dwarf2/non-virtual-thunk.C and heads-up target maintainers MIME-Version: 1.0 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org ...those of you who don't have the equivalent of the patch below in your ports, that is. You'll likely only notice through a slightly reduced debugging experience and g++.dg/debug/dwarf2/non-virtual-thunk.C failing. Yes, the docs should mention these functions need to be called IMHO obviously, but not by me not now maybe later. Tested cris-elf, committed. gcc: PR target/55257 * config/cris/cris.c (cris_asm_output_mi_thunk): Call final_start_function and final_end_function. brgds, H-P Index: gcc/config/cris/cris.c =================================================================== --- gcc/config/cris/cris.c (revision 192677) +++ gcc/config/cris/cris.c (working copy) @@ -2698,6 +2698,9 @@ cris_asm_output_mi_thunk (FILE *stream, HOST_WIDE_INT vcall_offset ATTRIBUTE_UNUSED, tree funcdecl) { + /* Make sure unwind info is emitted for the thunk if needed. */ + final_start_function (emit_barrier (), stream, 1); + if (delta > 0) fprintf (stream, "\tadd%s " HOST_WIDE_INT_PRINT_DEC ",$%s\n", ADDITIVE_SIZE_MODIFIER (delta), delta, @@ -2735,6 +2738,8 @@ cris_asm_output_mi_thunk (FILE *stream, if (TARGET_V32) fprintf (stream, "\tnop\n"); } + + final_end_function (); } /* Boilerplate emitted at start of file.