From patchwork Mon Nov 5 20:40:34 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jack Howarth X-Patchwork-Id: 197305 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 321F82C00B9 for ; Tue, 6 Nov 2012 07:40:46 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1352752846; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:User-Agent:Mailing-List:Precedence:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:Sender: Delivered-To; bh=9DK7c7Lk/fDNHuhnBQB6XQaYrE0=; b=ZBi5q5msAZk81qd XaayE4+wexGDzqoRoq0NNiueM6pDOQFRtRYR8XVDp6p3iRqI3KufIUSQPqZKs1dt zzSjeyfqsA5GVR2mNRo26pfiHpPA1DiwN1JzqnfBpnRaP3YkphCiH2C3TtgGrQ0J G6s56194+zvkqLG4TcVa4nK7aVbQ= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type:Content-Disposition:User-Agent:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=J1L/gGAIfI93+s+iSpmo3CYiUDMqUcHsNlxorrXJHOGNIgNprS95j6b+UsyA5B qC1x6ZmoL9jIf4h/kD6wAWcJQTRigOuuVVKSTB2wwgh36eO6oRPTSdUu0/eFjfG4 eFJdtDfWAf1Q8NB8mOAEkPhPHoblVL7Kcj3yP0Vf/Vrc8=; Received: (qmail 19186 invoked by alias); 5 Nov 2012 20:40:43 -0000 Received: (qmail 19177 invoked by uid 22791); 5 Nov 2012 20:40:42 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from bromo.med.uc.edu (HELO bromo.med.uc.edu) (129.137.3.146) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 05 Nov 2012 20:40:37 +0000 Received: from bromo.med.uc.edu (localhost.localdomain [127.0.0.1]) by bromo.med.uc.edu (Postfix) with ESMTP id E6DE0B004B; Mon, 5 Nov 2012 15:40:35 -0500 (EST) Received: (from howarth@localhost) by bromo.med.uc.edu (8.14.3/8.14.3/Submit) id qA5KeYJU004022; Mon, 5 Nov 2012 15:40:34 -0500 Date: Mon, 5 Nov 2012 15:40:34 -0500 From: Jack Howarth To: gcc-patches@gcc.gnu.org Cc: mikestump@comcast.net, iain@codesourcery.com, rth@redhat.com, jakub@redhat.com Subject: [PATCH] fix libgomp.c++/pr24455.C failures on darwin Message-ID: <20121105204034.GA4020@bromo.med.uc.edu> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Currently the following testcases are failing on x86_64-apple-darwin11/12... FAIL: libgomp.c++/pr24455.C -O0 (test for excess errors) WARNING: libgomp.c++/pr24455.C -O0 compilation failed to produce executable FAIL: libgomp.c++/pr24455.C -O1 (test for excess errors) WARNING: libgomp.c++/pr24455.C -O1 compilation failed to produce executable FAIL: libgomp.c++/pr24455.C -O2 (test for excess errors) WARNING: libgomp.c++/pr24455.C -O2 compilation failed to produce executable FAIL: libgomp.c++/pr24455.C -O3 -fomit-frame-pointer (test for excess errors) WARNING: libgomp.c++/pr24455.C -O3 -fomit-frame-pointer compilation failed to produce executable FAIL: libgomp.c++/pr24455.C -O3 -fomit-frame-pointer -funroll-loops (test for excess errors) WARNING: libgomp.c++/pr24455.C -O3 -fomit-frame-pointer -funroll-loops compilation failed to produce executable FAIL: libgomp.c++/pr24455.C -O3 -fomit-frame-pointer -funroll-all-loops -finline-functions (test for excess errors) WARNING: libgomp.c++/pr24455.C -O3 -fomit-frame-pointer -funroll-all-loops -finline-functions compilation failed to produce executable FAIL: libgomp.c++/pr24455.C -O3 -g (test for excess errors) WARNING: libgomp.c++/pr24455.C -O3 -g compilation failed to produce executable FAIL: libgomp.c++/pr24455.C -Os (test for excess errors) WARNING: libgomp.c++/pr24455.C -Os compilation failed to produce executable FAIL: libgomp.c++/tls-init1.C -O (test for excess errors) WARNING: libgomp.c++/tls-init1.C -O compilation failed to produce executable These can be fixed for darwin by passing -Wl,-undefined,dynamic_lookup on dg-options as has been recommended by the darwin linker maintainer. Note that this should work for Xcode 3.2.6 and Xcode 4.4.1 and later. Between Xcode 4.2 and 4.4.0, radr://10466868, "-undefined dynamic_lookup linker bug", broke weak symbol dynamic lookup in the linker. Tested on x86_64-apple-darwin12. Okay for gcc trunk? Jack libgomp/ 2012-11-05 Jack Howarth * testsuite/libgomp.c++/pr24455.C: Use -Wl,-undefined,dynamic_lookup on darwin. Index: libgomp/testsuite/libgomp.c++/pr24455.C =================================================================== --- libgomp/testsuite/libgomp.c++/pr24455.C (revision 193168) +++ libgomp/testsuite/libgomp.c++/pr24455.C (working copy) @@ -1,6 +1,7 @@ // { dg-do run } // { dg-additional-sources pr24455-1.C } // { dg-require-effective-target tls_runtime } +// { dg-options "-Wl,-undefined,dynamic_lookup" { target *-*-darwin* } } extern "C" void abort (void);