| Message ID | 20121102192411.GA623@ibm-tiger.the-meissners.org |
|---|---|
| State | New |
| Headers | show |
On Fri, Nov 2, 2012 at 3:24 PM, Michael Meissner <meissner@linux.vnet.ibm.com> wrote: > During development, I often times have powerpc in the name of the compiler. > This trips up several tests that want to make sure the various pow > optimizations are done and the pow function is not called, since "powerpc" is > in the compiler identification string. > > I committed the following patch as obvious, after doing build/compare. > > [gcc/testsuite] > 2012-11-02 Michael Meissner <meissner@linux.vnet.ibm.com> > > * gcc.target/powerpc/pr46728-1.c: Pass -fno-ident to eliminate > failures in case 'pow', such as 'powerpc' is used in the compiler > version name. > * gcc.target/powerpc/pr46728-2.c: Likewise. > * gcc.target/powerpc/pr46728-3.c: Likewise. > * gcc.target/powerpc/pr46728-4.c: Likewise. > * gcc.target/powerpc/pr46728-5.c: Likewise. > * gcc.target/powerpc/pr46728-7.c: Likewise. > * gcc.target/powerpc/pr46728-8.c: Likewise. > * gcc/testsuite/gcc.dg/pr46728-6.c: Likewise. I see similar failures on AIX, but I think that "powerpc" appears in other strings in XCOFF. But thanks for cleaning up these spurious failures in the testsuite. I want the testsuite failures to be meaningful and accurate. Thanks, David
Index: gcc/testsuite/gcc.target/powerpc/pr46728-3.c =================================================================== --- gcc/testsuite/gcc.target/powerpc/pr46728-3.c (revision 193095) +++ gcc/testsuite/gcc.target/powerpc/pr46728-3.c (working copy) @@ -1,5 +1,5 @@ /* { dg-do compile } */ -/* { dg-options "-O2 -ffast-math -fno-inline -fno-unroll-loops -lm -mpowerpc-gpopt" } */ +/* { dg-options "-O2 -ffast-math -fno-inline -fno-unroll-loops -lm -mpowerpc-gpopt -fno-ident" } */ #include <math.h> Index: gcc/testsuite/gcc.target/powerpc/pr46728-4.c =================================================================== --- gcc/testsuite/gcc.target/powerpc/pr46728-4.c (revision 193095) +++ gcc/testsuite/gcc.target/powerpc/pr46728-4.c (working copy) @@ -1,6 +1,6 @@ /* { dg-do compile } */ /* { dg-skip-if "No __builtin_cbrt" { powerpc*-*-darwin* } } */ -/* { dg-options "-O2 -ffast-math -fno-inline -fno-unroll-loops -lm -mpowerpc-gpopt" } */ +/* { dg-options "-O2 -ffast-math -fno-inline -fno-unroll-loops -lm -mpowerpc-gpopt -fno-ident" } */ #include <math.h> Index: gcc/testsuite/gcc.target/powerpc/pr46728-5.c =================================================================== --- gcc/testsuite/gcc.target/powerpc/pr46728-5.c (revision 193095) +++ gcc/testsuite/gcc.target/powerpc/pr46728-5.c (working copy) @@ -1,6 +1,6 @@ /* { dg-do compile } */ /* { dg-skip-if "No __builtin_cbrt" { powerpc*-*-darwin* } } */ -/* { dg-options "-O2 -ffast-math -fno-inline -fno-unroll-loops -lm -mpowerpc-gpopt" } */ +/* { dg-options "-O2 -ffast-math -fno-inline -fno-unroll-loops -lm -mpowerpc-gpopt -fno-ident" } */ #include <math.h> Index: gcc/testsuite/gcc.target/powerpc/pr46728-7.c =================================================================== --- gcc/testsuite/gcc.target/powerpc/pr46728-7.c (revision 193095) +++ gcc/testsuite/gcc.target/powerpc/pr46728-7.c (working copy) @@ -1,5 +1,5 @@ /* { dg-do compile } */ -/* { dg-options "-O2 -ffast-math -fno-inline -fno-unroll-loops -lm -mpowerpc-gpopt" } */ +/* { dg-options "-O2 -ffast-math -fno-inline -fno-unroll-loops -lm -mpowerpc-gpopt -fno-ident" } */ #include <math.h> Index: gcc/testsuite/gcc.target/powerpc/pr46728-8.c =================================================================== --- gcc/testsuite/gcc.target/powerpc/pr46728-8.c (revision 193095) +++ gcc/testsuite/gcc.target/powerpc/pr46728-8.c (working copy) @@ -1,6 +1,6 @@ /* { dg-do compile } */ /* { dg-skip-if "No __builtin_cbrt" { powerpc*-*-darwin* } } */ -/* { dg-options "-O2 -ffast-math -fno-inline -fno-unroll-loops -lm -mpowerpc-gpopt" } */ +/* { dg-options "-O2 -ffast-math -fno-inline -fno-unroll-loops -lm -mpowerpc-gpopt -fno-ident" } */ #include <math.h> Index: gcc/testsuite/gcc.target/powerpc/pr46728-1.c =================================================================== --- gcc/testsuite/gcc.target/powerpc/pr46728-1.c (revision 193095) +++ gcc/testsuite/gcc.target/powerpc/pr46728-1.c (working copy) @@ -1,5 +1,5 @@ /* { dg-do compile } */ -/* { dg-options "-O2 -ffast-math -fno-inline -fno-unroll-loops -lm -mpowerpc-gpopt" } */ +/* { dg-options "-O2 -ffast-math -fno-inline -fno-unroll-loops -lm -mpowerpc-gpopt -fno-ident" } */ #include <math.h> Index: gcc/testsuite/gcc.target/powerpc/pr46728-2.c =================================================================== --- gcc/testsuite/gcc.target/powerpc/pr46728-2.c (revision 193095) +++ gcc/testsuite/gcc.target/powerpc/pr46728-2.c (working copy) @@ -1,5 +1,5 @@ /* { dg-do compile } */ -/* { dg-options "-O2 -ffast-math -fno-inline -fno-unroll-loops -lm -mpowerpc-gpopt" } */ +/* { dg-options "-O2 -ffast-math -fno-inline -fno-unroll-loops -lm -mpowerpc-gpopt -fno-ident" } */ #include <math.h> Index: gcc/testsuite/gcc.dg/pr46728-6.c =================================================================== --- gcc/testsuite/gcc.dg/pr46728-6.c (revision 193095) +++ gcc/testsuite/gcc.dg/pr46728-6.c (working copy) @@ -1,5 +1,5 @@ /* { dg-do compile } */ -/* { dg-options "-O2 -ffast-math -lm" } */ +/* { dg-options "-O2 -ffast-math -lm -fno-ident" } */ #include <math.h>