From patchwork Tue Apr 17 18:40:08 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Teresa Johnson X-Patchwork-Id: 153270 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 3AD19B7047 for ; Wed, 18 Apr 2012 04:40:50 +1000 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1335292852; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Received:Received:Received:Received:To:Subject:Message-Id:Date: From:Mailing-List:Precedence:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:Sender:Delivered-To; bh=FgLN/UX 4fZDK3+PEHvkpYgnkBYQ=; b=O+nwm0884nGtbulIb81UwrU6YKjEq7Vb6XHBoBn zpKZNwpBYNihR8W2RCx9BiGShwzJr9SRKFIqedDnlo+4E8aVp/GXrOVc3vkSWUEE hojXuONupN+4KmrTqc7ohzQXi0FineE2trkHv5Mcl3o9xmuV+EH1UqKtOGckkTrF XlOc= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:X-Google-DKIM-Signature:Received:Received:Received:Received:Received:To:Subject:Message-Id:Date:From:X-Gm-Message-State:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=cH889Bfmwm9mHo1SsU3hq/S4JH8VV6ACmoPqtqi9l0zVj3Z5tPreCHax0P6V8J hZSaA0RmAjqkfSE8vmx6yVpZyRLuoepKHJV0rODNBfna9yL8iG9I/m6SlDWuoZ9l D6MFYJWAgpjeXInlUOpB5Rsl4+uLqpbdRM4+72k4EfggE=; Received: (qmail 18493 invoked by alias); 17 Apr 2012 18:40:43 -0000 Received: (qmail 18340 invoked by uid 22791); 17 Apr 2012 18:40:42 -0000 X-SWARE-Spam-Status: No, hits=-3.4 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, KHOP_RCVD_TRUST, RCVD_IN_DNSWL_LOW, RCVD_IN_HOSTKARMA_YE, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-vx0-f201.google.com (HELO mail-vx0-f201.google.com) (209.85.220.201) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 17 Apr 2012 18:40:10 +0000 Received: by vcqp1 with SMTP id p1so760681vcq.2 for ; Tue, 17 Apr 2012 11:40:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=to:subject:message-id:date:from:x-gm-message-state; bh=U8Xfy134F9KIUNEb+wpzHiCBF0xF+O4Vz391JBUHyHQ=; b=ZNmRsZBfPTk5oYiEQ/lC8jQJl9hoteUtGI3S1Gm/G5D7TLKGX6DUrFCLJA1Avq1gLv 0w7HPG6G76tNwZJ7wwaX/S7xHiqt8aca+4qLZtDJYxWSrnySM1GHDzxq7YZf4YMW9Po0 ERZHV09q3wcumbX8Q9agaeWxUo8b7qF35SKvwv8u9mASuODd+rQrPmapqGk0Vqw7jVBf 1pkVpRzaO1U/UfjkmRzbyTtlZzby6rUdPAWG9vVqFza9lSnkfSqx49m7lfHud5wxt2rp Tpvl+cCxYkafR8Qe8itWVtyRQzi05ss3MXaVfkc1NKqvGKJ30EmGp5TTxcYD4fyCl8MK fMzQ== Received: by 10.236.180.33 with SMTP id i21mr22324501yhm.1.1334688009190; Tue, 17 Apr 2012 11:40:09 -0700 (PDT) Received: by 10.236.180.33 with SMTP id i21mr22324485yhm.1.1334688009120; Tue, 17 Apr 2012 11:40:09 -0700 (PDT) Received: from wpzn3.hot.corp.google.com (216-239-44-65.google.com [216.239.44.65]) by gmr-mx.google.com with ESMTPS id r32si8589636ano.1.2012.04.17.11.40.09 (version=TLSv1/SSLv3 cipher=AES128-SHA); Tue, 17 Apr 2012 11:40:09 -0700 (PDT) Received: from tjsboxrox.mtv.corp.google.com (tjsboxrox.mtv.corp.google.com [172.18.110.68]) by wpzn3.hot.corp.google.com (Postfix) with ESMTP id 0840F10004D; Tue, 17 Apr 2012 11:40:09 -0700 (PDT) Received: by tjsboxrox.mtv.corp.google.com (Postfix, from userid 147431) id 7774261595; Tue, 17 Apr 2012 11:40:08 -0700 (PDT) To: reply@codereview.appspotmail.com,gcc-patches@gcc.gnu.org Subject: [google/google-main] Fix for unused variable warning in libgcov.c (issue6052049) Message-Id: <20120417184008.7774261595@tjsboxrox.mtv.corp.google.com> Date: Tue, 17 Apr 2012 11:40:08 -0700 (PDT) From: tejohnson@google.com (Teresa Johnson) X-Gm-Message-State: ALoCoQkGURipI0WCiHHaJ7QsURJlA6bMajpr/2krnDw1dErES9EobKW6eR5SAc/8x8p4i20U9+K3JEE195sPbfr4+0ikMC/zLsHkpiG8EQ1WRHkxVoPN5TCq/oWcAHfe/A4Cvv2gASpZBeCoNG9qTpzKwGFdntBpXe3Mujxn35KJMQ2Ag6xF6Aw= X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org I have a patch to fix a compile time warning about an unused variable due to the use being guarded by #ifndef __GCOV_KERNEL__. Tested with bootstrap. Ok for google-main? Teresa 2012-04-17 Teresa Johnson Google ref b/5910724. * libgcc/libgcov.c (gcov_cur_module_id): Guard definition under #ifndef __GCOV_KERNEL__. --- This patch is available for review at http://codereview.appspot.com/6052049 Index: libgcov.c =================================================================== --- libgcov.c (revision 186282) +++ libgcov.c (working copy) @@ -153,10 +153,10 @@ static gcov_unsigned_t gcov_crc32; /* Size of the longest file name. */ static size_t gcov_max_filename = 0; -#endif /* __GCOV_KERNEL__ */ /* Unique identifier assigned to each module (object file). */ static gcov_unsigned_t gcov_cur_module_id = 0; +#endif /* __GCOV_KERNEL__ */ /* Pointer to the direct-call counters (per call-site counters). Initialized by the caller. */