From patchwork Mon Mar 12 17:19:34 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthew Gretton-Dann X-Patchwork-Id: 146185 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 607F3B703B for ; Tue, 13 Mar 2012 04:19:59 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1332177600; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Date:From:To:Cc:Subject:Message-ID:Mail-Followup-To:MIME-Version: User-Agent:Content-Type:Content-Disposition:Mailing-List: Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:Sender:Delivered-To; bh=uW0Zh1JPSMVJ3GzEJOb0zwnR74g=; b=XqViGv79NIGkmtRZL6qYLG40ScAU+VKvTnVaq55aChgUmuJWg+WrlQEmkpBTjl 4GzOAVpEJp9M7e5MR/B7YAFRfRFDwfzakGSkGHApS9xLwCIMIIAYryTBItfPaoCf MlWj6Zp0E3qaVgPAD40AaWAbG2ywCaBkBiAGdG7jr+pfI= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:Date:From:To:Cc:Subject:Message-ID:Mail-Followup-To:MIME-Version:User-Agent:X-MC-Unique:Content-Type:Content-Disposition:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=PL+i6vu+3hlBTABpEng4uzL7bMP0ZDj+PS+TYYEeNB3GpaVWQxFPkJXOB/SFyp t/7eiJW8gVn4LJEP5Nh+j/9MI01639ddv3SgpX6Owfa1r8mOQiuG5Fe/Q8bDAK9c a0760dTwlyO2KbkQeF/qL3vy+7aVQOXFVteqglCEZJR/k=; Received: (qmail 7642 invoked by alias); 12 Mar 2012 17:19:56 -0000 Received: (qmail 7634 invoked by uid 22791); 12 Mar 2012 17:19:55 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from service87.mimecast.com (HELO service87.mimecast.com) (91.220.42.44) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 12 Mar 2012 17:19:41 +0000 Received: from cam-owa2.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Mon, 12 Mar 2012 17:19:39 +0000 Received: from e103070-lin.arm.com ([10.1.255.212]) by cam-owa2.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Mon, 12 Mar 2012 17:20:13 +0000 Date: Mon, 12 Mar 2012 17:19:34 +0000 From: Matthew Gretton-Dann To: GCC-Patches Cc: Richard Earnshaw , Ramana Radhakrishnan , jakub@redhat.com, joseph@codesourcery.com, rguenther@suse.de Subject: [RFA/ARM]: Correct Neon testsuite generation Message-ID: <20120312171934.GE7462@e103070-lin.arm.com> Mail-Followup-To: GCC-Patches , Richard Earnshaw , Ramana Radhakrishnan , jakub@redhat.com, joseph@codesourcery.com, rguenther@suse.de MIME-Version: 1.0 User-Agent: Mutt/1.5.20 (2009-06-14) X-MC-Unique: 112031217193901001 Content-Disposition: inline X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org All, The commit to fix PR51534 did not update the testsuite (as no changes were expected there). Unfortunately, this means that I didn't notice that the Neon testsuite generator is broken. The attached patch fixes the generator. Checked by re-running the Neon testsuite and arm_neon.h generators and ensuring no changes in the generated testsuite/header. OK for trunk? OK for backporting to GCC 4.7? Thanks, Matt gcc/ChangeLog: 2012-03-12 Matthew Gretton-Dann * config/arm/neon.ml (ops): Fixup expected instructions for unsigned vector compares. diff --git a/gcc/config/arm/neon.ml b/gcc/config/arm/neon.ml index 363e55c..85eb5ec 100644 --- a/gcc/config/arm/neon.ml +++ b/gcc/config/arm/neon.ml @@ -780,14 +780,19 @@ let ops = (* Comparison, greater-than or equal. *) Vcge, [], All (3, Dreg), "vcge", cmp_sign_matters, F32 :: s_8_32; - Vcge, [Builtin_name "vcgeu"], All (3, Dreg), "vcge", cmp_sign_matters, u_8_32; + Vcge, [Instruction_name ["vcge"]; Builtin_name "vcgeu"], + All (3, Dreg), "vcge", cmp_sign_matters, + u_8_32; Vcge, [], All (3, Qreg), "vcgeQ", cmp_sign_matters, F32 :: s_8_32; - Vcge, [Builtin_name "vcgeu"], All (3, Qreg), "vcgeQ", cmp_sign_matters, u_8_32; + Vcge, [Instruction_name ["vcge"]; Builtin_name "vcgeu"], + All (3, Qreg), "vcgeQ", cmp_sign_matters, + u_8_32; (* Comparison, less-than or equal. *) Vcle, [Flipped "vcge"], All (3, Dreg), "vcle", cmp_sign_matters, F32 :: s_8_32; - Vcle, [Flipped "vcgeu"], All (3, Dreg), "vcle", cmp_sign_matters, + Vcle, [Instruction_name ["vcge"]; Flipped "vcgeu"], + All (3, Dreg), "vcle", cmp_sign_matters, u_8_32; Vcle, [Instruction_name ["vcge"]; Flipped "vcgeQ"], All (3, Qreg), "vcleQ", cmp_sign_matters, @@ -798,14 +803,19 @@ let ops = (* Comparison, greater-than. *) Vcgt, [], All (3, Dreg), "vcgt", cmp_sign_matters, F32 :: s_8_32; - Vcgt, [Builtin_name "vcgtu"], All (3, Dreg), "vcgt", cmp_sign_matters, u_8_32; + Vcgt, [Instruction_name ["vcgt"]; Builtin_name "vcgtu"], + All (3, Dreg), "vcgt", cmp_sign_matters, + u_8_32; Vcgt, [], All (3, Qreg), "vcgtQ", cmp_sign_matters, F32 :: s_8_32; - Vcgt, [Builtin_name "vcgtu"], All (3, Qreg), "vcgtQ", cmp_sign_matters, u_8_32; + Vcgt, [Instruction_name ["vcgt"]; Builtin_name "vcgtu"], + All (3, Qreg), "vcgtQ", cmp_sign_matters, + u_8_32; (* Comparison, less-than. *) Vclt, [Flipped "vcgt"], All (3, Dreg), "vclt", cmp_sign_matters, F32 :: s_8_32; - Vclt, [Flipped "vcgtu"], All (3, Dreg), "vclt", cmp_sign_matters, + Vclt, [Instruction_name ["vcgt"]; Flipped "vcgtu"], + All (3, Dreg), "vclt", cmp_sign_matters, u_8_32; Vclt, [Instruction_name ["vcgt"]; Flipped "vcgtQ"], All (3, Qreg), "vcltQ", cmp_sign_matters,