From patchwork Sun Nov 20 20:04:49 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans-Peter Nilsson X-Patchwork-Id: 126662 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 7D77AB721E for ; Mon, 21 Nov 2011 07:05:25 +1100 (EST) Received: (qmail 19296 invoked by alias); 20 Nov 2011 20:05:14 -0000 Received: (qmail 19280 invoked by uid 22791); 20 Nov 2011 20:05:11 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from anubis.se.axis.com (HELO anubis.se.axis.com) (195.60.68.12) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 20 Nov 2011 20:04:55 +0000 Received: from localhost (localhost [127.0.0.1]) by anubis.se.axis.com (Postfix) with ESMTP id 5ACFE19D90; Sun, 20 Nov 2011 21:04:52 +0100 (CET) Received: from anubis.se.axis.com ([127.0.0.1]) by localhost (anubis.se.axis.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Fri6pnSlk3EH; Sun, 20 Nov 2011 21:04:51 +0100 (CET) Received: from thoth.se.axis.com (thoth.se.axis.com [10.0.2.173]) by anubis.se.axis.com (Postfix) with ESMTP id 39A0419D87; Sun, 20 Nov 2011 21:04:51 +0100 (CET) Received: from ignucius.se.axis.com (ignucius.se.axis.com [10.88.21.50]) by thoth.se.axis.com (Postfix) with ESMTP id 084C7340C2; Sun, 20 Nov 2011 21:04:51 +0100 (CET) Received: from ignucius.se.axis.com (localhost [127.0.0.1]) by ignucius.se.axis.com (8.12.8p1/8.12.8/Debian-2woody1) with ESMTP id pAKK4oF6003176; Sun, 20 Nov 2011 21:04:50 +0100 Received: (from hp@localhost) by ignucius.se.axis.com (8.12.8p1/8.12.8/Debian-2woody1) id pAKK4npJ003172; Sun, 20 Nov 2011 21:04:49 +0100 Date: Sun, 20 Nov 2011 21:04:49 +0100 Message-Id: <201111202004.pAKK4npJ003172@ignucius.se.axis.com> From: Hans-Peter Nilsson To: ebotcazou@adacore.com CC: gcc-patches@gcc.gnu.org, sje@cup.hp.com, matz@suse.de In-reply-to: <201111201303.23117.ebotcazou@adacore.com> (message from Eric Botcazou on Sun, 20 Nov 2011 13:03:22 +0100) Subject: Re: Massive EH regressions after "[patch, ia64, libgcc] Patch to fix libunwind build on IA64" MIME-Version: 1.0 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org > From: Eric Botcazou > Date: Sun, 20 Nov 2011 13:03:22 +0100 > You may need something like: > > 2011-06-21 Rainer Orth > > * shared-object.mk (c_flags-$o): Save c_flags. > ($(base)$(objext)): Use it. > ($(base)_s$(objext)): Likewise. > > for static-object.mk. Thanks, I can almost not believe I didn't see that. Well ok, I saw it but misinterpreted it. Perhaps I can blame the lack of an explanatory comment just a little bit: it looks somewhat like a failed attempt at supporting source-specific compilation options. I'm going to commit the following as obvious after verifying that it fixes the regressions and doesn't cause any. libgcc: 2011-11-20 Hans-Peter Nilsson * shared-object.mk (c_flags-$o): Save c_flags. ($(base)$(objext)): Use it. brgds, H-P Index: static-object.mk =================================================================== --- static-object.mk (revision 181531) +++ static-object.mk (working copy) @@ -6,10 +6,15 @@ iter-items := $(filter-out $o,$(iter-ite base := $(basename $(notdir $o)) +# Copy c_flags to a rule-specific copy and use the copy, to avoid the +# following rules being affected by later changes to c_flags in the +# including file. +c_flags-$o := $(c_flags) + ifeq ($(suffix $o),.c) $(base)$(objext): $o - $(gcc_compile) $(c_flags) -c $< $(vis_hide) + $(gcc_compile) $(c_flags-$<) -c $< $(vis_hide) else