From patchwork Sun Oct 30 22:25:16 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Diego Novillo X-Patchwork-Id: 122690 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id C59E2B6F76 for ; Mon, 31 Oct 2011 09:25:36 +1100 (EST) Received: (qmail 12982 invoked by alias); 30 Oct 2011 22:25:34 -0000 Received: (qmail 12966 invoked by uid 22791); 30 Oct 2011 22:25:34 -0000 X-SWARE-Spam-Status: No, hits=-2.7 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RP_MATCHES_RCVD, SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.67) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 30 Oct 2011 22:25:20 +0000 Received: from wpaz29.hot.corp.google.com (wpaz29.hot.corp.google.com [172.24.198.93]) by smtp-out.google.com with ESMTP id p9UMPIC1017813; Sun, 30 Oct 2011 15:25:18 -0700 Received: from topo.tor.corp.google.com (topo.tor.corp.google.com [172.29.41.2]) by wpaz29.hot.corp.google.com with ESMTP id p9UMPHfq022874; Sun, 30 Oct 2011 15:25:17 -0700 Received: by topo.tor.corp.google.com (Postfix, from userid 54752) id EBB901DA196; Sun, 30 Oct 2011 18:25:16 -0400 (EDT) To: reply@codereview.appspotmail.com, rguenther@suse.de, gcc-patches@gcc.gnu.org Subject: [lto] Also stream TYPE_ADDR_SPACE. (issue5308067) Message-Id: <20111030222516.EBB901DA196@topo.tor.corp.google.com> Date: Sun, 30 Oct 2011 18:25:16 -0400 (EDT) From: dnovillo@google.com (Diego Novillo) X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org I found this on the PPH branch. We were not handling TYPE_ADDR_SPACE in the streamer. Fixed with this patch. Richi, I will apply it on trunk unless you remember some reason why we never streamed this? It does not seem to affect any LTO tests. Tested with lto profiledbootstrap on x86_64. Diego. * tree-streamer-out.c (pack_ts_base_value_fields): Emit TYPE_ADDR_SPACE. * tree-streamer-in.c (unpack_ts_base_value_fields): Read TYPE_ADDR_SPACE. diff --git a/gcc/tree-streamer-in.c b/gcc/tree-streamer-in.c index db2bb37..86eb9ce 100644 --- a/gcc/tree-streamer-in.c +++ b/gcc/tree-streamer-in.c @@ -130,7 +130,10 @@ unpack_ts_base_value_fields (struct bitpack_d *bp, tree expr) TREE_PROTECTED (expr) = (unsigned) bp_unpack_value (bp, 1); TREE_DEPRECATED (expr) = (unsigned) bp_unpack_value (bp, 1); if (TYPE_P (expr)) - TYPE_SATURATING (expr) = (unsigned) bp_unpack_value (bp, 1); + { + TYPE_SATURATING (expr) = (unsigned) bp_unpack_value (bp, 1); + TYPE_ADDR_SPACE (expr) = (unsigned) bp_unpack_value (bp, 8); + } else if (TREE_CODE (expr) == SSA_NAME) SSA_NAME_IS_DEFAULT_DEF (expr) = (unsigned) bp_unpack_value (bp, 1); else diff --git a/gcc/tree-streamer-out.c b/gcc/tree-streamer-out.c index 58be0a3..c46859f 100644 --- a/gcc/tree-streamer-out.c +++ b/gcc/tree-streamer-out.c @@ -100,7 +100,10 @@ pack_ts_base_value_fields (struct bitpack_d *bp, tree expr) bp_pack_value (bp, TREE_PROTECTED (expr), 1); bp_pack_value (bp, TREE_DEPRECATED (expr), 1); if (TYPE_P (expr)) - bp_pack_value (bp, TYPE_SATURATING (expr), 1); + { + bp_pack_value (bp, TYPE_SATURATING (expr), 1); + bp_pack_value (bp, TYPE_ADDR_SPACE (expr), 8); + } else if (TREE_CODE (expr) == SSA_NAME) bp_pack_value (bp, SSA_NAME_IS_DEFAULT_DEF (expr), 1); else