From patchwork Mon Oct 3 15:24:48 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Diego Novillo X-Patchwork-Id: 117460 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 0D5EDB6F18 for ; Tue, 4 Oct 2011 02:25:15 +1100 (EST) Received: (qmail 5680 invoked by alias); 3 Oct 2011 15:25:11 -0000 Received: (qmail 5663 invoked by uid 22791); 3 Oct 2011 15:25:10 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RP_MATCHES_RCVD, SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.44.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 03 Oct 2011 15:24:52 +0000 Received: from hpaq5.eem.corp.google.com (hpaq5.eem.corp.google.com [172.25.149.5]) by smtp-out.google.com with ESMTP id p93FOoLS006505; Mon, 3 Oct 2011 08:24:51 -0700 Received: from topo.tor.corp.google.com (topo.tor.corp.google.com [172.29.41.2]) by hpaq5.eem.corp.google.com with ESMTP id p93FOmCp003488; Mon, 3 Oct 2011 08:24:49 -0700 Received: by topo.tor.corp.google.com (Postfix, from userid 54752) id 937471DA1C2; Mon, 3 Oct 2011 11:24:48 -0400 (EDT) To: reply@codereview.appspotmail.com, crowl@google.com, gcc-patches@gcc.gnu.org Subject: [pph] Detect state mutation in DECLs/TYPEs [5/8] (issue5178044) Message-Id: <20111003152448.937471DA1C2@topo.tor.corp.google.com> Date: Mon, 3 Oct 2011 11:24:48 -0400 (EDT) From: dnovillo@google.com (Diego Novillo) X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Fixlet to update documentation for pph_cache_insert_at. Diego. * pph-streamer.c (pph_cache_insert_at): Fix documentation. diff --git a/gcc/cp/pph-streamer.c b/gcc/cp/pph-streamer.c index d0fac57..26bc6cd 100644 --- a/gcc/cp/pph-streamer.c +++ b/gcc/cp/pph-streamer.c @@ -402,11 +402,9 @@ pph_trace_bitpack (pph_stream *stream, struct bitpack_d *bp) } -/* Insert DATA in CACHE at slot IX. We support inserting the same - DATA at different locations of the array (FIXME pph, this happens - when reading builtins, which may have been converted into builtins - after they were read originally. This should be detected and - converted into mutated references). */ +/* Insert DATA in CACHE at slot IX. As a restriction to prevent + stomping on cache entries, this will not allow inserting + into the same slot more than once. */ void pph_cache_insert_at (pph_cache *cache, void *data, unsigned ix)