diff mbox

PATCH: PR rtl-optimization/49504: Invalid optimization for Pmode != ptr_mode

Message ID 20110623131407.GA17824@intel.com
State New
Headers show

Commit Message

H.J. Lu June 23, 2011, 1:14 p.m. UTC 
On Wed, Jun 22, 2011 at 12:36:57PM -0700, H.J. Lu wrote:
> Hi,
> 
> I just don't see how nonzero_bits1 can assume if pointers extend unsigned
> and this is an addition or subtraction to a pointer in Pmode, all the bits
> bove ptr_mode are known to be zero.  We never run into it before x32
> since x32 is the first such target.
> 
> This patch deletes it.  OK to install the nonzero_bits1 part for trunk?
> 
> Thanks.
> 
> 

I checked this patch into x32 branch.

H.J.
---
commit de145b6ad18327c34009d96f1a1f0a9510023f31
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Thu Jun 23 06:09:20 2011 -0700

    Check correct return value.
diff mbox

Patch

diff --git a/gcc/testsuite/ChangeLog.x32 b/gcc/testsuite/ChangeLog.x32
index 6581a45..cde8d41 100644
--- a/gcc/testsuite/ChangeLog.x32
+++ b/gcc/testsuite/ChangeLog.x32
@@ -1,3 +1,7 @@ 
+2011-06-23  H.J. Lu  <hongjiu.lu@intel.com>
+
+	* gcc.target/i386/pr49504.c (main): Check correct return value.
+
 2011-06-22  H.J. Lu  <hongjiu.lu@intel.com>
 
 	PR rtl-optimization/49504
diff --git a/gcc/testsuite/gcc.target/i386/pr49504.c b/gcc/testsuite/gcc.target/i386/pr49504.c
index 9128196..503e6c2 100644
--- a/gcc/testsuite/gcc.target/i386/pr49504.c
+++ b/gcc/testsuite/gcc.target/i386/pr49504.c
@@ -12,7 +12,7 @@  foo (const void* p, unsigned long long q)
 int
 main ()
 {
-  if (foo ((const void*) 0x100, 0x100000000ULL) == 0)
+  if (foo (foo, 0x100000000ULL) != 0x1)
     __builtin_abort ();
   return 0;
 }