From patchwork Tue Jan 25 13:14:12 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jakub Jelinek X-Patchwork-Id: 80355 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 3B275B70EC for ; Wed, 26 Jan 2011 00:14:39 +1100 (EST) Received: (qmail 17012 invoked by alias); 25 Jan 2011 13:14:35 -0000 Received: (qmail 16944 invoked by uid 22791); 25 Jan 2011 13:14:34 -0000 X-SWARE-Spam-Status: No, hits=-6.4 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_HI, SPF_HELO_PASS, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 25 Jan 2011 13:14:30 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id p0PDEGvV025647 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 25 Jan 2011 08:14:16 -0500 Received: from tyan-ft48-01.lab.bos.redhat.com (tyan-ft48-01.lab.bos.redhat.com [10.16.42.4]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p0PDEFom017502 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 25 Jan 2011 08:14:16 -0500 Received: from tyan-ft48-01.lab.bos.redhat.com (localhost.localdomain [127.0.0.1]) by tyan-ft48-01.lab.bos.redhat.com (8.14.4/8.14.4) with ESMTP id p0PDEE5Y025133; Tue, 25 Jan 2011 14:14:14 +0100 Received: (from jakub@localhost) by tyan-ft48-01.lab.bos.redhat.com (8.14.4/8.14.4/Submit) id p0PDED2t025023; Tue, 25 Jan 2011 14:14:13 +0100 Date: Tue, 25 Jan 2011 14:14:12 +0100 From: Jakub Jelinek To: Sebastian Pop Cc: Eric Botcazou , gcc-patches@gcc.gnu.org, gcc-graphite@googlegroups.com Subject: Re: [PATCH] Fail when PPL 0.11 is not present and CLooG has been requested. Message-ID: <20110125131411.GY2724@tyan-ft48-01.lab.bos.redhat.com> Reply-To: Jakub Jelinek References: <1295377990-18603-1-git-send-email-sebpop@gmail.com> <201101250858.15402.ebotcazou@adacore.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On Tue, Jan 25, 2011 at 05:04:37AM -0800, H.J. Lu wrote: > On Tue, Jan 25, 2011 at 5:02 AM, H.J. Lu wrote: > > On Mon, Jan 24, 2011 at 11:58 PM, Eric Botcazou wrote: > >>> 2011-01-18  Sebastian Pop   > >>> > >>>       * configure.ac: Call AC_MSG_ERROR when PPL 0.11 is not present and > >>>       CLooG has been requested. > >>>       * configure: Regenerated. > >> > >> configure fails unconditionally on the mainline: > >> > >> checking for version 0.11 (or later revision) of PPL... no > >> configure: error: Unable to find a usable PPL.  See config.log for details. > >> > > > > http://gcc.gnu.org/install/prerequisites.html > > > > still says "CLooG-PPL version 0.15". > > I meant "Parma Polyhedra Library (PPL) version 0.10". I think something like: && test "x${with_cloog_lib}" = x && test -d ${srcdir}/cloog; then could fix this (CLOOG_REQUESTED checks if with_cloog* is empty, but --without-cloog shouldn't certainly be considered to be requesting graphite and the unconditional setting of with_cloog=no before the check makes it unconditional. That said, I'm quite unhappy about the new PPL version requirement, was it really necessary at this point in 4.6 development (also the cloog-ppl requirement)? It will cause quite a lot of hassles to many of the distributions. Jakub --- configure.ac 2011-01-25 12:58:42.145421312 +0100 +++ configure.ac 2011-01-25 14:10:47.473670333 +0100 @@ -1688,13 +1688,12 @@ dnl Provide configure switches and initi dnl with user input. CLOOG_INIT_FLAGS if test "x$with_ppl" = "xno"; then - with_cloog=no - dnl Only execute fail-action, if CLooG has been requested. CLOOG_REQUESTED([graphite_requested=yes], [graphite_requested=no]) - if test "${graphite_requested}" = yes; then + if test "${graphite_requested}" = yes -a "x${with_cloog}" != xno; then AC_MSG_ERROR([Unable to find a usable PPL. See config.log for details.])] fi + with_cloog=no fi if test "x${with_cloog}" = x && test "x${with_cloog_include}" = x \