From patchwork Wed Oct 6 23:05:45 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans-Peter Nilsson X-Patchwork-Id: 66985 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id C526BB6EEA for ; Thu, 7 Oct 2010 10:07:23 +1100 (EST) Received: (qmail 8728 invoked by alias); 6 Oct 2010 23:07:18 -0000 Received: (qmail 8709 invoked by uid 22791); 6 Oct 2010 23:07:17 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL, BAYES_00, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from anubis.se.axis.com (HELO anubis.se.axis.com) (195.60.68.12) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 06 Oct 2010 23:07:12 +0000 Received: from localhost (localhost [127.0.0.1]) by anubis.se.axis.com (Postfix) with ESMTP id C80C919D1C; Thu, 7 Oct 2010 01:07:08 +0200 (CEST) Received: from anubis.se.axis.com ([127.0.0.1]) by localhost (anubis.se.axis.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 442649ZD7U+6; Thu, 7 Oct 2010 01:07:07 +0200 (CEST) Received: from krynn.se.axis.com (krynn.se.axis.com [10.0.2.170]) by anubis.se.axis.com (Postfix) with ESMTPS id D579119D21; Thu, 7 Oct 2010 01:07:06 +0200 (CEST) Received: from ignucius.se.axis.com (ignucius.se.axis.com [10.88.21.50]) by krynn.se.axis.com (8.14.3/8.14.3/Debian-5+lenny1) with ESMTP id o96N5jtF010679; Thu, 7 Oct 2010 01:05:45 +0200 Received: from ignucius.se.axis.com (localhost [127.0.0.1]) by ignucius.se.axis.com (8.12.8p1/8.12.8/Debian-2woody1) with ESMTP id o96N5jF6024843; Thu, 7 Oct 2010 01:05:45 +0200 Received: (from hp@localhost) by ignucius.se.axis.com (8.12.8p1/8.12.8/Debian-2woody1) id o96N5jcD024839; Thu, 7 Oct 2010 01:05:45 +0200 Date: Thu, 7 Oct 2010 01:05:45 +0200 Message-Id: <201010062305.o96N5jcD024839@ignucius.se.axis.com> From: Hans-Peter Nilsson To: paolo.carlini@oracle.com CC: hp@axis.com, gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org, rdsandiford@googlemail.com, nathan@codesourcery.com In-reply-to: <4CAC4594.7090302@oracle.com> (message from Paolo Carlini on Wed, 06 Oct 2010 11:47:00 +0200) Subject: Re: [RFA:] Stricter libstdc++ testsuite gate for working target file I/O MIME-Version: 1.0 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org > Date: Wed, 06 Oct 2010 11:47:00 +0200 > From: Paolo Carlini > The approach makes sense, in general. My only doubt I take that as approval for the patch for the gate function! > is that I don't > think we want to add the gate to a large part of the test files in > 27_io/basic_filebuf, essentially. grep says that 105 of them have it, 110 lack it. So, maybe better eliminate the need for the gate in that subtree. > Can't we skip the entire set at once, > like we do for wchar_t or thread testcases, and leave the gate for those > specific tests which are really sensitive to an lseek fully functional? I think I see what you mean, hacking conformance.exp and filter by filename. As below, looking for the "_filebuf" substring perhaps? The base filenames themselves are rarely revealing enough and most tests in */*_filebuf seem to need it. Half the files in 27_io/basic_filebuf already have the // { dg-require-fileio "" } gate; I'm not completely sure how many of those without would actually need the gate, but of those that I checked, 9/10 seem to need it. A bit too many, so I appreciate been given an easy way out. :) Tested in trees with/without a working simulator (together with the gate-function-patch), observing the right choice taken. Ok? libstdc++-v3: * testsuite/libstdc++-dg/conformance.exp: Apply check_v3_target_fileio as a gate for tests in subdirectories matching the substring _filebuf. brgds, H-P --- libstdc++-v3/testsuite/libstdc++-dg/conformance.exp.orig Mon Oct 5 21:02:02 2009 +++ libstdc++-v3/testsuite/libstdc++-dg/conformance.exp Thu Oct 7 00:13:50 2010 @@ -1,6 +1,6 @@ # Functional and regression tests in C++ for libstdc++. -# Copyright (C) 2001, 2002, 2003, 2004, 2009 Free Software Foundation, Inc. +# Copyright (C) 2001, 2002, 2003, 2004, 2009, 2010 Free Software Foundation, Inc. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -83,10 +83,13 @@ if {[info exists tests_file] && [file ex # 2. performance tests. # 3. wchar_t tests, if not supported. # 4. thread tests, if not supported. + # 5. *_filebuf, if file I/O is not supported. if { [string first _xin $t] == -1 && [string first performance $t] == -1 && (${v3-wchar_t} || [string first wchar_t $t] == -1) - && (${v3-threads} || [string first thread $t] == -1) } { + && (${v3-threads} || [string first thread $t] == -1) + && ([string first "_filebuf" $t] == -1 + || [check_v3_target_fileio]) } { lappend tests $t } }