From patchwork Mon Aug 16 20:53:39 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ralf Wildenhues X-Patchwork-Id: 61840 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id B2D71B6F01 for ; Tue, 17 Aug 2010 06:53:51 +1000 (EST) Received: (qmail 17693 invoked by alias); 16 Aug 2010 20:53:50 -0000 Received: (qmail 17673 invoked by uid 22791); 16 Aug 2010 20:53:49 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: sourceware.org Received: from mailout-de.gmx.net (HELO mail.gmx.net) (213.165.64.23) by sourceware.org (qpsmtpd/0.43rc1) with SMTP; Mon, 16 Aug 2010 20:53:42 +0000 Received: (qmail invoked by alias); 16 Aug 2010 20:53:39 -0000 Received: from xdsl-89-0-141-29.netcologne.de (EHLO localhost.localdomain) [89.0.141.29] by mail.gmx.net (mp059) with SMTP; 16 Aug 2010 22:53:39 +0200 Received: from ralf by localhost.localdomain with local (Exim 4.69) (envelope-from ) id 1Ol6gd-0003ua-Be; Mon, 16 Aug 2010 22:53:39 +0200 Date: Mon, 16 Aug 2010 22:53:39 +0200 From: Ralf Wildenhues To: gcc-patches@gcc.gnu.org, bonzini@gnu.org, rguenther@suse.de Subject: [PATCH] PR 45084: Fix misquoting in stdint.m4. Message-ID: <20100816205339.GE8188@gmx.de> Mail-Followup-To: Ralf Wildenhues , gcc-patches@gcc.gnu.org, bonzini@gnu.org, rguenther@suse.de MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.20 (2010-04-22) X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45084 shows a fairly weird GCC build error message. The weirdness stems from underquoted M4 macro arguments containing comma. The patch is obvious (to me, at least). OK to apply and sync to src (where bfd/configure needs regenerating for this, too)? What about backports? The bug is present in some form in all active branches. FYI, the expanded code changes like this: | $as_echo_n "checking for type equivalent to int8_t... " >&6; } | case "$ac_cv_sizeof_char" in | 1) acx_cv_type_int8_t=char ;; | - *) { as_fn_set_status please report a bug | -as_fn_error "no 8-bit type" "$LINENO" 5; } | + *) as_fn_error "no 8-bit type, please report a bug" "$LINENO" 5 | esac Thanks, Ralf ChangeLog entries for GCC: Fix misquoting in stdint.m4. config/ChangeLog: 2010-08-16 Ralf Wildenhues PR target/45084 * stdint.m4 (GCC_HEADER_STDINT): Use m4 quotes for arguments of AC_MSG_ERROR. libdecnumber/ChangeLog: 2010-08-16 Ralf Wildenhues * configure: Regenerate. libgfortran/ChangeLog: 2010-08-16 Ralf Wildenhues * configure: Regenerate. libgomp/ChangeLog: 2010-08-16 Ralf Wildenhues * configure: Regenerate. libstdc++-v3/ChangeLog: 2010-08-16 Ralf Wildenhues * configure: Regenerate. diff --git a/config/stdint.m4 b/config/stdint.m4 index d63081d..fbdd586 100644 --- a/config/stdint.m4 +++ b/config/stdint.m4 @@ -146,7 +146,7 @@ if test $acx_cv_header_stdint = stddef.h; then AC_MSG_CHECKING(for type equivalent to int8_t) case "$ac_cv_sizeof_char" in 1) acx_cv_type_int8_t=char ;; - *) AC_MSG_ERROR(no 8-bit type, please report a bug) + *) AC_MSG_ERROR([no 8-bit type, please report a bug]) esac AC_MSG_RESULT($acx_cv_type_int8_t) @@ -154,7 +154,7 @@ if test $acx_cv_header_stdint = stddef.h; then case "$ac_cv_sizeof_int:$ac_cv_sizeof_short" in 2:*) acx_cv_type_int16_t=int ;; *:2) acx_cv_type_int16_t=short ;; - *) AC_MSG_ERROR(no 16-bit type, please report a bug) + *) AC_MSG_ERROR([no 16-bit type, please report a bug]) esac AC_MSG_RESULT($acx_cv_type_int16_t) @@ -162,7 +162,7 @@ if test $acx_cv_header_stdint = stddef.h; then case "$ac_cv_sizeof_int:$ac_cv_sizeof_long" in 4:*) acx_cv_type_int32_t=int ;; *:4) acx_cv_type_int32_t=long ;; - *) AC_MSG_ERROR(no 32-bit type, please report a bug) + *) AC_MSG_ERROR([no 32-bit type, please report a bug]) esac AC_MSG_RESULT($acx_cv_type_int32_t) fi @@ -185,7 +185,7 @@ if test "$ac_cv_type_uintptr_t" != yes; then 2) acx_cv_type_intptr_t=int16_t ;; 4) acx_cv_type_intptr_t=int32_t ;; 8) acx_cv_type_intptr_t=int64_t ;; - *) AC_MSG_ERROR(no equivalent for intptr_t, please report a bug) + *) AC_MSG_ERROR([no equivalent for intptr_t, please report a bug]) esac AC_MSG_RESULT($acx_cv_type_intptr_t) fi