From patchwork Thu Jul 29 20:20:53 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jakub Jelinek X-Patchwork-Id: 60312 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id BA659B70BC for ; Fri, 30 Jul 2010 06:18:31 +1000 (EST) Received: (qmail 4020 invoked by alias); 29 Jul 2010 20:18:29 -0000 Received: (qmail 4012 invoked by uid 22791); 29 Jul 2010 20:18:29 -0000 X-SWARE-Spam-Status: No, hits=-6.1 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_HI, SPF_HELO_PASS, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 29 Jul 2010 20:18:25 +0000 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o6TKINFc015135 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 29 Jul 2010 16:18:23 -0400 Received: from tyan-ft48-01.lab.bos.redhat.com (tyan-ft48-01.lab.bos.redhat.com [10.16.42.4]) by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o6TKIMaw008403 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 29 Jul 2010 16:18:23 -0400 Received: from tyan-ft48-01.lab.bos.redhat.com (tyan-ft48-01.lab.bos.redhat.com [127.0.0.1]) by tyan-ft48-01.lab.bos.redhat.com (8.14.4/8.14.4) with ESMTP id o6TKKrjN020996; Thu, 29 Jul 2010 22:20:53 +0200 Received: (from jakub@localhost) by tyan-ft48-01.lab.bos.redhat.com (8.14.4/8.14.4/Submit) id o6TKKrmu020995; Thu, 29 Jul 2010 22:20:53 +0200 Date: Thu, 29 Jul 2010 22:20:53 +0200 From: Jakub Jelinek To: Jason Merrill Cc: Tom Tromey , gcc-patches@gcc.gnu.org, Roland McGrath Subject: Re: [PATCH] Fix up DW_AT_accessibility (PR debug/45124) Message-ID: <20100729202053.GO18378@tyan-ft48-01.lab.bos.redhat.com> Reply-To: Jakub Jelinek References: <20100729130932.GF18378@tyan-ft48-01.lab.bos.redhat.com> <4C5189D4.5090203@redhat.com> <20100729171246.GJ18378@tyan-ft48-01.lab.bos.redhat.com> <4C51B6B5.4020400@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4C51B6B5.4020400@redhat.com> User-Agent: Mutt/1.5.20 (2009-12-10) X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On Thu, Jul 29, 2010 at 01:13:25PM -0400, Jason Merrill wrote: > OK. Actually, given the response on Dwarf-Discuss, I believe we should limit this only to DW_TAG_member and DW_TAG_subprogram (to match the spec; DW_TAG_inheritance handled in the other routine), as for say types and other children of DW_TAG_class_type no DECL_PRIVATE doesn't mean we need to emit DW_AT_accessibility DW_ACCESS_public, but instead just that accessibility is not meaningful for it. 2010-07-29 Jakub Jelinek PR debug/45124 * dwarf2out.c (add_accessibility_attribute): Assume DW_ACCESS_private as the default for dwarf_version > 2 and DW_TAG_class_type parent. (gen_inheritance_die): Assume DW_ACCESS_public as the default for dwarf_version > 2 and parent other than DW_TAG_class_type. Jakub --- gcc/dwarf2out.c.jj 2010-07-29 21:49:03.827604473 +0200 +++ gcc/dwarf2out.c 2010-07-29 22:14:28.231354703 +0200 @@ -15834,10 +15834,26 @@ add_AT_location_description (dw_die_ref static void add_accessibility_attribute (dw_die_ref die, tree decl) { + /* In DWARF3+ the default is DW_ACCESS_private only in DW_TAG_class_type + children, otherwise the default is DW_ACCESS_public. In DWARF2 + the default has always been DW_ACCESS_public. */ if (TREE_PROTECTED (decl)) add_AT_unsigned (die, DW_AT_accessibility, DW_ACCESS_protected); else if (TREE_PRIVATE (decl)) - add_AT_unsigned (die, DW_AT_accessibility, DW_ACCESS_private); + { + if (dwarf_version == 2 + || die->die_parent == NULL + || die->die_parent->die_tag != DW_TAG_class_type + || (die->die_tag != DW_TAG_member + && die->die_tag != DW_TAG_subprogram)) + add_AT_unsigned (die, DW_AT_accessibility, DW_ACCESS_private); + } + else if (dwarf_version > 2 + && die->die_parent + && die->die_parent->die_tag == DW_TAG_class_type + && (die->die_tag == DW_TAG_member + || die->die_tag == DW_TAG_subprogram)) + add_AT_unsigned (die, DW_AT_accessibility, DW_ACCESS_public); } /* Attach the specialized form of location attribute used for data members of @@ -19567,10 +19583,20 @@ gen_inheritance_die (tree binfo, tree ac if (BINFO_VIRTUAL_P (binfo)) add_AT_unsigned (die, DW_AT_virtuality, DW_VIRTUALITY_virtual); + /* In DWARF3+ the default is DW_ACCESS_private only in DW_TAG_class_type + children, otherwise the default is DW_ACCESS_public. In DWARF2 + the default has always been DW_ACCESS_private. */ if (access == access_public_node) - add_AT_unsigned (die, DW_AT_accessibility, DW_ACCESS_public); + { + if (dwarf_version == 2 + || context_die->die_tag == DW_TAG_class_type) + add_AT_unsigned (die, DW_AT_accessibility, DW_ACCESS_public); + } else if (access == access_protected_node) add_AT_unsigned (die, DW_AT_accessibility, DW_ACCESS_protected); + else if (dwarf_version > 2 + && context_die->die_tag != DW_TAG_class_type) + add_AT_unsigned (die, DW_AT_accessibility, DW_ACCESS_private); } /* Generate a DIE for a class member. */