From patchwork Thu Jun 24 17:11:34 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve Ellcey X-Patchwork-Id: 56812 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id AB9E3B6F3E for ; Fri, 25 Jun 2010 03:11:47 +1000 (EST) Received: (qmail 19966 invoked by alias); 24 Jun 2010 17:11:44 -0000 Received: (qmail 19939 invoked by uid 22791); 24 Jun 2010 17:11:42 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL, BAYES_00, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from g5t0009.atlanta.hp.com (HELO g5t0009.atlanta.hp.com) (15.192.0.46) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 24 Jun 2010 17:11:38 +0000 Received: from smtp1.cup.hp.com (smtp.cup.hp.com [16.89.217.160]) by g5t0009.atlanta.hp.com (Postfix) with ESMTP id 3D418304F7 for ; Thu, 24 Jun 2010 17:11:35 +0000 (UTC) Received: from lucas.cup.hp.com (lucas.cup.hp.com [15.244.97.116]) by smtp1.cup.hp.com (Postfix) with ESMTP id A618851521A for ; Thu, 24 Jun 2010 16:44:23 +0000 (UTC) Received: (from sje@localhost) by lucas.cup.hp.com (8.11.1 (PHNE_35485)/8.11.1) id o5OHBYu01679 for gcc-patches@gcc.gnu.org; Thu, 24 Jun 2010 10:11:34 -0700 (PDT) Date: Thu, 24 Jun 2010 10:11:34 -0700 (PDT) From: Steve Ellcey Message-Id: <201006241711.o5OHBYu01679@lucas.cup.hp.com> To: gcc-patches@gcc.gnu.org Subject: [patch, testsuite] Patch for PR 43283, semicolon may not start new line Reply-To: sje@cup.hp.com Mime-Version: 1.0 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org The gcc.dg/lto/20091216-1 test fails on PA and IA64 platforms for two reasons. One is that a semicolon starts a comment on these platforms and not a new line. Other platforms probably have this issue too based on the value of comment_chars in the GNU assembler sources. The second issue is that the nop statement on IA64 requires an argument. This patch fixes both problems. I made the change from a semicolon to a newline global but it could be ifdefed on __hppa if people don't want the change to be global. This seems to work fine for me though on x86 linux as well as my PA and IA64 platforms. Tested on hppa2.0w-hp-hpux11.11, hppa64-hp-hpux11.11, ia64-hp-hpux11.23, ia64-debian-linux-gnu, and x86_64-redhat-linux-gnu. OK for checkin? Steve Ellcey sje@cup.hp.com 2010-06-24 Steve Ellcey PR testsuite/43283 * gcc.dg/lto/20091216-1_0.c: Use newline instead of semicolon and add argument to nop for IA64. Index: gcc.dg/lto/20091216-1_0.c =================================================================== --- gcc.dg/lto/20091216-1_0.c (revision 161306) +++ gcc.dg/lto/20091216-1_0.c (working copy) @@ -1,6 +1,10 @@ /* { dg-lto-do run } */ -asm (".globl start_; start_: nop"); +#ifdef __ia64 +asm (".globl start_\nstart_: nop 0"); +#else +asm (".globl start_\nstart_: nop"); +#endif int main ()