From patchwork Fri Jun 18 11:00:23 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Modra X-Patchwork-Id: 56173 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 595DEB7D84 for ; Fri, 18 Jun 2010 21:00:44 +1000 (EST) Received: (qmail 9544 invoked by alias); 18 Jun 2010 11:00:40 -0000 Received: (qmail 9417 invoked by uid 22791); 18 Jun 2010 11:00:39 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from mail-pv0-f175.google.com (HELO mail-pv0-f175.google.com) (74.125.83.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 18 Jun 2010 11:00:33 +0000 Received: by pvh11 with SMTP id 11so395273pvh.20 for ; Fri, 18 Jun 2010 04:00:31 -0700 (PDT) Received: by 10.115.66.34 with SMTP id t34mr760959wak.6.1276858831157; Fri, 18 Jun 2010 04:00:31 -0700 (PDT) Received: from bubble.grove.modra.org ([115.187.252.19]) by mx.google.com with ESMTPS id b6sm107460245wam.9.2010.06.18.04.00.28 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 18 Jun 2010 04:00:29 -0700 (PDT) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 35A05170C47B; Fri, 18 Jun 2010 20:30:23 +0930 (CST) Date: Fri, 18 Jun 2010 20:30:23 +0930 From: Alan Modra To: Richard Guenther Cc: David Edelsohn , gcc-patches@gcc.gnu.org Subject: Re: PowerPC64 large toc model Message-ID: <20100618110023.GD18443@bubble.grove.modra.org> Mail-Followup-To: Richard Guenther , David Edelsohn , gcc-patches@gcc.gnu.org References: <20100608125703.GI7312@bubble.grove.modra.org> <20100615074125.GF9748@bubble.grove.modra.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On Fri, Jun 18, 2010 at 12:00:29PM +0200, Richard Guenther wrote: > This broke bootstrap on linux64 with > > 11:55 < richi> ../../mem-ref2/gcc/config/rs6000/rs6000.c: In function > 'rs6000_override_options': > 11:55 < richi> ../../mem-ref2/gcc/config/rs6000/rs6000.c:2775:3: error: suggest > braces around empty body in an 'if' statement > [-Werror=empty-body] Oops. You need bleeding edge GNU ld to pass the HAVE_LD_LARGE_TOC configure test, and an in-tree binutils needs to have its version hacked to 2.21. Committing the following as obvious. Sorry about the breakage. * config/rs6000/linux64.h (SET_CMODEL): Don't expand to empty. Index: gcc/config/rs6000/linux64.h =================================================================== --- gcc/config/rs6000/linux64.h (revision 160977) +++ gcc/config/rs6000/linux64.h (working copy) @@ -70,7 +70,7 @@ extern enum rs6000_cmodel cmodel; #define TARGET_CMODEL cmodel #define SET_CMODEL(opt) cmodel = opt #else -#define SET_CMODEL(opt) +#define SET_CMODEL(opt) do {} while (0) #endif #undef PROCESSOR_DEFAULT