From patchwork Fri Jul 2 02:28:22 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Kewen.Lin" X-Patchwork-Id: 1499840 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=rOm6zeko; dkim-atps=neutral Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4GGJtJ72vYz9sXS for ; Fri, 2 Jul 2021 12:28:55 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2D2813973026 for ; Fri, 2 Jul 2021 02:28:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2D2813973026 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1625192932; bh=fXQUF/klcWNGlKyY95M2q2YQuU/ALuvEfqiXpL7SlDY=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=rOm6zekoKhAm4aEXXfpyeF0Af21V3EJl/JXLTd4NHiltxmCN50LPWjGh/+NB+KphX cY5henSKu+O/UBYD+SmXTZ29IwRw3D87+Sr1Ju76fKIEw87uLIr19c06ig0ayfXYqp 284/hozhSCsm17zC6aYZ3s9guQTz/jE7ysgjx6zc= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 6833F3858004 for ; Fri, 2 Jul 2021 02:28:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6833F3858004 Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 16223Ckb036569 for ; Thu, 1 Jul 2021 22:28:30 -0400 Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 39hk3b9t3q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 01 Jul 2021 22:28:30 -0400 Received: from m0098393.ppops.net (m0098393.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 16223bI2037217 for ; Thu, 1 Jul 2021 22:28:30 -0400 Received: from ppma03ams.nl.ibm.com (62.31.33a9.ip4.static.sl-reverse.com [169.51.49.98]) by mx0a-001b2d01.pphosted.com with ESMTP id 39hk3b9t38-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 01 Jul 2021 22:28:29 -0400 Received: from pps.filterd (ppma03ams.nl.ibm.com [127.0.0.1]) by ppma03ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 1622MCiR016972; Fri, 2 Jul 2021 02:28:27 GMT Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by ppma03ams.nl.ibm.com with ESMTP id 39duv8ankf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 02 Jul 2021 02:28:27 +0000 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 1622SPHb33685900 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 2 Jul 2021 02:28:25 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 20960AE05A; Fri, 2 Jul 2021 02:28:25 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 95353AE055; Fri, 2 Jul 2021 02:28:23 +0000 (GMT) Received: from KewenLins-MacBook-Pro.local (unknown [9.200.53.103]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP; Fri, 2 Jul 2021 02:28:23 +0000 (GMT) Subject: [PATCH] i386: Disable param ira-consider-dup-in-all-alts [PR100328] To: gcc-patches@gcc.gnu.org References: <8a5fd52a-1cc9-6563-ee6c-f345b489654c@linux.ibm.com> <46f79a40-6927-35f3-6eda-f49d1faccbc9@redhat.com> <0f75aadc-c389-ad37-3383-3be5b093c3e5@linux.ibm.com> Message-ID: <1f49b5b4-51a0-2695-c797-233d3ffe73c0@linux.ibm.com> Date: Fri, 2 Jul 2021 10:28:22 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 In-Reply-To: <0f75aadc-c389-ad37-3383-3be5b093c3e5@linux.ibm.com> Content-Language: en-US X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: ePgx27F9lPKRd8Vc1dQcn3Yuzab1tt1X X-Proofpoint-GUID: 05qc6Wf6_OM6HxdsotUFxJrnQ_Q-RovD X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790 definitions=2021-07-01_12:2021-07-01, 2021-07-01 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 adultscore=0 malwarescore=0 mlxlogscore=999 lowpriorityscore=0 spamscore=0 mlxscore=0 suspectscore=0 priorityscore=1501 clxscore=1015 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2107020009 X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: "Kewen.Lin via Gcc-patches" From: "Kewen.Lin" Reply-To: "Kewen.Lin" Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" Hi, With Hongtao's help (thanks), we got the SPEC2017 performance evaluation result on x86_64 (see [1]), this new parameter ira-consider-dup-in-all-alts has negative effects on i386. Since we observed it can benefit ports aarch64 and rs6000, the param is set as 1 by default, this patch is to disable it on i386 explicitly to avoid performance degradation there. Bootstrapped & regtested on x86_64-redhat-linux. Is it ok for trunk? BR, Kewen [1] https://gcc.gnu.org/pipermail/gcc-patches/2021-June/573986.html ----- From 457c7b3032e20ea0f9d8c8d2980e7da6daeedb13 Mon Sep 17 00:00:00 2001 From: Kewen Lin Date: Mon, 21 Jun 2021 22:51:09 -0500 Subject: [PATCH 2/2] i386: Disable param ira-consider-dup-in-all-alts [PR100328] With Hongtao's SPEC2017 performance evaluation result here: https://gcc.gnu.org/pipermail/gcc-patches/2021-June/573986.html this new parameter ira-consider-dup-in-all-alts has negative effects on i386, this patch is to disable it explicitly on i386. Bootstrapped & regtested on x86_64-redhat-linux. gcc/ChangeLog: PR rtl-optimization/100328 * config/i386/i386-options.c (ix86_option_override_internal): Set param_ira_consider_dup_in_all_alts to 0. --- gcc/config/i386/i386-options.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gcc/config/i386/i386-options.c b/gcc/config/i386/i386-options.c index 0eccb549c22..7a35c468da3 100644 --- a/gcc/config/i386/i386-options.c +++ b/gcc/config/i386/i386-options.c @@ -2831,6 +2831,8 @@ ix86_option_override_internal (bool main_args_p, if (ix86_indirect_branch != indirect_branch_keep) SET_OPTION_IF_UNSET (opts, opts_set, flag_jump_tables, 0); + SET_OPTION_IF_UNSET (opts, opts_set, param_ira_consider_dup_in_all_alts, 0); + return true; }