From patchwork Mon Jan 22 02:14:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Law X-Patchwork-Id: 1888969 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=QVhNXdx2; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4TJDLn4YFMz23db for ; Mon, 22 Jan 2024 13:14:40 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 249F7385841A for ; Mon, 22 Jan 2024 02:14:36 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-io1-xd2d.google.com (mail-io1-xd2d.google.com [IPv6:2607:f8b0:4864:20::d2d]) by sourceware.org (Postfix) with ESMTPS id 28B853858D3C for ; Mon, 22 Jan 2024 02:14:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 28B853858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 28B853858D3C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::d2d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705889655; cv=none; b=SoiLfFjo/wK1eswXf/HCFgV1gndON1Rk4teEu3cOQoN9y1VvuCtu7b//2DOzzctnxQ+cWLbAnugrSp47J79Q0UItvkib8axt0V4/QNSCkjq322RNpvIK2L8bawYRYgydp3bbT4RVb7Fw3OUL2HKp3Jrz9eytnq22aoWBXue9vSQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705889655; c=relaxed/simple; bh=7JhQvDzT7hbCwQI+a2enb7M0pqs2wBLXYGd/3SDhrTQ=; h=DKIM-Signature:Message-ID:Date:MIME-Version:From:To:Subject; b=uWlmGqhveEIQ6IGoSShqGz66tQMYE0oE9Q/LUJqsKeTv5/ZOFURmCletnqOfXLYLIdiY7S1ynQBoEalA8BGYFYDgdeYR1UkPiO6G30v24lj+6pB/kSM7kfkx1GRTFLQBzyjjEDx4+adV6aBtU5MncVJZlYpFKRJC59RXJrehX/I= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-io1-xd2d.google.com with SMTP id ca18e2360f4ac-7baa8097064so174379739f.3 for ; Sun, 21 Jan 2024 18:14:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705889645; x=1706494445; darn=gcc.gnu.org; h=subject:to:from:content-language:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=w/EJf5gYjLRuPp7yE+85P9gKOi7ly6CWahNkU4d5Owg=; b=QVhNXdx2W9y6X91Ga3r+ShHlObl4eXm4f8DGosPjKHSmuAZRbZBUtDvkwKOb/34UXx ZyhSmQV2PtxWqWzTyG0yHoX6fjfFHOLkUuLedomuUzCRr1Zj6PkNqv5DBtyTJF2iB57E ohSkwOH6fPs9T8BsdjeBQ+4r9rdt1c/HGVVjZ7HgOfA+p+CEdYFZwM8O11q8YRua0i+u rfW5HGntOueuhMtFoZq627bgGXV7jF9L71Y39i2UF75BrymVqAPODJSXjUO9Te/Ck5lj RA7jjaXdpcHzhylvUSmQH15vLd8aurlRdJH1L+HCGFWl2PHtngZnRdcR6iTJdPILN7LO YSEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705889645; x=1706494445; h=subject:to:from:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=w/EJf5gYjLRuPp7yE+85P9gKOi7ly6CWahNkU4d5Owg=; b=F07lXoudWwMyacKy9+riSD+vEvG2P6D4t19G9bW8hDIMX7OIPiqYcMOplWv8UPwz48 wbkm2P2FsCs3dA0271UriZ+UKzsBz+dOT6ZuWhPYV7V0oCGRwY3PO5FHh/PNzSzvZLb4 2KuJcCBReGC+2uLmbUouSF6IfVJY89sDJTh0tQcrQwKt1O2XvnuyX1YtImmwMzrNo/rv WwGUMFz+iy9hKkvHrCVdjjRJuz8c+tQz+j6FJemWcBnIH/ux90HNplHgWV9myR4K+5AJ Wm6UxrlFj5egpRCIBbYbp2IUv4Hk0mI+MWNW3tGHPgmXKHdEia32US7m4yU4RQUfxKVe oqfw== X-Gm-Message-State: AOJu0YyGrTSjeanIHDtYvyji9J+aVRiFSQWMZRLGzOP4VgEvBReB+u3s dWvjkFCz0Itvo2PqoCMjWwnvr5Z0JtgROdODcGseiMPDHUwIO9CO0VlfhpeY X-Google-Smtp-Source: AGHT+IH5tzLMKdEycAxjnkRUxrchd5uUO1aYS7KIqoGbdEmKKtkRin7FUUclTXh/Q1iIvFxLwYxVug== X-Received: by 2002:a92:60f:0:b0:361:a1fa:d3aa with SMTP id x15-20020a92060f000000b00361a1fad3aamr3421672ilg.61.1705889644950; Sun, 21 Jan 2024 18:14:04 -0800 (PST) Received: from [172.31.0.109] ([136.36.72.243]) by smtp.gmail.com with ESMTPSA id 19-20020a056e0211b300b00361a84b89cfsm2177688ilj.51.2024.01.21.18.14.03 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 21 Jan 2024 18:14:04 -0800 (PST) Message-ID: <1d1bfa3e-8b63-47d6-91e9-6646c71a408e@gmail.com> Date: Sun, 21 Jan 2024 19:14:02 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US From: Jeff Law To: "gcc-patches@gcc.gnu.org" Subject: [committed] Adjust expectations for pr59533-1.c X-Spam-Status: No, score=-8.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org The change for pr111267 twiddled code generation for sh/pr59533-1.c We end up eliminating two comparisons, but require two shll instructions to do so. And in a couple places we're using an addc sequence rather than a subc sequence. This patch adjusts the expected codegen for the test as all those are either a wash or a The fwprop change does cause some code regressions on the same test. I'll file a distinct but for that issue. Pushed to the trunk, Jeff commit 7e16f819ff413c48702f9087b62eaac39a060a14 Author: Jeff Law Date: Sun Jan 21 19:12:21 2024 -0700 [committed] Adjust expectations for pr59533-1.c The change for pr111267 twiddled code generation for sh/pr59533-1.c We end up eliminating two comparisons, but require two shll instructions to do so. And in a couple places we're using an addc sequence rather than a subc sequence. This patch adjusts the expected codegen for the test as all those are either a wash or a The fwprop change does cause some code regressions on the same test. I'll file a distinct but for that issue. gcc/testsuite * gcc.target/sh/pr59533-1.c: Adjust expected output. diff --git a/gcc/testsuite/gcc.target/sh/pr59533-1.c b/gcc/testsuite/gcc.target/sh/pr59533-1.c index b0469859df5..859b8e2d24c 100644 --- a/gcc/testsuite/gcc.target/sh/pr59533-1.c +++ b/gcc/testsuite/gcc.target/sh/pr59533-1.c @@ -2,15 +2,15 @@ /* { dg-do compile } */ /* { dg-options "-O1" } */ -/* { dg-final { scan-assembler-times "shll" 1 } } */ +/* { dg-final { scan-assembler-times "shll" 3 } } */ /* { dg-final { scan-assembler-times "movt" 5 } } */ /* { dg-final { scan-assembler-times "rotcl" 1 } } */ /* { dg-final { scan-assembler-times "and" 3 } } */ /* { dg-final { scan-assembler-times "extu.b" 5 } } */ -/* { dg-final { scan-assembler-times "cmp/pz" 27 { target { ! sh2a } } } } */ -/* { dg-final { scan-assembler-times "addc" 4 { target { ! sh2a } } } } */ -/* { dg-final { scan-assembler-times "subc" 16 { target { ! sh2a } } } } */ +/* { dg-final { scan-assembler-times "cmp/pz" 25 { target { ! sh2a } } } } */ +/* { dg-final { scan-assembler-times "addc" 6 { target { ! sh2a } } } } */ +/* { dg-final { scan-assembler-times "subc" 14 { target { ! sh2a } } } } */ /* { dg-final { scan-assembler-times "cmp/pz" 25 { target { sh2a } } } } */ /* { dg-final { scan-assembler-times "addc" 6 { target { sh2a } } } } */