From patchwork Thu Jan 2 04:53:33 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Mike Stump X-Patchwork-Id: 306052 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 1B5D02C0040 for ; Thu, 2 Jan 2014 15:53:46 +1100 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :content-type:mime-version:subject:from:in-reply-to:date:cc :message-id:references:to; q=dns; s=default; b=HVwCC8Wvwm4zWayyq KHbdS2D62SbQFeaPHagXh42LfHYTWYHtbmy0eYoroUPNllVt+fBLmbz2AsCNHU0g rNkr03ryREDmJFCzxeZXJ9FoSJPZJbpZGBN96GLev191BQhujLIHVMs0WNtAA5Xe 99p0jJE1NBkVeaOHx+y4nen1Ak= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :content-type:mime-version:subject:from:in-reply-to:date:cc :message-id:references:to; s=default; bh=xyxYNjNz6ZPoPPx9AHeB7DT d84w=; b=o9S+hKOPCk3qC9QHyuORWBkJ1NNZQBG9+HZPtNDXiKQSYxXrQgRAcHS EbJGuhSSwJ9sblv3im9FOjRBmE9j7e6HVnbX6Or8y1Z503CM7c7KISDO6iWGA0n+ eD5HEUoGw92Lga14mreClLQwyrJR7GOFk4LOucVthBr0Amyx0yP4= Received: (qmail 3858 invoked by alias); 2 Jan 2014 04:53:39 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 3842 invoked by uid 89); 2 Jan 2014 04:53:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 X-HELO: qmta02.emeryville.ca.mail.comcast.net Received: from qmta02.emeryville.ca.mail.comcast.net (HELO qmta02.emeryville.ca.mail.comcast.net) (76.96.30.24) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 02 Jan 2014 04:53:36 +0000 Received: from omta04.emeryville.ca.mail.comcast.net ([76.96.30.35]) by qmta02.emeryville.ca.mail.comcast.net with comcast id 8ssh1n0010lTkoCA2stbkL; Thu, 02 Jan 2014 04:53:35 +0000 Received: from up.mrs.kithrup.com ([24.4.193.8]) by omta04.emeryville.ca.mail.comcast.net with comcast id 8sta1n0050BKwT48Qstauy; Thu, 02 Jan 2014 04:53:34 +0000 Mime-Version: 1.0 (Mac OS X Mail 6.6 \(1510\)) Subject: Re: wide-int, sched From: Mike Stump In-Reply-To: <533804F2-1FEA-40FF-A3DE-DFC670CE0D14@comcast.net> Date: Wed, 1 Jan 2014 20:53:33 -0800 Cc: "gcc-patches@gcc.gnu.org Patches" , Kenneth Zadeck , Mike Stump Message-Id: <1BCFB9BF-3E7D-4B95-B4D4-B8CC1D19144E@comcast.net> References: <533804F2-1FEA-40FF-A3DE-DFC670CE0D14@comcast.net> To: Jeff Law X-IsSubscribed: yes On Nov 23, 2013, at 11:22 AM, Mike Stump wrote: > Richi has asked the we break the wide-int patch so that the individual port and front end maintainers can review their parts without have to go through the entire patch. This patch covers the scheduler code. > > Ok? Ping? I promise, this one is easy… * sched-vis.c (print_value): Handle CONST_WIDE_INT. * sel-sched-ir.c (lhs_and_rhs_separable_p): Update comment. diff --git a/gcc/sched-vis.c b/gcc/sched-vis.c index a965c4d..8fa29bf 100644 --- a/gcc/sched-vis.c +++ b/gcc/sched-vis.c @@ -428,6 +428,23 @@ print_value (pretty_printer *pp, const_rtx x, int verbose) pp_scalar (pp, HOST_WIDE_INT_PRINT_HEX, (unsigned HOST_WIDE_INT) INTVAL (x)); break; + + case CONST_WIDE_INT: + { + const char *sep = "<"; + int i; + for (i = CONST_WIDE_INT_NUNITS (x) - 1; i >= 0; i--) + { + pp_string (pp, sep); + sep = ","; + sprintf (tmp, HOST_WIDE_INT_PRINT_HEX, + (unsigned HOST_WIDE_INT) CONST_WIDE_INT_ELT (x, i)); + pp_string (pp, tmp); + } + pp_greater (pp); + } + break; + case CONST_DOUBLE: if (FLOAT_MODE_P (GET_MODE (x))) { diff --git a/gcc/sel-sched-ir.c b/gcc/sel-sched-ir.c index 7dfc703..0db84e6 100644 --- a/gcc/sel-sched-ir.c +++ b/gcc/sel-sched-ir.c @@ -1141,10 +1141,10 @@ lhs_and_rhs_separable_p (rtx lhs, rtx rhs) if (lhs == NULL || rhs == NULL) return false; - /* Do not schedule CONST, CONST_INT and CONST_DOUBLE etc as rhs: no point - to use reg, if const can be used. Moreover, scheduling const as rhs may - lead to mode mismatch cause consts don't have modes but they could be - merged from branches where the same const used in different modes. */ + /* Do not schedule constants as rhs: no point to use reg, if const + can be used. Moreover, scheduling const as rhs may lead to mode + mismatch cause consts don't have modes but they could be merged + from branches where the same const used in different modes. */ if (CONSTANT_P (rhs)) return false;