| Message ID | 19c07eec-e215-4b94-96ac-81640b3a6163@linux.ibm.com |
|---|---|
| State | New |
| Headers | show |
| Series | rs6000, add comment to VEC_IC definition | expand |
Hi Carl, on 2024/7/27 07:31, Carl Love wrote: > GCC maintainers: > > This patch adds a comment to the VEC_IC definitions to clarify the V1TI "TARGET_POWER10" mode per the request by Segher in the feedback to patch "https://gcc.gnu.org/pipermail/gcc-patches/2024-July/658156.html". > > https://gcc.gnu.org/pipermail/gcc-patches/2024-July/658156.html > > Please let me know if this patch is acceptable for mainline. > > Thanks. > > Carl > ---------------------------------------------------------------- > rs6000, add comment to VEC_IC definition > > This patch adds a comment to the VEC_IC definition to clarify > the V1TI "TARGET_POWER10" mode that was added. > > gcc/ChangeLog: > * config/rs6000/vector.md: Add comment for the VEC_IC > define_mode_iterator. > --- > gcc/config/rs6000/vector.md | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/gcc/config/rs6000/vector.md b/gcc/config/rs6000/vector.md > index 0d3e0a24e11..75d95ccfb47 100644 > --- a/gcc/config/rs6000/vector.md > +++ b/gcc/config/rs6000/vector.md > @@ -26,7 +26,8 @@ > ;; Vector int modes > (define_mode_iterator VEC_I [V16QI V8HI V4SI V2DI]) > > -;; Vector int modes for comparison, shift and rotation > +;; Vector int modes for comparison, shift and rotation. ISA 3.1 adds the V1TI mode > +;; for the int128 type. Maybe s/int128/vector int128/, OK with/without this nit tweaked, thanks! BR, Kewen > (define_mode_iterator VEC_IC [V16QI V8HI V4SI V2DI (V1TI "TARGET_POWER10")]) > > ;; 128-bit int modes
Kewen: On 7/29/24 3:21 AM, Kewen.Lin wrote: >> index 0d3e0a24e11..75d95ccfb47 100644 >> --- a/gcc/config/rs6000/vector.md >> +++ b/gcc/config/rs6000/vector.md >> @@ -26,7 +26,8 @@ >> ;; Vector int modes >> (define_mode_iterator VEC_I [V16QI V8HI V4SI V2DI]) >> >> -;; Vector int modes for comparison, shift and rotation >> +;; Vector int modes for comparison, shift and rotation. ISA 3.1 adds the V1TI mode >> +;; for the int128 type. > Maybe s/int128/vector int128/, OK with/without this nit tweaked, thanks! OK, made the change and committed the patch. Thanks. Carl
diff --git a/gcc/config/rs6000/vector.md b/gcc/config/rs6000/vector.md index 0d3e0a24e11..75d95ccfb47 100644 --- a/gcc/config/rs6000/vector.md +++ b/gcc/config/rs6000/vector.md @@ -26,7 +26,8 @@ ;; Vector int modes (define_mode_iterator VEC_I [V16QI V8HI V4SI V2DI]) -;; Vector int modes for comparison, shift and rotation +;; Vector int modes for comparison, shift and rotation. ISA 3.1 adds the V1TI mode +;; for the int128 type. (define_mode_iterator VEC_IC [V16QI V8HI V4SI V2DI (V1TI "TARGET_POWER10")])