From patchwork Wed Dec 20 13:36:57 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Carlini X-Patchwork-Id: 851474 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-469651-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="JSjeHVVH"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3z1wtj2w30z9s7f for ; Thu, 21 Dec 2017 00:42:18 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to :from:subject:message-id:date:mime-version:content-type; q=dns; s=default; b=Y7Y5QJYjN6jB8fSUGEZoPsms87V/DRizlu6RAo/RLzcOkuqJNw yvTtLClJnaFKQ+mwuip+5QIiWlvSYb1Rdtq1cWkuSIQDVuMeqicXPU+OlzPatT3V AIMEWdsBZHBRT9D9nzEVDziKxkRcIMDVNv8wGCbRvkMkkbJYCODIrOI1k= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to :from:subject:message-id:date:mime-version:content-type; s= default; bh=8iqYJ4RhHbjinZlbfd+2XV2B4A4=; b=JSjeHVVHt6PvG16P588I j0M1TS97u8zZbSvSdRWAq+7pRdk/ivywtEM4XkH2IW3zVQ77f8fZEGV3bOX9sA3m Z2w8fBoqhVUOoL6PvH2rsNfnuXO7tbzYDAd+DpgGRpX1LqE5Zyz1XWLJpKhWQGo0 L+SV7ZFr/JAWQLTpMEur4qU= Received: (qmail 23273 invoked by alias); 20 Dec 2017 13:42:06 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 23209 invoked by uid 89); 20 Dec 2017 13:42:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=BAYES_00, GIT_PATCH_2, GIT_PATCH_3, SPF_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: userp2120.oracle.com Received: from userp2120.oracle.com (HELO userp2120.oracle.com) (156.151.31.85) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 20 Dec 2017 13:42:03 +0000 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.21/8.16.0.21) with SMTP id vBKDaxWH142028 for ; Wed, 20 Dec 2017 13:42:01 GMT Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp2120.oracle.com with ESMTP id 2eynt2gwhs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 20 Dec 2017 13:42:01 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id vBKDaxgM028287 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 20 Dec 2017 13:36:59 GMT Received: from abhmp0008.oracle.com (abhmp0008.oracle.com [141.146.116.14]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id vBKDaxQO006129 for ; Wed, 20 Dec 2017 13:36:59 GMT Received: from [192.168.1.4] (/87.3.196.15) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 20 Dec 2017 05:36:59 -0800 To: "gcc-patches@gcc.gnu.org" From: Paolo Carlini Subject: [middle-end, obvious] Remove dead error_mark_node check Message-ID: <17a84267-ef67-bd31-4c81-336722ae42b8@oracle.com> Date: Wed, 20 Dec 2017 14:36:57 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8750 signatures=668650 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=958 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1712200196 X-IsSubscribed: yes Hi, today noticed this nit too: when ret_expr == error_mark_node gimplify_return_expr immediatey returns GS_ERROR. Thanks, Paolo. ////////////////// 2017-12-20 Paolo Carlini * gimplify.c (gimplify_return_expr): Remove dead error_mark_node check. Index: gimplify.c =================================================================== --- gimplify.c (revision 255855) +++ gimplify.c (working copy) @@ -1499,10 +1499,9 @@ gimplify_return_expr (tree stmt, gimple_ if (ret_expr == error_mark_node) return GS_ERROR; if (!ret_expr - || TREE_CODE (ret_expr) == RESULT_DECL - || ret_expr == error_mark_node) + || TREE_CODE (ret_expr) == RESULT_DECL) { maybe_add_early_return_predict_stmt (pre_p); greturn *ret = gimple_build_return (ret_expr); gimple_set_no_warning (ret, TREE_NO_WARNING (stmt));